• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates

Applied Lars Pind's patch #177, which adds a missing <tr> tag to the

template.

1. Changed a lot of package info files to fix problems ...

2. Added Vinod's bboard patch

3. Rationalized party e-mail checking by putting a "before insert or update"

trigger on the table that lower-cases email (this was already done by the

party.new() func but at least one update missed this). Got rid of all

"lower(email) = " and "upper(email) = " checks and just made all use the

db email column directly and lower-cased Tcl vars. In this way the index

on the email column is always and consistently used without needing to

define functional indexes on the column (an EE feature for Oracle).

4. Rationalized naming of a couple of workflows and fixed a glossary PG bug

where apparently its workflow got overwritten by one from the CMS at some

point in time.

5. Made the .cmp/.dat/.frm filters in the template code usable though not

very beautiful nor exactly correct. But with practice you can use them

to debug pages in the packages/* hierarchy. I also turned these off by

default as there's no need to run these filters on a production site!

6. Performed minor surgery on templating, including adding a new

"ad_return_exception_template" that allows you to return a templated

error page and aborts the script.

7. ??? probably but I think this covers most stuff.

    • -4
    • +4
    ./sql/oracle/ticket-tracker-packages.sql
    • -2
    • +2
    ./sql/oracle/ttracker-workflow-create.sql
  1. … 73 more files in changeset.
removed excess files from .info file

cleaned up email check

    • -19
    • +0
    ./www/admin/install/index-oracle.xql
    • -19
    • +0
    ./www/admin/install/index-postgresql.xql
1) cleaned up workflows .info file

2) fixed error message in acs-workflow

3) fixed code to reassign tasks to users

4) send return_url to task-action.adp

5) fixed bug in ticket-tracker's clarify_fire callback

6) added return_url to ticket tracker's emails

  1. … 7 more files in changeset.
1) added missing param to workflow_case__add_task_assignment

2) Fixed minor typos in workflow docs, ACS->OpenACS

  1. … 17 more files in changeset.

1. Added session-update.tcl, a small utility which somewhat safely allows

you to put up a link that changes a session_property, for instance to

change the number of items displayed or that sort of thing. The caller

must sign their values and URL, which are verified by the callee via

ad_page_contract. If the referrer doesn't match the signed expected

referrer, you get bounced. I think this is reasonably secure (though

permissions should always be rigorously checked on all pages, of course)

2. acs_events had an html_p flag in the datamodel but no way to set it.

Fixed. It should really be a mime-type but since it's not using the

CR, and since I'm extremely busy with other stuff, I didn't fix it.

3. While doing #1 above I learned that signing and verifying arrays didn't

quite work. Fixed.

4. Found and fixed a small problem with my earlier work on the currency widget.

    • -11
    • +14
    ./sql/oracle/ticket-tracker-packages.sql
  1. … 13 more files in changeset.
use ad_acs_kernel_id to get package_id

adjusted install sequence to use ad_parameter instead of checking db directly

initial revision of acs-workflow-4.3

    • -3
    • +3
    ./sql/oracle/ticket-tracker-packages.sql
initial revision of acs-workflow-4.3

    • -2
    • +2
    ./sql/oracle/ticket-tracker-packages.sql
initial revision of acs-workflow-4.3

initial revision of acs-workflow-4.3

initial revision of acs-workflow-4.3

initial revision of acs-workflow-4.3

initial revision of acs-workflow-4.3

initial revision of acs-workflow-4.3

    • -290
    • +593
    ./sql/oracle/ttracker-workflow-create.sql
  1. … 8 more files in changeset.
initial revision of acs-workflow-4.3

  1. … 1 more file in changeset.

1. Added a new Tcl procedure to the content repository's library, named

cr_write_content, which properly writes content to the connection

regardless of RDBMS and storage type. This simplified a bunch of stuff

(which explains the removed files).

2. Fixed a lot of general comments issues regarding HTML vs. Plain/Text,

attachments, etc.

3. Partially ported glossary.

  1. … 81 more files in changeset.
moved notification calls back into callback

    • -2
    • +15
    ./sql/oracle/ticket-tracker-packages.sql
added install check to be sure that NotificationSender has a valid email address

added install check to be sure that NotificationSender has a valid email address

    • -0
    • +19
    ./www/admin/install/index-oracle.xql
    • -0
    • +19
    ./www/admin/install/index-postgresql.xql
    • -0
    • +15
    ./www/admin/install/set-sender.tcl
re-enabled general comments

adjusted .info files to reflect OpenACS

  1. … 4 more files in changeset.
removed extra comma

removed requirement on acs-notifications

  1. … 7 more files in changeset.
converted notification calls to acs_mail_nt calls

  1. … 8 more files in changeset.
fixed to use new acs_mail notifications

    • -5
    • +3
    ./sql/oracle/ticket-tracker-packages.sql

1. Added a check that PG was initdb's with the collation order for

characters that we expect.

2. Jon added a "sql/common" directory for the insert statements which

load data for acs-references, so I added a new datamodel type "common"

to the APM.

3. Created a new db API routine that returns true if a given db_type is

compatible with the current RDBMS.

4. Added a workaround for a PL/pgSQL "execute" bug in acs-workflow (other

cases had been fixed previously by others but this one was missed)

5. Diddled a couple of .info files using the APM.

  1. … 10 more files in changeset.
code cleanup

    • -56
    • +47
    ./sql/postgresql/category-create.sql
    • -86
    • +84
    ./sql/postgresql/ticket-create.sql
    • -1
    • +3
    ./sql/postgresql/ticket-tracker-create.sql
    • -1
    • +3
    ./sql/postgresql/ticket-tracker-drop.sql