• last updated 2 hours ago
Constraints: committers
Constraints: files
Constraints: dates
improve spelling

  1. … 8 more files in changeset.
show forum-edit link only, if the current forum is from the current package (see admin/forum-edit)

use consistently bind variables

improve rowcount expressions

  1. … 66 more files in changeset.
Prefer 'person::name' to 'acs_user::get_element ... -name'

  1. … 8 more files in changeset.
Use new fine grained api for the screen name

Remove hotfix and use new user api

Remove user hotfix and replace with new api (which won't fail for non-registered users)

Re-estate query variable, as programs around expect it

Fix typos

  1. … 5 more files in changeset.
Fix regressions in forums when user is not logged in

  1. … 1 more file in changeset.
Avoid two times the same query just because we might filter by forum

    • -20
    • +2
Pass user_name through the message array, as message-view expects it there

This obscure script doesn't do much (basically, displays the content of a message), but nevertheless was passing arrays, defining queries, duplicating code... streamlined to the bones

    • -46
    • +0
    • -51
    • +0
  1. … 2 more files in changeset.
Remove redundant variables, dead code and bring variables closer to where they are actually used... still room for improvement here

    • -10
    • +4
Reduce divergencies between oracle and postgres codebase, reduce the need for joins and stored procedures

    • -41
    • +0
Centralize templating cache "black magic"

Use the new proc into forum api

  1. … 1 more file in changeset.
Replace deprecated 'forum::security::can_moderate_forum_p' by 'permission::permission_p'

  1. … 2 more files in changeset.
Create 'ad_include_contract' for forums portlet

Prefer literal in adp expressions + Whitespace changes

  1. … 6 more files in changeset.
Exploit users cache, simplify SQL

Shorten expression, exploit cache

use more consistent spelling of names

Prefer individual 'set' operations over 'lassign' in these particular cases

  1. … 6 more files in changeset.
Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 474 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 224 more files in changeset.
Rework variable assignment (set -> lassign)

  1. … 11 more files in changeset.
remove parens

  1. … 1 more file in changeset.
delete unreferenced .xql queries

  1. … 1 more file in changeset.
Fix boolean expressions in -adp files, make termination after connection closing commands explicit

  1. … 18 more files in changeset.