nsf

generic

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 14 Oct
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 23 Jul 2011
9:20 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- nsf.c: * added flag "-array" to nsf::var::set such we have now "::nsf::var::set ?-array? object varName ?value?" With "-array", nsf::var::set behaves like "array get" or "array set" (on instance variables) * use "::nsf::var::set -array" in serializer symmetrically to scalar case * extended regression test

Options
    • -3
    • +61
    ./nsf.c
    • -0
    • +1
    ./nsfAPI.decls
    • -6
    • +8
    ./nsfAPI.h
    • -2
    • +2
    ./nsfInt.h
  5. … 3 more files in changeset.
Thursday 21 Jul 2011
1:20 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- generic/nsfStack.c / CallStackPopAll(): When cleaning up the unstacked CSC entries, the borderline case of just 1 CSC entry led to a dangling pointer (and so a crash). This was caused by the unhandled side effect of CscListRemove() (or, rather, NsfClassListUnlink()) which updates the interp's cscList pointer in the 1-list-entry scenario. By using a copy of this pointer in the cleanup loop, this scoped pointer became dangling. To reproduce the issue (prior to this commit), run for example:

Object create o { exit -1 }

I extended the CscListRemove() interface for a conditional out

parameter, to be used for tracking changes to the interp's cscList

pointer.

- generic/nsf.c: Modified the occurrences of CscListRemove() to

reflect its extended interface.

- generic/nsfStack.c: Extended the documentation snippets of the

CscList* operations accordingly.

Options
    • -13
    • +14
    ./nsf.c
    • -15
    • +20
    ./nsfStack.c
Tuesday 19 Jul 2011
11:05 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- generic/nsf.c: Fixed some typos ...

Options
    • -6
    • +7
    ./nsf.c
5:09 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- generic/nsf.c / NextSearchAndInvoke(): Prior to this commit, next calls from within submethod leaves resulted in the interp's unknown flag to be set. While for dispatches without filter indirection this remains hidden and unnoticed, registered filters triggered an unwanted unknown dispatch in such scenarios. Consequently, such leaf next's in submethods behaved differently from the method equivalents. The patch identifies such leaf-next dispatches by watching out for a characteristic callstack structure. - tests/submethods.test: Add a characteristic test for the above patch. - tests/disposition.test: Some cleanup ...

Options
    • -7
    • +29
    ./nsf.c
  2. … 2 more files in changeset.
Sunday 17 Jul 2011
5:47 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- nx.tcl: * added support for "variable" on the class-level * added flag "noconfig" to object parameter options * parameters with "noconfig" are omitted in "info parameter syntax" and "info parameter list" * used switches for all configurable boolean options for "variable" and "attribute" * regularized the interface of "variable" and "attribute" * extended regression test

Options
    • -9
    • +26
    ./nsf.c
    • -7
    • +9
    ./nsfInt.h
  3. … 4 more files in changeset.
1:50 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- nsf.c: improve performance (branch prediction) by using likely/unlikely macros for gcc

Options
    • -36
    • +42
    ./nsf.c
    • -6
    • +11
    ./nsfInt.h
    • -1
    • +12
    ./nsfStack.c
  4. … 1 more file in changeset.
Friday 15 Jul 2011
7:08 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- make sure to place declarations only at the begin of a block - minor code cleanup

Options
    • -12
    • +12
    ./nsf.c
    • -3
    • +4
    ./nsfStack.c
5:23 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- generic/nsf.c: Fixed [current callingmethod] for submethods (i.e., reporting submethods as calling methods, including their methodpath). Added tests covering the fix (see tests/submethods.test). - generic/nsfStack.c (CallStackMethodPath): Re-arranged the traversal slightly, to escape non-ensemble frames (eval CFRAMEs) as parts of the method path. Added test (see tests/submethods.test). - library/nx/nx.tcl: Corrected the impl of Ensemble->defaultmethod() (e.g., used self instead of current) - tests/disposition.test: Fixed test cases turned out to be false positives. Before the fixes, [current methodpath] gave non-empty results for simple object aliases.

Options
    • -6
    • +37
    ./nsf.c
    • -3
    • +10
    ./nsfStack.c
  3. … 3 more files in changeset.
Thursday 14 Jul 2011
11:40 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- generalized "nsf::object::initialized" to nsf::object::property objectName initialized|class|rootmetaclass|rootclass|slotcontainer

Options
    • -5
    • +15
    ./nsf.c
    • -1
    • +2
    ./nsfAPI.decls
    • -9
    • +25
    ./nsfAPI.h
  4. … 2 more files in changeset.
9:18 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- regularized more nsf::* names: renamed "nsf::createobjectsystem" => "nsf::objectsystem::create" renamed "nsf::unknown" => "nsf::object::unknown" renamed "nsf::dispatch" => "nsf::object::dispatch"

Options
    • -233
    • +230
    ./nsf.c
    • -8
    • +8
    ./nsf.tcl
    • -11
    • +14
    ./nsfAPI.decls
    • -59
    • +59
    ./nsfAPI.h
    • -1
    • +1
    ./nsfInt.h
    • -7
    • +7
    ./predefined.h
  7. … 12 more files in changeset.
Wednesday 13 Jul 2011
1:40 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- make sure to always initialize variables

Options
    • -7
    • +6
    ./nsf.c
Monday 11 Jul 2011
4:28 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- tests/parameters.test: Tracked down the relevant Tcl issue (fossil check-in 769801ace1) resulting in the bignum double-rounding problem, observed earlier. The work-around is setting the tcl precision level to 17. I made it applying conditionally, depending on the Tcl patch level as the work-around is not needed anymore fore 8.5.10+. - generic/nsf.c: Correct usage of TclDumpMemoryInfo() for changes in 8.5.10, introduced by fossil check-in 4a9ba46064. Memdebug builts (--enable-symbols=mem) therefore require a recent Tcl version (8.5.10+).

Options
    • -2
    • +2
    ./nsf.c
  2. … 1 more file in changeset.
11:52 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- reduce verbosity - redoce scope of variables

Options
    • -2
    • +1
    ./nsf.c
  2. … 1 more file in changeset.
10:34 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- adding spaces after comma in argument lists

Options
    • -43
    • +44
    ./nsf.c
    • -5
    • +5
    ./nsfCompile.c
    • -5
    • +5
    ./nsfShadow.c
    • -8
    • +8
    ./nsfStack.c
    • -9
    • +9
    ./nsfTrace.c
    • -2
    • +2
    ./nsfUtil.c
10:19 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- fix typos in string "unknown" (unknwon, unkown)

Options
    • -9
    • +9
    ./nsf.c
  2. … 3 more files in changeset.
10:03 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- provide backward compatibility for unknwon method (when method contains spaces). - some minor cleanup - extended regression test

Options
    • -30
    • +27
    ./nsf.c
  2. … 2 more files in changeset.
Friday 08 Jul 2011
9:24 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- TODO: Added an entry concerning callstack introspection (as discussed today) - generic/nsf.c: Some minor renaming in NsfOConfigureMethod(); made sure that intermediate frames resulting from forward-parameter dispatches are equally marked INACTIVE. - tests/disposition.test: Added tests covering uplevel/upvar support under parameter/disposition dispatches (i.e., uplevel and upvar calls from within parameter-dispatched methods); the tests also cover XOTcl's residualargs dispatches.

Options
    • -10
    • +15
    ./nsf.c
  2. … 3 more files in changeset.
3:04 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- generic/nsf.c / CallConfigureMethod() + CmdMethodDispatch(): Rephrased the accompanying docstrings slightly, to align the documentation to the underlying implementation details.

Options
    • -8
    • +9
    ./nsf.c
12:25 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- generic/nsf.c / NsfOConfigureMethod(): Configure adds frames to its callstack context, however, so far the callstack modifications have not honoured the fact that configure() can be called from uplevel'ed call sites. The callstack context resulting from a prior uplevel was erased by the call frame introductions. As a consequence, parameter-dispatched methods found themselves in a wrong variable frame context. The suggested patch adds uplevel awareness in the most generic way I could think of. The entire test suite runs against the patched NsfOConfigureMethod(). However, I might be missing unwanted consequences for untested cases ... we need to think of further test scenarios ...

Options
    • -33
    • +51
    ./nsf.c
    • -2
    • +1
    ./nsfStack.c
Wednesday 06 Jul 2011
5:54 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

Squashed commit of the following:

commit 901efa4cb4e1bbd55a8c47ebb79f4c7b4b397668

Author: ssoberni <stefan.sobernig@wu-wien.ac.at>

Date: Wed Jul 6 17:51:38 2011 +0200

- generic/nsf.c: Provide the [current class] context to submethods

- tests/disposition.test: Added some tests on the interaction of

INACTIVE frames (mixin, filter) and submethods

- tests/submethods.test: Testing [current class] context for submethods

Options
    • -17
    • +14
    ./nsf.c
    • -0
    • +1
    ./nsfStack.c
  3. … 2 more files in changeset.
Tuesday 05 Jul 2011
7:19 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- generic/nsfStack.c: Revised my former patch for traversing callstacks under ensemle dispatches. We fixed the traversal-ending gateway expression; and added transparency for INACTIVE frames when assembling the method path. Added further tests, remain to be completed ...

Options
    • -8
    • +15
    ./nsf.c
    • -21
    • +45
    ./nsfStack.c
  3. … 1 more file in changeset.
9:42 am

Gustaf Neumann <neumann@wu-wien.ac.at>

Merge branch '2.0.0-develop' of ssh://alice.wu-wien.ac.at/usr/local/src/git-repo/xotcl into 2.0.0-develop

Options
    • -47
    • +64
    ./nsf.c
    • -6
    • +17
    ./nsfStack.c
9:41 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- preliminary fix for volatile called through redsidual args - new regression test file volatile.test

Options
    • -5
    • +33
    ./nsf.c
    • -1
    • +2
    ./nsfStack.c
  3. … 3 more files in changeset.
9:09 am

ssoberni <stefan.sobernig@wu-wien.ac.at>

- Reduced verbosity in nsf.c, reactivated a test case

Options
    • -1
    • +1
    ./nsf.c
  2. … 1 more file in changeset.
Monday 04 Jul 2011
9:04 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- nsfStack.c / CallStackMethodPath(): Providing a fix for reporting method paths correctly when dispatching to ensembles from alias parameters. Prior to that fix, the intermediate (and inactive) CMETHOD frame wrapping configure() calls caused [current methodpath]s to report empty string elements. Added some test cases. - nsf.c / ObjectDispatch(), DispatchUnknownMethod(): When testing objects as alias parameter targets, I found cases when the default (C-level) unknown handler was invoked upon. The result was an unknown message which reported the delegator object as "unknown" method! This was due to injecting the delegator object into the argument vector at position 0, subsequently used by the C-level unknown handler. First, I tried to make the C-level unknown handler aware of the ensemble call context (by funneling through the CSC and frame flags) but this turned out to be complicated to achieve this simple task. As an alternative, I suggest the following patch: The first argument in unknown calls is treated as a list, and dependening on the call context (ensemble vs. non-ensemble) contains all the necessary call data. For ensemble methods, it is the delegator object, the entire method path (as returned by [current methodpath]), and the actual unknown selector. The default C-level handler, treating the call info as list, resorts to reporting the last element of the list which is always the unknown selector. Custom (ensemble-level, application-level) unknown handler can wrap and further process the information as necessary. To demonstrate the usefulness, I rewrote EnsembleObject->unknown() accordingly. I checked for Tcl_Obj leaks. - Added some tests on objects as targets of alias object parameter. To be continued.

Options
    • -48
    • +65
    ./nsf.c
    • -1
    • +1
    ./nsfDecls.h
    • -6
    • +17
    ./nsfStack.c
  4. … 4 more files in changeset.
Thursday 30 Jun 2011
12:43 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- nsf.c: * report only fully initialized slot objects via "info slots" to avoid chicken-egg problem during method "objectparameter" * added flag -array to ::nsf::var::exists to check, whether the variable is an array (to avoid "o eval {array exists ...}" in the serializer. * provided flags to VarExists instead of multiple args * don't add new pointer entries in Nsf_PointerTypeLookup()

Options
    • -12
    • +27
    ./nsf.c
    • -0
    • +1
    ./nsfAPI.decls
    • -5
    • +7
    ./nsfAPI.h
    • -0
    • +4
    ./nsfInt.h
    • -2
    • +1
    ./nsfPointer.c
  6. … 5 more files in changeset.
Wednesday 29 Jun 2011
5:25 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- correct result type

Options
    • -1
    • +1
    ./nsfPointer.c
9:57 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- C-code generator: * additional parameter swith "-withObj" to allow passing of internal representation and the according TclObj * * c-implemented methods: report types in "info parameter" for more builtin types. * use "-withObj" in mongodb interface * adapted regression test

Options
    • -3
    • +17
    ./gentclAPI.tcl
    • -1
    • +1
    ./nsf.h
    • -144
    • +144
    ./nsfAPI.h
    • -5
    • +10
    ./nsfPointer.c
  5. … 6 more files in changeset.
Tuesday 28 Jun 2011
1:18 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Merge branch '2.0.0-develop' of ssh://alice.wu-wien.ac.at/usr/local/src/git-repo/xotcl into 2.0.0-develop

Options
    • -1
    • +1
    ./nsf.c
1:16 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- nsf.c: * new file nsfPointer.c * generic new value checker ConvertToPointer to handle c-level conversions (which can be registed from nsf extensions) * extern defined interface for the pointer converter: Nsf_PointerTypeLookup(), Nsf_PointerTypeRegister(), Nsf_PointerAdd(), Nsf_PointerDelete(), Nsf_PointerInit(), Nsf_PointerExit(). - library mongodb * changed mongoAPI to pointer converter interface

Options
    • -3
    • +16
    ./gentclAPI.tcl
    • -25
    • +59
    ./nsf.c
    • -1
    • +20
    ./nsf.h
    • -181
    • +181
    ./nsfAPI.h
    • -0
    • +327
    ./nsfPointer.c
    • -10
    • +0
    ./nsfUtil.c
  7. … 7 more files in changeset.