nsf

generic

Clone Tools

Stats

Commits this week: 0
Total Committers: 13
Last Commit: 14 Oct
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 06 Oct
11:46 am

Gustaf Neumann <neumann@wu-wien.ac.at>

re-establish sanity check

Options
    • -0
    • +5
    ./nsf.c
11:40 am

Gustaf Neumann <neumann@wu-wien.ac.at>

minor cleanup of debug and log messages

Options
    • -10
    • +14
    ./nsf.c
    • -3
    • +12
    ./nsfDebug.c
    • -1
    • +3
    ./nsfObj.c
Friday 04 Oct
11:53 am

Gustaf Neumann <neumann@wu-wien.ac.at>

improved warning message, when Tcl command "::history" is not defined

Options
    • -14
    • +22
    ./nsf.c
10:58 am

Gustaf Neumann <neumann@wu-wien.ac.at>

updated year in comment

Options
    • -1
    • +1
    ./nsf.c
10:55 am

Gustaf Neumann <neumann@wu-wien.ac.at>

fixed false positive in memcount statistics

Before this fix, we saw messages like the following accompanied with wrong memcount

statistics, when running library/xotcl/tests/testo.xotcl

******** MEM COUNT ALERT: Trying to free 0x14f91fc10 <Tcl_Obj* *>, but was not allocated

Options
    • -1
    • +1
    ./nsfInt.h
Thursday 03 Oct
7:23 pm

Gustaf Neumann <gustaf.neumann@wu.ac.at>

Merge branch 'memleak-nsfparam-issue1' into 'main'

Memleak nsfparam issue1

See merge request tcltk/nsf!1

Options
    • -23
    • +12
    ./nsf.c
7:23 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

Memleak nsfparam issue1

Options
    • -23
    • +12
    ./nsf.c
6:25 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

added casts to debug output

Options
    • -2
    • +3
    ./nsfObj.c
6:21 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Make handling of colonLocalVarCache more type-safe

Since the usual macro TCL_SIZE_T does not work together with the

macros for the memcount macros, a new typedef "Nsf_Tcl_Size_t" was

introduced. Using a typedef is better and eases maintenance. The new

typedef has a "Nsf_" prefix, since it is defined in nsf.h.

Options
    • -8
    • +8
    ./nsf.c
    • -6
    • +12
    ./nsf.h
11:12 am

Gustaf Neumann <neumann@wu-wien.ac.at>

memcount: fix type spec leading to a wrong false positive on memcount tests

Options
    • -1
    • +1
    ./nsf.c
Tuesday 01 Oct
12:38 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

* nsf.c (ParamFreeInternalRep): Remove some left-over.

Options
    • -4
    • +0
    ./nsf.c
12:24 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

* nsf.c (NsfParamWrapper): refcount mini-reform removing canFree flag

Options
    • -20
    • +13
    ./nsf.c
Friday 27 Sep
1:25 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Improved Tcl 9.0.0 compatibility

One needs 'Tcl_InitStubs(interp, "8.5-",...)' instead of

'Tcl_InitStubs(interp, "8.5",...)', since the semantics are seemingly

the same as in "package require ...". Not sure, why we have not seen

this with earlier pre-releases of Tcl9.

Without this change, we see in the NaviServer regression test the following error message:

[27/Sep/2024:10:56:30][18309.7f35ed856540][-main:test-] Error: version conflict for package "tcl": have 9.0.0, need 8.5

: version conflict for package "tcl": have 9.0.0, need 8.5

: while executing

: "load {} Nsf"

: invoked from within

: "ns_ictl update"

: (procedure "ns_cleanup" line 8)

: invoked from within

Options
    • -2
    • +2
    ./nsf.c
Wednesday 26 Jun
1:38 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

fix for transitional bug due to NS_TCL_HAVE_TIP629

Deactivating NS_TCL_HAVE_TIP629, since this needs more work to deal

with the two different types of commands (before and after the TIP)

* When we activate NS_TCL_HAVE_TIP629 (TIP supporting > 2^31

* elements in object vectors), Tcl defines different objProcs

* (Tcl_ObjCmdProc and Tcl_ObjCmdProc2) where the usage of these

* depends on a cmdWrapperProc. Unfortunately, the resolving of

* these are performed via CmdWrapperInfo, which is not exported. We

* have to think how to resolve these to make this working as with

* prior Tcl versions.

Options
    • -1
    • +11
    ./nsf.c
    • -1
    • +1
    ./nsf.h
Wednesday 19 Jun
6:50 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

removed debugging output for NS_TCL_HAVE_TIP629

Options
    • -1
    • +0
    ./nsf.h
1:21 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

nsf.h: Remove leftover in header file

Options
    • -1
    • +0
    ./nsf.h
Friday 03 May
3:55 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

improved cleanness of compile with tcl9

Options
    • -1
    • +1
    ./nsf.c
    • -0
    • +6
    ./nsf.h
3:55 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

improved cleanness of compile with tcl9

Options
    • -1
    • +1
    ./nsf.c
    • -0
    • +6
    ./nsf.h
Saturday 20 Jan
8:50 am

Gustaf Neumann <neumann@wu-wien.ac.at>

improved comment

Options
    • -2
    • +4
    ./nsf.c
Tuesday 16 Jan
4:59 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

improved spelling

Options
    • -1
    • +1
    ./nsf.c
  2. … 2 more files in changeset.
3:04 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Bug fix: potential crash and swallowed error

The change fixes 2 bugs:

- When a non-existing method was called in a situation where

* a filter with guards is registered, and

* all guards are failing, and

* the method to be called after the filter does not exist

nsf was crashing

- There was no code to produce the proper error message in such situations

Options
    • -13
    • +48
    ./nsf.c
  2. … 1 more file in changeset.
Tuesday 05 Dec 2023
1:52 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

improved spelling

Options
    • -3
    • +3
    ./nsf.c
  2. … 18 more files in changeset.
Thursday 30 Nov 2023
7:01 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

nsf:parseargs: honor "required" settings

The previous version was accepting e.g.

nsf::parseargs -asdict {

{-state:wordchar,required}

{-revision_id:integer,required}

{-return_url:localurl "."}

} {}

i.e. passing empty argument list where the first two arguments are required.

Now, the error is flagged properly

Options
    • -1
    • +4
    ./nsf.c
Friday 17 Nov 2023
1:02 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

provide clean compilation for current Tcl9

Options
    • -3
    • +3
    ./nsf.c
    • -3
    • +5
    ./nsfProfile.c
Tuesday 14 Nov 2023
8:36 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

maintenance: reflect type change of Tcl TIP 666 (use Tcl_Size for object count in TIP 627)

Options
    • -1
    • +1
    ./nsf.h
Saturday 10 Jun 2023
7:35 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Provided a Tcl_DupInternalRepProc() function for Tcl_ObjType "nsfParam"

Recent versions of Tcl9 call Tcl_DupInternalRepProc() for Tcl_ObjType

"nsfParam", which was a placeholder function before, leading to a

Tcl_Abort(). The provided implementation provides now a basic logic

for "duplicating" internal representations of parameter lists based on

refcounts (somewhat similar to ProcBodyDup), but it has to be tested

further, with a proper test case.

The call of the Tcl_DupInternalRepProc function happens so far during

the startup of NaviServer compiled with Tcl9. It might be necessary to

overthink the competing logics of the "canDelete" member and the

reference count. For now, the intention is to get the NaviServer +

Tcl9 regression test stop from aborting.

Options
    • -9
    • +54
    ./nsf.c
Wednesday 19 Apr 2023
9:15 am

Gustaf Neumann <neumann@wu-wien.ac.at>

cleanup after TIP 660

Options
    • -1
    • +1
    ./nsf.c
    • -1
    • +1
    ./nsf.h
    • -7
    • +2
    ./nsfInt.h
Sunday 16 Apr 2023
7:23 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Fixed warnings detected with branch "disabletcl8api"

The Tcl9 native interface is based on "Tcl_Size" instead of "int", but

the default mode hides these differences via some macro-magic. Typical

such cases are API calls like:

Tcl_ListObjLength(interp, methodObj, &length);

Tcl_ListObjGetElements(interp, methodObj, &oc, &ov)

The macro-magic queries the size of the provided parameters and uses

the old or new interface depending on it (while hiding some more

potential problems, a compiler can detect). The branch

"disabletcl8api" removes the macro-magic and reveals the potential

problem areas, where the code is still depending on the old 32bit

interface.

This commit fixes such cases and the collateral damage.

Options
    • -91
    • +110
    ./nsf.c
    • -2
    • +32
    ./nsfCmdPtr.c
    • -4
    • +7
    ./nsfObj.c
    • -2
    • +2
    ./nsfShadow.c
    • -2
    • +3
    ./nsfStack.c
7:10 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Deactivate support of TIP 629 for the time being

When NS_TCL_HAVE_TIP629 (TIP supporting > 2^31 elements in object

vectors) is activated, Tcl defines different objProcs (Tcl_ObjCmdProc

and Tcl_ObjCmdProc2) for the old and new API, where the usage of these

depends on a cmdWrapperProc. Unfortunately, the resolving of these API

calls is performed through the wrapper via CmdWrapperInfo, which is

not exported. We have to think how to resolve these to make this

working as with prior Tcl versions.

Options
    • -0
    • +2
    ./nsf.h
12:47 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Provide support for TIP 627 (Tcl 8.7a6+ and Tcl 9)

TIP 627 introduces support for > 2^31 elements in object vectors

(e.g., number of words in a single Tcl command). For details, see

https://core.tcl-lang.org/tips/doc/trunk/tip/627.md

To provide also backwards compatibility, this change uses the macros

TCL_COMMAND_OBJPROC, TCL_CREATEOBJCOMMAND, TCL_NRCALLOBJPROC,

TCL_NRCREATECOMMAND, TCL_OBJCMDPROC_T, and TCL_OBJC_T.

Options
    • -5
    • +5
    ./gentclAPI.tcl
    • -297
    • +326
    ./nsf.c
    • -6
    • +6
    ./nsf.decls
    • -52
    • +87
    ./nsf.h
    • -255
    • +255
    ./nsfAPI.h
    • -0
    • +1
    ./nsfAccessInt.h
    • -1
    • +1
    ./nsfCmdDefinitions.c
    • -3
    • +3
    ./nsfCmdPtr.c
    • -2
    • +2
    ./nsfDebug.c
    • -2
    • +3
    ./nsfError.c
    • -12
    • +14
    ./nsfInt.h
    • -2
    • +2
    ./nsfObj.c
    • -3
    • +3
    ./nsfProfile.c
    • -22
    • +22
    ./nsfShadow.c
    • -6
    • +6
    ./nsfStack.c
  16. … 7 more files in changeset.