OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 10
Total Committers: 146
Last Commit: 14 Nov
Commits this week: 10
Total Lines of Code (LoC): 7,560,821
Net change in LoC this week: 22

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 16 Nov 2021
11:50 am

trenner

tighten policy for viewing an exam

Options
    • -0
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
11:13 am

gustafn

fix collateral damage on cleanup (never trust to much on watching files)

Options
    • -7
    • +7
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Monday 15 Nov 2021
6:28 pm

antoniop

Make so that upon package deletion, also the leftover site nodes are deleted (if they do no have children nodes)

Options
    • -1
    • +2
    /openacs-4/packages/acs-admin/www/apm/package-delete-2.tcl
    • -1
    • +22
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
6:23 pm

gustafn

prefer standard OpenACS API for accessing parameters

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/chat-procs.tcl
    • -3
    • +4
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -3
    • +4
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
    • -13
    • +6
    /openacs-4/packages/xowiki/tcl/xowiki-utility-procs.tcl
6:02 pm

gustafn

file TestItemPoolQuestion.form.page was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/xowf/resources/prototypes/TestItemPoolQuestion.form.page
6:02 pm

gustafn

Support for pool questions in the test-item family

Features:

- select random questions from some folder

(Currently siblings, i.e., folders of the same package instance)

- one exam can have multiple pool questions, potentially from other pools

- pools can be links to other folders (which are no siblings)

- The current folder can be used as well as a pool folder. In this

case, other not-used items can be selected as replacement items

given these match the specified filter characteristics

- Question filtering

* filter by item type:

allow one to select from all/some/some item types

(mc, sc, short text, reordering, composite, ...):

use as replacement items only examples of these types

* filter by minutes and/or points:

use as replacement items only items with matching points/minutes

* filter by language:

use as replacement items only items in a certain language

* Filter per item name pattern:

use as replacement items only items matching a name.

When (short-) names are used systematically, one can e.g.

use the date in the name and specify only items from e.g.

one year ago, via "*2020*", or from some chapter "*ch01", ...

Certainly, it is also possible to use different item

folders for this

Potential further steps:

- Currently, exams containing pool questions are treated as

auto-correctable (which implies automated exam-review (Einsicht), when

from the question pools only question from strictly closed questions

are selected (MC, SC, Ordering). Depending on the detailed settings,

also other item types could be possible (via correct-when), but this

requires a deeper analysis of every question, which is so far not

performed.

- Categorized items: technically, the infrastructure is mostly here to

allow also filtering by categories. This would allow one to select

e.g. from technical questions, case examples, knowledge transfer

questions, research-oriented questions... which are orthogonal to

the filtering currently available. Every lecturer can define

own categories depending on their needs, we could provide

university-wide category-trees, etc. Of course, one could also

define separate pools for these purposes, but categorizing is

probably more convenient and more flexible.

- Performance: when question pools become large (500+ questions) and

the cohorts as well (500+), the current version might require more

tuning. The only critical time is the exam-start, where the random

question placeholders have to be resolved for every student. The

approach from this weekend uses basic caching, but maybe this has to

be extended.

- Protecting selected questions: Question pools are more detached from

an exam than single exercises, a lecturer might have in mind. One

should not allow one to delete questions/question pools when these are

in use. Probably deletion should be a move to a trash-can, which is

actually, an issue for all exams, but getting more important with

pool questions.

- Handling of potential duplicates: When items are pulled from a

question pool, a replacement item is selected by making sure that

this item does not occur already in the query selection. Therefore,

one can safely draw two questions from the same question pool

without fearing that a student gets the same question twice.

This duplicate checking might require some fine-tuning:

* the system checks for duplicates in an exam via POOL/NAME.

* if a lecturer uses two pool-questions in an exam pointing to the same pool,

the systems makes sure, the same question is not used twice.

* however, if a teacher adds a question q1 to pool1 and the same question to pool2,

these two instances have different item ids and are regarded as two different

questions. One could make a test for only checking NAME (without POOL),

but then it might be the case that certain questions are not accepted

although these are different, because they have the same name.

- Statistics: so far, i have not provided any special answer

statistics for treating pool questions.

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +9
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -0
    • +8
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -7
    • +15
    /openacs-4/packages/xowf/lib/answer-single-question.wf
    • -27
    • +64
    /openacs-4/packages/xowf/lib/inclass-exam-answer.wf
    • -1
    • +11
    /openacs-4/packages/xowf/lib/inclass-exam.wf
    • -0
    • +11
    /openacs-4/packages/xowf/resources/prototypes/TestItemPoolQuestion.form.page
    • -1
    • +1
    /openacs-4/packages/xowf/resources/prototypes/select_question.form.page
    • -95
    • +698
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -1
    • +10
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
5:41 pm

gustafn

fix title of form-page (was probably a cut&paste leftover)

Options
    • -1
    • +1
    /openacs-4/packages/xowf/resources/prototypes/edit-interaction.wf.page
Saturday 13 Nov 2021
9:37 pm

gustafn

provide tailed labels in table of contents for instances of the edit-interaction workflow

Options
    • -3
    • +11
    /openacs-4/packages/xowf/lib/edit-interaction.wf
9:19 pm

gustafn

minor cleanup and improved documentation

Options
    • -7
    • +14
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
5:22 pm

gustafn

ease usage of "folder" includelet functions in other code by provide defaults

Options
    • -18
    • +24
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
5:19 pm

gustafn

added optional link to "new" pulldown menu

Options
    • -1
    • +2
    /openacs-4/packages/xowiki/resources/prototypes/Parameter.form.page
Friday 12 Nov 2021
9:59 am

gustafn

Don't complain when flushing per-thread cache without content

Options
    • -1
    • +1
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
Tuesday 09 Nov 2021
9:05 pm

gustafn

Added per-request-cache for parameter::get similar to parameter handling in xotcl-core

This change improves scalability especially on sites with high numbers

of concurrent requests by reducing the number of required locks in

general. This change keeps the parameter dict in a per-request cache

to reduce potentially high number of nsv locks, when parameters of a

package are queried a often per request. Without this change we see on

some sites > 100 locks on the ad_param-nsv per request. Alone the

request-procesor queries a larger set of parameters from the acs-core

package, which requires now a single lock operation.

Using the per-request cache has the advantave of avoiding locks and

keeping the internal representations of tcl-objs (whereas ns_cache or

nsvs use plain strings).

Options
    • -4
    • +24
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
8:33 pm

gustafn

extend/debug simplified where/unless query language

Options
    • -17
    • +36
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
8:27 pm

gustafn

modernize idiom

Options
    • -5
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
Saturday 06 Nov 2021
3:33 pm

gustafn

use fully qualified cmd name in directdispatch

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
Friday 05 Nov 2021
9:09 am

gustafn

Added support for tailored messages when autosave is rejected

Optionally, the AJAX call from autosave can be answered with

a JSON structure containing a "feedback". If this is provided, this

is presented to the user. The mechanism can be extended in the

future to include some reason code, etc. for further automatic

processing in JavaScript.

With this change, the inclass-exam-answer workflow will use this

to comminicate the reasone for rejected autosave operations in

situations, where the examtime is up.

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +2
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -2
    • +3
    /openacs-4/packages/xowf/lib/inclass-exam-answer.wf
    • -1
    • +6
    /openacs-4/packages/xowiki/www/resources/autosave-text.js
Thursday 04 Nov 2021
6:14 pm

gustafn

keep track of position of a question in the form for correct scrambling also for filtering by form object

background: randomization depends on the per-user random values and by the position

of a test-item in an exam. If one is filtering just for the test-item,

the position of this item in the exam was lost. Now, we keep track

in the filtering cases

Options
    • -3
    • +15
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
6:10 pm

gustafn

minor update of call pattern and debug line

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
5:11 pm

gustafn

mitigate attacks, where the referer header field is changed to a malicious value

The problem does not exist, when CSP is defined properly.

Many thanks to Frank Bergmann for sharing the pen-test protocol

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
    • -5
    • +5
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
    • -1
    • +10
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Wednesday 03 Nov 2021
8:11 pm

gustafn

make sure, the end_clock is always an integer (as required by "clock format")

Options
    • -8
    • +10
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
7:58 pm

gustafn

improve input checking

Options
    • -7
    • +16
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Tuesday 02 Nov 2021
2:46 pm

gustafn

prefer xowf message catalog

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
11:29 am

gustafn

Performance improvement: make "apm_version_names_compare" faster by a factor of ~100

The function "apm_version_names_compare" is called relatively often

and issues an SQL query. The function is stable (returns always the

same results for the same input) and called with only a few different

input values. By using acs::per_thread_cache the performance improves

from 265 microseconds to 2 microseconds; by using the per-tread cache

the operation scales better since it is fully lock-free (once cached).

Options
    • -13
    • +11
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
10:55 am

gustafn

Deactivate compatibility with versions before OpenACS 5.2 (2005) in

busy code, but leave it there commented out for easy reactivating in

legacy applications.

Options
    • -7
    • +16
    /openacs-4/packages/xotcl-core/tcl/cr-procs.tcl
10:47 am

gustafn

use variable to reference kernel id, white space and comment changes

Options
    • -8
    • +17
    /openacs-4/packages/xotcl-core/tcl/06-param-procs.tcl
Monday 01 Nov 2021
10:19 pm

gustafn

provide means for omit the audio alarm control in the countdown timer

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -1
    • +3
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/xowf/lib/inclass-exam-answer.wf
    • -2
    • +3
    /openacs-4/packages/xowf/resources/prototypes/select_question.form.page
    • -2
    • +7
    /openacs-4/packages/xowf/tcl/xowf-includelet-procs.tcl
11:41 am

gustafn

Remove backward compatibility check in busy code for versions before 5.1.3 (2004)

The checks for backwards compatibility have on busy sites the highest

hit rates of all entries in the util-memoize cache. Since we require the latest

OpenACS 5.9.* for upgrade to 5.10, this can be removed (17 years later).

https://openacs.org/bugtracker/openacs/bug?format=table&f%5fstate=8&bug%5fnumber=2200

Options
    • -22
    • +6
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
Sunday 31 Oct 2021
8:55 pm

gustafn

Show form-field statistics in exam-summary for autograded exams:

- Provide statitics for autograded exams and show this (currently for

MC/SC) in the exam summary. The statistics are generated when the

exam-protocol is rendered and persisted statistics in the workflow

instance.

- Added switch "-generic" to answer_form_field_objs to obtain the

question with all alternatives (not constraint to "show_max") and

without shuffling. This is needed in cases, where e.g. statistics

should be provided for all alternatives shown to all students.

- Question_manager->question_info: separate computation from HTML rendering

- Added statistics handler for the WorkflowPage class to collect

details from the form-fields.

- new private function "tdom_render" (might be useful, but is the

committed version not used)

- split out "spec_to_dict" from "fc_to_dict", since it us also useful on its own

to work on single form-constraint specs.

- make methods add_to_fc and replace_in_fc available to the full AssessmentInterface

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -65
    • +220
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -0
    • +26
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
8:07 pm

gustafn

Refactor form-field statistics (part 1)

- Start move of statistics from being collected in form-fields to

collecting these in the workflow objects. The original code was

developed with less randomization (e.g. no x out of y alternatives)

which requires that the formfields have to be reset multiple times

(e.g. for multiple students in the exam protocol). The exam-protocol

handler cleans regularly the form-fields, which caused also the

deletion of statistics. Collecting these in the (exam) workflow is

safe.

- Collect correct and incorrect statistics per alternative. Since

different students might see different alternatives calculating the

successrate can only be performed by the students having seens this

alternative.

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -13
    • +76
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
    • -1
    • +17
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl