• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Replace deprecated 'acs_mail_lite::utils::valid_email_p' with 'util_email_valid_p'

Reuse email validation logic

Deprecate 'acs_mail_lite::utils::valid_email_p', as it is duplicated by 'util_email_valid_p'. It was not deleted because it was a public proc recently turned to private.

Replace regexp for mail validation by the version proposed by mozilla for the email input type validation, and increment the test cases for valid/invalid emails. Thanks to Günter Ernst for the pointers.

Fix ancient typo

update covered procs in test case

- support var args for "aa_log_result" like for "ns_log" and "ad_log"

- make form parsing via xpath more robust

(don't assume, every INPUT has a name, allthough it should)

extend regression test by including participants page during and after exam

Add 'object_p' test case, covering 'acs_object::object_p'

Add 'string_length_compare' test case, covering 'util::string_length_compare'

Add 'name_to_path' test case, covering 'util::name_to_path'

Add 'util_email_valid_p' test case, covering 'util_email_valid_p'

Increase verbosity

Add 'db_boolean' test case, covering 'db_boolean'

Add 'ad_future_years_list' test case, covering 'ad_future_years_list'

Add 'host_admin_and_outgoing_sender' test case, covering 'ad_outgoing_sender' and 'ad_host_administrator'

Add 'forum_enable_disable' test case, covering 'forum::enable' and 'forum::disable'

add a 10sec grace period to allow typing until the last seconds (but not longer)

Add all whitespace characters between double quotes when converting a dict to hstore

Many thanks to Guenter Ernst for the analysis.

Extended regression test

Add minimal test case for 'attachments::get_package_key'

Add minimal test case for 'dt_midnight_p'

- fixed display of total points in exam protocol: base calculations on total points rather than the points achievable based on progress

- fixed typo in message key

    • -10
    • +16
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Improved handling of autosaved revisions

- reject autosave attempts when time for a student is up

(works for synchronized and non-synchronized exams)

- include submissions with autosaved content in exam protocol (even when state is "initial")

    • -11
    • +34
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
Fix typo

show personal bulk-notification link only if at least one user can receive the notification

Improve zip file download solution: instead of a link to be clicked, stay closer to previous implementation and trigger the download automatically by including an invisible iframe pointing to the file in the user message

avoid potential loss of submission data on "publish" operations

    • -5
    • +15
    /openacs-4/packages/xowf/lib/inclass-exam.wf
support multiple autosave fields on a single page

file download-zip-2.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/file-storage/www/download-zip-2.tcl
Implement a simple "progress-bar" interaction when one downloads a zip file:

file is generated while the progress bar is running and the download link is generated and served to the user as part of a util_user_message