OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 7
Total Committers: 146
Last Commit: 01 Nov
Commits this week: 7
Total Lines of Code (LoC): 7,561,878
Net change in LoC this week: -2

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 28 Sep 2022
10:48 am

gustafn

remove constant from deprecated message

Options
    • -2
    • +5
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
10:20 am

gustafn

Give people the chance to use OpenACS with WithDeprecatedCode set to 0

When OpenACS is configured to omit loading of long deprecated code

(WithDeprecatedCode set to 0) files like deprecated-procs.tcl are not

loaded. Therefore, these files should only contain code, which was

deprecated at LEAST ONE RELEASE EARLIER, such that site admins have

one release time to fix calls to deprecated code. This is especially

important for public procs.

Options
    • -102
    • +2
    /openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl
    • -2
    • +107
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Sunday 25 Sep 2022
10:54 pm

antoniop

Follow the litmus test suite and address issues reported in the "props" section:

* allow properties expressed in "high unicode" by using the database, rather than the filesystem to store them. (TODO: provide an own data-model, right now I am using persistent client properties)

* return all requested properties, reporting 404 when these properties do not exist

Options
    • -123
    • +127
    /openacs-4/packages/oacs-dav/tcl/tDAV-procs.tcl
Saturday 24 Sep 2022
9:27 pm

antoniop

Cleanup debug

Options
    • -2
    • +1
    /openacs-4/packages/oacs-dav/tcl/oacs-dav-procs.tcl
9:06 pm

antoniop

Follow the litmus test suite and improve standard compliance for the "copymove" test section:

- return 204 when trying to copy on an existing resource (by trimming traling slash in the destination path before checking)

- return 409 when one tries to copy/move to a non-existant resource

This makes the "copymove" section pass without warnings

Options
    • -5
    • +11
    /openacs-4/packages/oacs-dav/tcl/oacs-dav-procs.tcl
Wednesday 21 Sep 2022
2:22 pm

antoniop

Fix boolean expression, as the permission api will return a generic boolean, not necessarily 1 or 0

Options
    • -2
    • +2
    /openacs-4/packages/oacs-dav/tcl/oacs-dav-procs.tcl
2:17 pm

antoniop

Fix query in oacs_dav::children_have_permission_p

Options
    • -1
    • +1
    /openacs-4/packages/oacs-dav/tcl/oacs-dav-procs-postgresql.xql
2:16 pm

antoniop

Test oacs_dav::children_have_permission_p: this test exposes a bug in the api

Options
    • -1
    • +108
    /openacs-4/packages/oacs-dav/tcl/test/oacs-dav-procs.tcl
Tuesday 20 Sep 2022
2:24 pm

antoniop

Modernize tcl

Options
    • -14
    • +22
    /openacs-4/packages/oacs-dav/tcl/test/oacs-dav-procs.tcl
    • -28
    • +1
    /openacs-4/packages/oacs-dav/tcl/test/oacs-dav-procs.xql
2:16 pm

antoniop

Make service contract implementation private and replace foreign occurrences

Options
    • -10
    • +37
    /openacs-4/packages/file-storage/tcl/file-storage-dav-procs.tcl
    • -21
    • +25
    /openacs-4/packages/oacs-dav/tcl/oacs-dav-procs.tcl
2:07 pm

trenner

produce error message in the error log, if the parameter value_array_list is not well formed

Options
    • -1
    • +5
    /openacs-4/packages/acs-lang/tcl/lang-message-procs.tcl
2:00 pm

antoniop

Whitespace changes

Options
    • -17
    • +17
    /openacs-4/packages/file-storage/tcl/file-storage-dav-procs.tcl
1:28 pm

trenner

show the amount of questions only if the no_position parameter is not provided

-) the no_position parameter is provided for the composite question form

Options
    • -1
    • +6
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
10:54 am

antoniop

Prefer the classical procedural api in the installation callbacks for these two packages:

- currently, acs-service-contract (among others) defines database functions with the same number of arguments, but different argument types. The acs::dc facility won't be able to distinguish which is the correct one to pick in this case

- a cicken/egg problem arises when one installs xowiki-portlet alongside the new-portal package, because before a restart the acs::dc methods won't be created yet

Options
    • -39
    • +11
    /openacs-4/packages/dotlrn-xowiki/tcl/xowiki-applet-procs.tcl
    • -36
    • +20
    /openacs-4/packages/xowiki-portlet/tcl/xowiki-admin-portlet-procs.tcl
    • -37
    • +21
    /openacs-4/packages/xowiki-portlet/tcl/xowiki-portlet-procs.tcl
8:40 am

antoniop

Fix typo in test

Options
    • -1
    • +1
    /openacs-4/packages/acs-authentication/tcl/test/local-procs.tcl
Monday 19 Sep 2022
6:44 pm

antoniop

Complete coverage for the ACS Service Contract 'auth_user_info'

Options
    • -0
    • +47
    /openacs-4/packages/acs-authentication/tcl/test/local-procs.tcl
6:29 pm

antoniop

Complete coverage of ACS Service Contract 'auth_sync_retrieve' implementations

Options
    • -2
    • +35
    /openacs-4/packages/acs-authentication/tcl/test/sync-test-procs.tcl
6:14 pm

antoniop

Test IMS_Enterprise_v_1p1 implementation of the auth_sync_process Service Contract

Options
    • -1
    • +213
    /openacs-4/packages/acs-authentication/tcl/test/sync-test-procs.tcl
3:24 pm

antoniop

Rework parameter check:

the way the if was construed would allow e.g.:

1. a value for EmailRegistrationConfirmationToUserP = 'nottrue' to pass the first if, but fail the second.

2. a value EmailRegistrationConfirmationToUserP = 'false' to be "true" in the first if, but not in the second

In fact, if EmailRegistrationConfirmationToUserP should be a boolean, there is no need to further check the other parameters and variables in the second if. This change is not 100% equivalent to the previous code, but makes it clear that EmailRegistrationConfirmationToUserP should be interpreted as a boolean and fixes these inconsistencies.

Options
    • -26
    • +18
    /openacs-4/packages/acs-authentication/tcl/local-procs.tcl
2:57 pm

antoniop

Make clear that parameters come from the same subsite

Options
    • -7
    • +12
    /openacs-4/packages/acs-authentication/tcl/local-procs.tcl
2:55 pm

antoniop

Test implementations of ACS Service Contract 'auth_registration'

This exposes a bug in auth::local::registration::Register where the acs-subsite parameter NotifyAdminOfNewRegistrationsP is fetched from the ad_conn package_id, rather than the subsite_id

Options
    • -0
    • +296
    /openacs-4/packages/acs-authentication/tcl/test/local-procs.tcl
Friday 16 Sep 2022
5:16 pm

antoniop

Fix signature of service contract implementation, that is defined with 3 and not 4 arguments, complete coverage of the auth_password contract local implementation

Options
    • -7
    • +2
    /openacs-4/packages/acs-authentication/tcl/local-procs.tcl
    • -0
    • +98
    /openacs-4/packages/acs-authentication/tcl/test/local-procs.tcl
4:31 pm

antoniop

Complete coverage of the auth_authentication contract 'local' implementation

Options
    • -0
    • +48
    /openacs-4/packages/acs-authentication/tcl/test/local-procs.tcl
4:31 pm

antoniop

file local-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-authentication/tcl/test/local-procs.tcl
3:56 pm

antoniop

Make service contract implementations private, test them

Options
    • -2
    • +2
    /openacs-4/packages/categories/tcl/category-trees-procs.tcl
    • -1
    • +44
    /openacs-4/packages/categories/tcl/test/categories-procs.tcl
1:53 pm

antoniop

Whitespace cleanup

Options
    • -4
    • +4
    /openacs-4/packages/acs-service-contract/tcl/test/acs-service-contract-procs.tcl
Thursday 15 Sep 2022
1:10 pm

antoniop

Whitespace changes

Options
    • -22
    • +22
    /openacs-4/packages/assessment/tcl/test/twt-procs.tcl
1:09 pm

antoniop

Kill hamfisted test that might end up deleting unrelated test users

Options
    • -17
    • +0
    /openacs-4/packages/assessment/tcl/test/twt-procs.tcl
Wednesday 14 Sep 2022
4:16 pm

antoniop

Distinguish between procs defined via plain Tcl and NSF, when querying for the command arguments

Options
    • -2
    • +11
    /openacs-4/packages/acs-service-contract/www/binding-display.tcl
3:11 pm

antoniop

Whitespace cleanup

Options
    • -16
    • +14
    /openacs-4/packages/dotlrn-news-aggregator/tcl/dotlrn-news-aggregator-procs.tcl
    • -4
    • +4
    /openacs-4/packages/dotlrn-news-aggregator/tcl/apm-callback-procs.tcl