OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 8
Total Committers: 146
Last Commit: 14:20
Commits this week: 8
Total Lines of Code (LoC): 7,560,931
Net change in LoC this week: 110

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 32 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 31 Jan 2022
2:12 pm

gustafn

Updated inferface for Page->create_form_page_instance

Since "create_form_page_instance" creates always a form

page, we can also pass the state at creation to it

(like other essential parameters). The default value

is "initial" (the default state in workflows).

Bumped version number to 5.10.1d15

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -5
    • +3
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
2:11 pm

gustafn

updated list of tested functions

Options
    • -6
    • +6
    /openacs-4/packages/xowiki/tcl/test/xowiki-admin-tests-procs.tcl
2:05 pm

antoniop

Fix comment

Options
    • -2
    • +2
    /openacs-4/packages/xowf/tcl/test/test-item-procs.tcl
1:55 pm

antoniop

Simplify test logics, bring comment closer to relevant code

Options
    • -11
    • +10
    /openacs-4/packages/xowf/tcl/test/test-item-procs.tcl
1:37 pm

gustafn

make calculation of [ns_set array [ns_getform]] more robust

in case, invalid UTF-8 is passed in, [ns_getform] might be empty.

probably this could also be addressed in NaviServer

Options
    • -5
    • +8
    /openacs-4/packages/xowf/www/index.vuh
1:35 pm

gustafn

improve styling of horizonal form fields (many thanks to Monika Andergassen)

Options
    • -1
    • +1
    /openacs-4/packages/xowf/www/resources/test-item.css
12:53 pm

antoniop

Improve robustness of xowf.create_test_items automated test: make sure that the exercise appearing is actually supposed to render 2 images

Fixes xowf.create_test_items automated test

Options
    • -6
    • +11
    /openacs-4/packages/xowf/tcl/test/test-item-procs.tcl
12:13 pm

antoniop

Compute amplitude and wavelength explicitly in pixels and make it stable with respect to the captcha size, introduce a random offset for the wave instead

Fixes acs-templating.tesseract_cannot_crack_catpcha automated test

Options
    • -3
    • +8
    /openacs-4/packages/acs-templating/tcl/captcha-procs.tcl
11:36 am

hectorr

Fix typo

Options
    • -1
    • +1
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
10:46 am

hectorr

Fix tag

Options
    • -1
    • +1
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
Sunday 30 Jan 2022
3:38 pm

gustafn

Minor modernization

- use atomic stack operations to reduce locks and avoid race conditions

- improve spelling

- break overlong lines

- better align comments with actual code

Options
    • -3
    • +3
    /openacs-4/packages/acs-templating/tcl/date-procs.tcl
    • -36
    • +61
    /openacs-4/packages/acs-templating/tcl/parse-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/test/captcha-procs.tcl
Saturday 29 Jan 2022
7:27 pm

gustafn

refactor code

Options
    • -20
    • +44
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -35
    • +8
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
7:04 pm

gustafn

Make creation of ::xo::cc more robust

In case the argument processing of

ConnectionContext create ::xo::cc -p1 ... -p2 ....

::xo::cc destroy_on_cleanup

runs into an exception leading to an ad_script_abort, the half-in

initialized object without cleanup definition will survive. At later

times, this object might be reused, containing potentially

cached results from earlier runs, which can cause troubles in error

cases.

This change takes care that errors during argument processing will

not leave half-initialized objects behind.

Options
    • -10
    • +32
    /openacs-4/packages/xotcl-core/tcl/context-procs.tcl
Friday 28 Jan 2022
11:46 pm

gustafn

improve wording in comments

Options
    • -6
    • +6
    /openacs-4/packages/xotcl-core/tcl/06-package-procs.tcl
11:44 pm

gustafn

use "ns_strcoll" for ordered composite when available

Options
    • -0
    • +8
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
    • -12
    • +21
    /openacs-4/packages/xotcl-core/tcl/20-Ordered-Composite-procs.tcl
11:33 pm

gustafn

improve wording

Options
    • -5
    • +6
    /openacs-4/packages/xotcl-core/tcl/policy-procs.tcl
9:05 pm

gustafn

safetybelt for acunetix testing: refetch parameter page, when it is not initialized

hopefully a temporary measure

Options
    • -1
    • +9
    /openacs-4/packages/xowiki/tcl/xowiki-procs.tcl
6:19 pm

antoniop

Do not consider unchecked radio buttons as form values, or when an unselected radio exists, the last value will might be picked

Fixes xowiki.create_form_with_form_instance, breaks xowf.create_test_items

Options
    • -1
    • +8
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
5:12 pm

antoniop

Test reproducing an upstream use case: a compound field made of both regular, and compound field, with the compound field also repeated

This test exposes a bug in the acs::test::xpath::get_form_values proc

Options
    • -0
    • +123
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
1:51 pm

gustafn

update message catalog

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -10
    • +9
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -8
    • +7
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
10:59 am

antoniop

Provide a message key for help text, localize in German

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/acs-templating.info
    • -0
    • +2
    /openacs-4/packages/acs-templating/catalog/acs-templating.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/acs-templating/catalog/acs-templating.en_US.ISO-8859-1.xml
10:28 am

antoniop

Drop the pointsize parameter, use size instead, yielding more predictable results across Imagemagik versions and more controllable in general, make the wavelength randomized in the distortion

Options
    • -10
    • +12
    /openacs-4/packages/acs-templating/tcl/captcha-procs.tcl
    • -3
    • +13
    /openacs-4/packages/acs-templating/tcl/test/captcha-procs.tcl
8:50 am

antoniop

Port downstream change: adding label for question selection box

Many thanks to Felix Mödritscher

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +1
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
8:41 am

antoniop

Normalize ordering in the catalog files to facilitate downstream merges

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -222
    • +190
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -251
    • +215
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
Thursday 27 Jan 2022
11:27 am

gustafn

include timing information in DEBUG lines only, when nsf was configured properly with it

Options
    • -0
    • +2
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
    • -3
    • +16
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
10:29 am

gustafn

avoid unneccesary warnings (and unneccessary work)

In case the exam-protocol is shown filtered (e.g. only selected questions)

there is distinction between the available answer attributes and the

answer attributes, which is shown. Earlier versions tried to lookup

all available answer attributes, now we restrict the lookup to only

the shown answer attributes, and therefore avaiding running into

warnings of the form "No form field with name ... found"

Options
    • -2
    • +18
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
10:23 am

antoniop

Deprecate template::util::tcl_to_sql_list, completely replaced by ns_dbquotelist, a native NaviServer command

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/test/content-search-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/permissions/perm-modify.xql
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/application-data-link-procs.xql
    • -1
    • +23
    /openacs-4/packages/acs-templating/tcl/deprecated-procs.tcl
    • -24
    • +1
    /openacs-4/packages/acs-templating/tcl/util-procs.tcl
    • -32
    • +1
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
    • -3
    • +3
    /openacs-4/packages/assessment/tcl/as-list-procs.tcl
    • -1
    • +1
    /openacs-4/packages/assessment/tcl/as-list-procs.xql
    • -1
    • +1
    /openacs-4/packages/assessment/tcl/callback-procs-oracle.xql
    • -1
    • +1
    /openacs-4/packages/assessment/tcl/callback-procs-postgresql.xql
    • -5
    • +5
    /openacs-4/packages/assessment/www/asm-admin/item-stats.tcl
    • -2
    • +2
    /openacs-4/packages/assessment/www/asm-admin/send-mail.tcl
    • -1
    • +1
    /openacs-4/packages/assessment/www/asm-admin/send-mail.xql
    • -1
    • +1
    /openacs-4/packages/file-storage/www/copy.tcl
    • -2
    • +2
    /openacs-4/packages/file-storage/www/delete.xql
  16. … 3 more files in changeset.
9:22 am

antoniop

Improve test portability

Options
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/test/captcha-procs.tcl
9:20 am

antoniop

Baseline test of captcha robustness: challenge the captcha using tesseract, also applying basic normalizations

Options
    • -0
    • +48
    /openacs-4/packages/acs-templating/tcl/test/captcha-procs.tcl
9:18 am

antoniop

Fail when no value is specified

Options
    • -4
    • +3
    /openacs-4/packages/acs-templating/tcl/captcha-procs.tcl