OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 18
Total Committers: 146
Last Commit: 28 Nov
Commits this week: 18
Total Lines of Code (LoC): 7,560,946
Net change in LoC this week: 3

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 15 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 28 Jan 2022
6:19 pm

antoniop

Do not consider unchecked radio buttons as form values, or when an unselected radio exists, the last value will might be picked

Fixes xowiki.create_form_with_form_instance, breaks xowf.create_test_items

Options
    • -1
    • +8
    /openacs-4/packages/acs-automated-testing/tcl/aa-test-procs.tcl
5:12 pm

antoniop

Test reproducing an upstream use case: a compound field made of both regular, and compound field, with the compound field also repeated

This test exposes a bug in the acs::test::xpath::get_form_values proc

Options
    • -0
    • +123
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
1:51 pm

gustafn

update message catalog

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -10
    • +9
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -8
    • +7
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
10:59 am

antoniop

Provide a message key for help text, localize in German

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/acs-templating.info
    • -0
    • +2
    /openacs-4/packages/acs-templating/catalog/acs-templating.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/acs-templating/catalog/acs-templating.en_US.ISO-8859-1.xml
10:28 am

antoniop

Drop the pointsize parameter, use size instead, yielding more predictable results across Imagemagik versions and more controllable in general, make the wavelength randomized in the distortion

Options
    • -10
    • +12
    /openacs-4/packages/acs-templating/tcl/captcha-procs.tcl
    • -3
    • +13
    /openacs-4/packages/acs-templating/tcl/test/captcha-procs.tcl
8:50 am

antoniop

Port downstream change: adding label for question selection box

Many thanks to Felix Mödritscher

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +1
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -0
    • +1
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
8:41 am

antoniop

Normalize ordering in the catalog files to facilitate downstream merges

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -222
    • +190
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -251
    • +215
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
Thursday 27 Jan 2022
11:27 am

gustafn

include timing information in DEBUG lines only, when nsf was configured properly with it

Options
    • -0
    • +2
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
    • -3
    • +16
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
10:29 am

gustafn

avoid unneccesary warnings (and unneccessary work)

In case the exam-protocol is shown filtered (e.g. only selected questions)

there is distinction between the available answer attributes and the

answer attributes, which is shown. Earlier versions tried to lookup

all available answer attributes, now we restrict the lookup to only

the shown answer attributes, and therefore avaiding running into

warnings of the form "No form field with name ... found"

Options
    • -2
    • +18
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
10:23 am

antoniop

Deprecate template::util::tcl_to_sql_list, completely replaced by ns_dbquotelist, a native NaviServer command

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/test/content-search-procs.tcl
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/permissions/perm-modify.xql
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/application-data-link-procs.xql
    • -1
    • +23
    /openacs-4/packages/acs-templating/tcl/deprecated-procs.tcl
    • -24
    • +1
    /openacs-4/packages/acs-templating/tcl/util-procs.tcl
    • -32
    • +1
    /openacs-4/packages/acs-templating/tcl/test/parse-test-procs.tcl
    • -3
    • +3
    /openacs-4/packages/assessment/tcl/as-list-procs.tcl
    • -1
    • +1
    /openacs-4/packages/assessment/tcl/as-list-procs.xql
    • -1
    • +1
    /openacs-4/packages/assessment/tcl/callback-procs-oracle.xql
    • -1
    • +1
    /openacs-4/packages/assessment/tcl/callback-procs-postgresql.xql
    • -5
    • +5
    /openacs-4/packages/assessment/www/asm-admin/item-stats.tcl
    • -2
    • +2
    /openacs-4/packages/assessment/www/asm-admin/send-mail.tcl
    • -1
    • +1
    /openacs-4/packages/assessment/www/asm-admin/send-mail.xql
    • -1
    • +1
    /openacs-4/packages/file-storage/www/copy.tcl
    • -2
    • +2
    /openacs-4/packages/file-storage/www/delete.xql
  16. … 3 more files in changeset.
9:22 am

antoniop

Improve test portability

Options
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/test/captcha-procs.tcl
9:20 am

antoniop

Baseline test of captcha robustness: challenge the captcha using tesseract, also applying basic normalizations

Options
    • -0
    • +48
    /openacs-4/packages/acs-templating/tcl/test/captcha-procs.tcl
9:18 am

antoniop

Fail when no value is specified

Options
    • -4
    • +3
    /openacs-4/packages/acs-templating/tcl/captcha-procs.tcl
9:12 am

antoniop

Fix tests according to new behavior

Options
    • -6
    • +15
    /openacs-4/packages/acs-templating/tcl/test/captcha-procs.tcl
8:26 am

antoniop

Improve behavior: invalidate the captcha when the check fails, cleanup expired captcha also when a new one is generated

Options
    • -10
    • +22
    /openacs-4/packages/acs-templating/tcl/captcha-procs.tcl
Wednesday 26 Jan 2022
6:28 pm

antoniop

Test newly introduced api

Options
    • -0
    • +94
    /openacs-4/packages/acs-templating/tcl/test/captcha-procs.tcl
6:28 pm

antoniop

file captcha-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-templating/tcl/test/captcha-procs.tcl
5:06 pm

antoniop

A simple image captcha implementation:

a random text is converted to a distorted image, its checksum, together with the expected text are stored in a lookup table. Upon validation, the text input by the user is matched against the checksum to determine if the captcha is correct.

Plan is to use it downstream on certain publicly available contact forms.

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/acs-templating.info
    • -0
    • +1
    /openacs-4/packages/acs-templating/catalog/acs-templating.en_US.ISO-8859-1.xml
    • -1
    • +2
    /openacs-4/packages/acs-templating/sql/oracle/acs-templating-create.sql
    • -0
    • +9
    /openacs-4/packages/acs-templating/sql/oracle/captcha-create.sql
    • -0
    • +14
    /openacs-4/packages/acs-templating/sql/oracle/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
    • -1
    • +2
    /openacs-4/packages/acs-templating/sql/postgresql/acs-templating-create.sql
    • -0
    • +10
    /openacs-4/packages/acs-templating/sql/postgresql/captcha-create.sql
    • -0
    • +13
    /openacs-4/packages/acs-templating/sql/postgresql/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
    • -0
    • +207
    /openacs-4/packages/acs-templating/tcl/captcha-procs.tcl
5:06 pm

antoniop

file captcha-create.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-templating/sql/oracle/captcha-create.sql
    • -0
    • +0
    /openacs-4/packages/acs-templating/sql/postgresql/captcha-create.sql
5:06 pm

antoniop

file captcha-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-templating/tcl/captcha-procs.tcl
5:06 pm

antoniop

file upgrade-5.10.1d0-5.10.1d1.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-templating/sql/oracle/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
    • -0
    • +0
    /openacs-4/packages/acs-templating/sql/postgresql/upgrade/upgrade-5.10.1d0-5.10.1d1.sql
3:45 pm

antoniop

Make sure widget variable exists for the element

Options
    • -2
    • +3
    /openacs-4/packages/acs-templating/tcl/data-procs.tcl
11:34 am

gustafn

improve spelling

Options
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -9
    • +9
    /openacs-4/packages/xowf/catalog/xowf.de_DE.ISO-8859-1.xml
    • -2
    • +2
    /openacs-4/packages/xowf/catalog/xowf.en_US.ISO-8859-1.xml
    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -7
    • +7
    /openacs-4/packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml
    • -6
    • +6
    /openacs-4/packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml
10:01 am

gustafn

deactivate language tool when spellcheck is turned off

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
9:59 am

gustafn

Added validation on values provided for options

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -0
    • +3
    /openacs-4/packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml
    • -7
    • +46
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
8:52 am

gustafn

this warning is just important for applications using an fc-repository

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
8:26 am

antoniop

Put more info in the warning

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
8:16 am

antoniop

Allow to pass the doc array to the master (e.g. for the title)

Options
    • -0
    • +1
    /openacs-4/packages/proctoring-support/lib/proctored-page.adp
12:12 am

gustafn

use icanuse machinery for "ns_reflow_text -offset"

Options
    • -0
    • +1
    /openacs-4/packages/acs-tcl/tcl/00-icanuse-procs.tcl
    • -26
    • +34
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
12:10 am

gustafn

improve comment

Options
    • -4
    • +7
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl