• last updated 39 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
mark functions called only internally as private

bring test coverage to >50% by adding test cases and marking only locally called functions as private

Add editor hints + whitespace changes

Remove leftover comment

Add 'attachments_basic_api' test case. Covers basic api of the attachments package: 'attachments::attach', 'attachments::unattach', 'attachments::get_all_attachments', 'attachments::get_attachments' and 'attachments::toggle_approved'

file attachments-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/attachments/tcl/test/attachments-procs.tcl
mark unused function "_mr" as deprecated

mark unused functions as deprecated

improve comment

make use of built-in reverse proxy mode of newer versions of NaviServer

overwork get_community_id once more. provide a shortcut is hopless situations, reduce potential warnings and improve comments

make clear that get_community_id_from_url needs connection in case no URL is provided; provide shortcut, when determined package_id is empty

    • -1
    • +1
    /openacs-4/packages/survey/tcl/survey-procs.tcl
    • -2
    • +2
    /openacs-4/packages/survey/www/admin/one.tcl
don't load deprecated code unless explicitly required

deprecate unused and untested code

fix deprecated function

remove call to deprecated proc

removed leftover from debugging

Fix correct-when test of empty input when constraint is "<" or "<=". Many thanks for Florian Mosböck for finding this.

provide more details in log message

    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
mark in log-file begin and end of test cases, support multiple msg arguments in aa_log (similar to ns_log)

reduce verbosity

use tcl "max" idiom

prefer ns_dbquotevalue over db_quote, mark latter as deprecated

mark functions as private

improve listing of test coverage

  1. … 3 more files in changeset.
improve listing of test coverage

reduce verbosity

improve listing of test coverage

Add default to avoid empty values. Fixes 'acs_mail_lite_inbound_procs_check' test case

consider subject field restriction from the database also in the ui