• last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Close channel

Provide exec-free implementation of tarball extraction

Deprecate apm_file_type_keys, which can be inlined by a simple dict idiom

Avoid dubious catches, collect more logics in the proc

Test apm_workspace directory api

Add missing flag -file to the api call

Make so that -all also overrides the database type check, which appears to have been the expected behavior: in fact, this api was used to retrieve the files to extract in the tarball generation

Test that "apm_get_package_files -all" should return all files for a package

This currently fails, as "-all" does not override the dbms check, so e.g. on a Postgres installation, all Oracle xql files would be skipped.

Note that the test uses acs-tcl as target because it is a package that is only supposed to contain "package-relevant" files. This is not a rule and is not the case in other packages such as acs-automated-testing, which creates many files during its operations that do not belong to the source tree.

Test creating and extracting an APM Package tarball

file apm-file-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/acs-tcl/tcl/test/apm-file-procs.tcl
As tcllib was released in 2016, I believe we can cleanup the legacy zip implementation

Provide exec-free implementation of util::unzip using zipfile::decode

Extend the test to cover also cornercase behavior concerning overwriting of files

Test zipping and unzipping utilities

Make test less tautological

Test for psql only when this is expected

Prefer OS-agnostic path separator, add cvs to the exec dependencies

Cleanup copy paste error

Removed untested and unmaintained code

Fallback to the location of the psql executable when a pgbin was not explicitly defined in the config file (which is allowed)

Prefer exec-free variant

Cleanup copy paste

Test external command dependencies

Test external command dependencies

Prefer exec-free alternative

Test external command dependencies

Improve documentation

Test external command dependency for the package

Test external command dependencies

Add library header