• last updated 19 hours ago
Constraints: committers
Constraints: files
Constraints: dates
Add doc to public api

Fix typo in comment

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

  1. … 6 more files in changeset.
Fall back to en_US also when a value for nls_language is there, but empty

Use api to determine whether a field is disabled, as the "disabled" variable will always be set now

Use existing api to tell whether a formfield is disabled or not and to set/unset disabled on a field, handle the case of checkboxes and select fields, where the attribute should not be set whe it is false (e.g. disabled=0 == disabled)

This fixes upstream automated tests on xowiki and xowf

Fixed serious bug killing at least short-text questions in inclass exam

The bug was introduced in [1], by testing for the existence of the

disabled attribute, and when it exists, it was omitting values

reading. The problem is that when form-fields are reset, the

"disabled" attribute is set to 0, leading the exists check to

succeed. In essence, This change sets now the default value of the

form-field to "0", such that it is safe to test it everywhere.

Originally, it was not set by default to save resources (memory and

processing power), but this requires a more careful analysis when

changes happen.

[1] https://fisheye.openacs.org/browse/OpenACS/openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl?r1=1.368.2.125&r2=1.368.2.126

improved error message

make clear, what the name and what the item_id in the message are

use new path xowiki/lib/portlets/ instead of .../www/...

comment method

Port of downstream hotfix: questions defined with an empty scoring might later fail the score calculations

One might consider preventing empty scores altogether via validation

new proc "ad_log_deprecated": unified interface for logging deprecated usages

The existing code used a larger variety of different messages to

denote invocations of deprecated procs and other

artifacts. "ad_log_deprecated" provides a unified interface, and

provides a usage hint what to use instead based on the API-doc

definitions in the log-file.

  1. … 8 more files in changeset.
rename "iconified file" to "thumbnail file"

Improved styling: use boostrap card component for rendering includelets

  1. … 1 more file in changeset.
Extended functionality of the DropZone widget

- added parameters "label", "disposition" and "file_name_prefix"

for better configurability

- added support for updating the current page with feedback of the

dropped files. This is used e.g. by the online exam in the exam

protocol to display incrementally thumbnails of feedback files.

- change property "uploader" to "disposition", since "uploader" is

somewhat ambiguous. "Disposition" defines, what happens after the

file was uploaded, e.g. whether the content has to be transformed,


- bumped version number to 5.10.1d35

  1. … 2 more files in changeset.
fix typo

use bootstrap table renderer inside includelets for bootstrap3 and bootstrap5

moved included stuff from xowiki/www to xowiki/lib

Generalized handling of local_return_url

I am not fully happy with the handlings of "return_url" in exam workflows.

Maybe this can be reworked in a way such that "local_return_url" is not

neccsessary in the future.

Test behavior of the omit formfield spec

Improved support for composite questions and bootstrap 5

This fixes a bug when composite questions were generated with

bootstrap3 and rendered later with bootstrap5.

  1. … 1 more file in changeset.
improve bootstrap5 compatibility for inclass exam

  1. … 1 more file in changeset.
Preliminary cleanup

In this test we will loop through instances of ::xowiki::Page currently in memory to perform some checks. When multiple tests run in the same request, we cannot guarantee that other tests won't create ::xowiki::Page instances that won't comply with the conditions here. We cleanup any existing object in advance to start from a clean slate.

Skip processing for all formfields that are defined as disabled:

the browser should not send us these data in the first place.

Extend test: show that even when a field is defined as disabled, a request crafted to carry these fields will get through and the values will be stored

A fix will come shortly, similar to what was done for compound fields

undo part of last change

unfortunatly, the 0.9.3 issue can't be fixed so simple as hoped. The "-html" flag is necessary for dealing with autoclosed entries.

for orthogonaly, remove "-html" flag from dom parse to avoid a potential top-level <html> element

fix compatibility with tdom 0.9.3

fix warning (including some false positives) in regression test

  1. … 4 more files in changeset.
we need the upgrade script, since the automatic aler just kicks in, when the constraint does not exist. Antonio was right.

Nevertheless, it would be a nice feature, if the ORM would handle this.