• last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Add doc to public api

Fix typo in comment

Small improvements:

- use "string is space" instead of trimming the string and checking if empty, at least 2x faster on development, wherever we don't need the trimmed value

- modernize leftover foreach trick with lassign

  1. … 6 more files in changeset.
Fall back to en_US also when a value for nls_language is there, but empty

Use api to determine whether a field is disabled, as the "disabled" variable will always be set now

Use existing api to tell whether a formfield is disabled or not and to set/unset disabled on a field, handle the case of checkboxes and select fields, where the attribute should not be set whe it is false (e.g. disabled=0 == disabled)

This fixes upstream automated tests on xowiki and xowf

Fixed serious bug killing at least short-text questions in inclass exam

The bug was introduced in [1], by testing for the existence of the

disabled attribute, and when it exists, it was omitting values

reading. The problem is that when form-fields are reset, the

"disabled" attribute is set to 0, leading the exists check to

succeed. In essence, This change sets now the default value of the

form-field to "0", such that it is safe to test it everywhere.

Originally, it was not set by default to save resources (memory and

processing power), but this requires a more careful analysis when

changes happen.

[1] https://fisheye.openacs.org/browse/OpenACS/openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl?r1=1.368.2.125&r2=1.368.2.126

improved error message

make clear, what the name and what the item_id in the message are

use new path xowiki/lib/portlets/ instead of .../www/...

comment method

Port of downstream hotfix: questions defined with an empty scoring might later fail the score calculations

One might consider preventing empty scores altogether via validation

new proc "ad_log_deprecated": unified interface for logging deprecated usages

The existing code used a larger variety of different messages to

denote invocations of deprecated procs and other

artifacts. "ad_log_deprecated" provides a unified interface, and

provides a usage hint what to use instead based on the API-doc

definitions in the log-file.

  1. … 6 more files in changeset.
rename "iconified file" to "thumbnail file"

Improved styling: use boostrap card component for rendering includelets

Extended functionality of the DropZone widget

- added parameters "label", "disposition" and "file_name_prefix"

for better configurability

- added support for updating the current page with feedback of the

dropped files. This is used e.g. by the online exam in the exam

protocol to display incrementally thumbnails of feedback files.

- change property "uploader" to "disposition", since "uploader" is

somewhat ambiguous. "Disposition" defines, what happens after the

file was uploaded, e.g. whether the content has to be transformed,

etc.

- bumped version number to 5.10.1d35

  1. … 1 more file in changeset.
fix typo

use bootstrap table renderer inside includelets for bootstrap3 and bootstrap5

moved included stuff from xowiki/www to xowiki/lib

changed page_contract to include_contract

  1. … 1 more file in changeset.
moved <include...> content into lib directory

www/portlets -> lib/portlets

    • -0
    • +18
    ./lib/portlets/calendar-portlet.tcl
    • -0
    • +53
    ./lib/portlets/weblog-mini-calendar.adp
    • -0
    • +205
    ./lib/portlets/weblog-mini-calendar.tcl
  1. … 14 more files in changeset.
file calendar-portlet.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lib/portlets/calendar-portlet.adp
file weblog-mini-calendar.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lib/portlets/weblog-mini-calendar.tcl
file weblog-mini-calendar.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lib/portlets/weblog-mini-calendar.adp
file portlet-skin.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lib/portlets/portlet-skin.adp
file plain-include.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lib/portlets/plain-include.adp
file include.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lib/portlets/include.tcl
file forums-portlet.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lib/portlets/forums-portlet.tcl
file forums-portlet.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lib/portlets/forums-portlet.adp
file calendar-portlet.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lib/portlets/calendar-portlet.tcl
Remove private variable from the contract