• last updated 7 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
prefer usage of "xo::write_tmp_file" over "xo::write_file" for writing tmp files

Do not urlencode the return URL in every case, but only when this falls back to the current URL from the connection context, normally coming from "ns_conn url" which will return it "raw", as in not encoded for any purpose

URLencode the return URL, or the server might complain for invalid characters (e.g. unencoded umlaut characters)

Remove hard-coded styling with the "style" element to get a more consistent appearance

(many thanks to Monika Andergassen for looking into this).

    • -7
    • +7
    ./www/resources/xowiki-yui-specific.css
improve query variable checking

fix creating/editing of xowiki::Forms

This change essentially reverts the change of July 2, which broke

the feature to specify "editor=none". This is important for the

"form" form-field entry, which requires a FORM tag, that is

usually removed by actual version of the ckeditor.

added value checker, improved comments and logging statements

upgrade default ckeditor from 4.15.1 to 4.16.1 (released in May 2021)

  1. … 2 more files in changeset.
file jquery-3.6.0.js was initially added on branch oacs-5-10.

    • -0
    • +0
    ./www/resources/jquery/jquery-3.6.0.js
  1. … 1 more file in changeset.
file jquery-3.6.0.min.js was initially added on branch oacs-5-10.

    • -0
    • +0
    ./www/resources/jquery/jquery-3.6.0.min.js
  1. … 1 more file in changeset.
Upgrade to jQuery 3.6.0 (released March 2021)

    • -10872
    • +0
    ./www/resources/jquery/jquery-3.5.1.js
    • -2
    • +0
    ./www/resources/jquery/jquery-3.5.1.min.js
    • -0
    • +10881
    ./www/resources/jquery/jquery-3.6.0.js
    • -0
    • +2
    ./www/resources/jquery/jquery-3.6.0.min.js
  1. … 5 more files in changeset.
parameterize xowiki::test::edit_form_page with -next_page_must_contain

This changes supports more flexible checking of expected content on page after editing.

Default is backwards compatible

file photo.form.page was initially added on branch oacs-5-10.

    • -0
    • +0
    ./resources/prototypes/photo.form.page
reduce warnings on loading: Move resources to non-deprecated location

    • -0
    • +11
    ./resources/prototypes/folder.form.page
    • -0
    • +11
    ./resources/prototypes/form.form.page
    • -0
    • +10
    ./resources/prototypes/link.form.page
    • -0
    • +11
    ./resources/prototypes/page.form.page
    • -0
    • +8
    ./resources/prototypes/photo.form.page
    • -14
    • +0
    ./www/prototypes/import-archive.form.page
file folder.form.page was initially added on branch oacs-5-10.

    • -0
    • +0
    ./resources/prototypes/folder.form.page
file page.form.page was initially added on branch oacs-5-10.

    • -0
    • +0
    ./resources/prototypes/page.form.page
file link.form.page was initially added on branch oacs-5-10.

    • -0
    • +0
    ./resources/prototypes/link.form.page
file import-archive.form.page was initially added on branch oacs-5-10.

    • -0
    • +0
    ./resources/prototypes/import-archive.form.page
file form.form.page was initially added on branch oacs-5-10.

    • -0
    • +0
    ./resources/prototypes/form.form.page
In order to make the "editor=" formfield spec option have any effect, one should catch the value from the spec early, before the formfield is reclassed and initialized

This also exposes that the editor=none value is not valid (detected by xowiki and xowf automated tests). For this to be valid one should define it as a richtext subclass.

make child_components a proc (::xowiki::formfield::child_components) and add filter expression

Added new method "child_components": Return for a list of form-field objs all child components

added test case for form field validation

    • -0
    • +128
    ./tcl/test/xowiki-test-procs.tcl
improve spelling

make comments more uniform

provide a less confusing name for new methodm improve comments

Fix typo in comment

Implement reset_to_default method to reset formfields in case of validation error

the current behavior of this method is currently a no-op for every formfield, except files, where we want to make sure the value has been reset. We also handle the case now of compound fields, as they might be compounds of file formfields

Add all whitespace characters between double quotes when converting a dict to hstore

Many thanks to Guenter Ernst for the analysis.

Extended regression test

Fix typo