• last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Replace deprecated proc call

Fix proc doc

Introduce SSE notifications on the page, but bind their availability and usage to a package parameter set to false by default

  1. … 2 more files in changeset.
Provide a Notification API implementation for rendering notifications obtained via the SSE backend

This include should be used e.g. on the website master so that SSE notifications are displayed whenever occurring. We do not do it by default for now.

    • -0
    • +50
    ./lib/notification-sse.adp
Cleanup stale sse connections

Introduce a new delivery method for notifications based on Server Sent events

By subscribing to /notifications/sse/subscribe one will receive notifications as JSON messages. This can be used e.g. to update a UI in real time based on events on the system.

    • -0
    • +245
    ./tcl/notification-sse-procs.tcl
    • -0
    • +10
    ./www/sse/subscribe.tcl
Prefer unset to array unset when we do not need a pattern match

See https://wiki.tcl-lang.org/page/Dict+VS+Array+Speed

merge with missing files

    • -0
    • +0
    ./sql/oracle/notifications-core-create.sql
    • -0
    • +0
    ./tcl/notifications-security-procs.tcl
  1. … 1450 more files in changeset.
merge from oacs-5-10

    • -2
    • +3
    ./sql/oracle/notifications-core-create.sql
    • -0
    • +5
    ./sql/oracle/upgrade/upgrade-5.10.0d4-5.10.0d5.sql
    • -12
    • +26
    ./tcl/notification-callback-procs.tcl
    • -10
    • +0
    ./tcl/notification-callback-procs.xql
    • -13
    • +16
    ./tcl/notification-display-procs.tcl
    • -12
    • +25
    ./tcl/notification-email-procs.tcl
  1. … 8085 more files in changeset.
bumped version number from development version to release version

  1. … 93 more files in changeset.
silence regression test warning

Provide a script name for ad_proc

    • -0
    • +13
    ./tcl/test/notifications-test-procs.tcl
simplified exception handling by factoring out redundant code

make use of "ad_unless_script_abort"

    • -9
    • +13
    ./tcl/notifications-security-procs.tcl
    • -18
    • +15
    ./tcl/test/notifications-test-procs.tcl
handle script abort in proc handler

    • -8
    • +19
    ./tcl/test/notifications-test-procs.tcl
improved spelling

  1. … 14 more files in changeset.
Harden page contract

Whitespace changes

Cleanup obsolete variable

Use adp:icon feature to generate a style-aware icon on every theme

bumped version numbers to 5.10.1b1

  1. … 85 more files in changeset.
improved spelling

  1. … 7 more files in changeset.
put the notification creation in a db_transaction to ensure same subscription is created only once (e.g. double-clicks)

Harden page contract

Harden page contract

improve spelling

  1. … 5 more files in changeset.
prefer usage of parameter::get_from_package_key over plain parameter::get

Fix incorrect HTTP status code on result page

The command "ad_return_error" returns HTTP status code 500 (internal server error).

In this script, this status code was returned in cases, where no notifications

were found for an object. "ad_return_exception_page" is better suited for such

cases.

Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

    • -10
    • +18
    ./tcl/notification-callback-procs.tcl
  1. … 13 more files in changeset.
Whitespace cleanup

    • -11
    • +11
    ./tcl/notification-type-procs.tcl
Use quicker idiom to check for existance

Whitespace cleanup