OpenACS / openacs-4 / packages

notifications

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 44
Last Commit: 13:09
Commits this week: 0
Total Lines of Code (LoC): 10,059
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 18 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 03 Oct 2018
11:17 am

gustafn

whitespace changes

Options
    • -5
    • +7
    ./tcl/notification-request-procs.tcl
11:11 am

gustafn

Address issue #3358: avoid duplicate entries in notification_requests via data model, in case the check in notification::request::new for existing requests with the same type_id, object_id and user_id is somehow bypassed

Options
    • -2
    • +2
    ./notifications.info
    • -8
    • +10
    ./sql/oracle/notifications-core-create.sql
    • -0
    • +4
    ./sql/oracle/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
    • -8
    • +10
    ./sql/postgresql/notifications-core-create.sql
    • -0
    • +4
    ./sql/postgresql/upgrade/upgrade-5.10.0d2-5.10.0d3.sql
Friday 17 Aug 2018
3:02 pm

hectorr

Undeprecate and reimplement: require_admin_request, can_admin_request_p, require_notify_object and can_notify_object_p. Fixes in two templates (request-delete, request-change-frequency). (Many thanks to Felix Mödritscher for the patch!)

Options
    • -2
    • +2
    ./tcl/notification-procs.tcl
    • -16
    • +26
    ./tcl/notifications-security-procs.tcl
    • -2
    • +2
    ./www/request-delete.tcl
Wednesday 25 Jul 2018
10:11 pm

hectorr

Fix parameter name in proc doc

Options
    • -3
    • +2
    ./tcl/notification-email-procs.tcl
Thursday 12 Jul 2018
4:13 pm

antoniop

Port a few downstream modifications to the main codebase

When changing notification frequency, show also name and creation date for the object

Driver is making easier to merge this script

Options
    • -8
    • +22
    ./www/request-change-frequency.tcl
3:29 pm

antoniop

Trim whitespace

Options
    • -4
    • +4
    ./www/request-change-frequency.tcl
Friday 29 Jun 2018
7:27 pm

hectorr

Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @cvs_id -> @cvs-id

- @version -> @cvs-id

- @creation_date -> @creation-date

- @date -> @creation-date

- Different variations of $Id$

- Remove wrong @param entry

- Fix typos

Options
    • -5
    • +5
    ./www/unsubscribe.tcl
  2. … 368 more files in changeset.
Thursday 28 Jun 2018
12:39 pm

hectorr

Prefer 'person::name' to 'acs_user::get_element ... -name'

Options
    • -1
    • +1
    ./www/request-notification.tcl
  2. … 8 more files in changeset.
Wednesday 27 Jun 2018
6:11 pm

hectorr

Prefer again 'person::name', as the proc has been reimplemented using 'person::get_person_info', which uses the new 'person_info_cache' cache.

Options
    • -1
    • +1
    ./www/manage.tcl
  2. … 13 more files in changeset.
Thursday 21 Jun 2018
3:17 pm

hectorr

Deprecate 'notification::email::get_parameter', just a wrapper for 'parameter::get', used almost nowhere.

Options
    • -5
    • +9
    ./tcl/notification-email-procs.tcl
Tuesday 19 Jun 2018
3:45 pm

hectorr

Whitespace changes

Options
    • -1
    • +1
    ./www/manage.tcl
  2. … 11 more files in changeset.
3:35 pm

hectorr

Prefer 'acs_user::get_element ...' to 'person::name ...', in cases when 'person' is a user, as it doesn't rely on util_memoize_cache.

Options
    • -1
    • +1
    ./www/manage.tcl
  2. … 13 more files in changeset.
Monday 18 Jun 2018
5:03 pm

antoniop

Remove unnecessary join, as users are always persons and unnecessary stored procedure in order_by as we compute this in the column already

Options
    • -4
    • +3
    ./www/manage-postgresql.xql
4:39 pm

antoniop

Remove divergency between oracle and postgres, bring all sql inline

Options
    • -17
    • +0
    ./www/request-change-frequency-oracle.xql
    • -17
    • +0
    ./www/request-change-frequency-postgresql.xql
    • -3
    • +13
    ./www/request-change-frequency.tcl
    • -16
    • +0
    ./www/request-change-frequency.xql
Wednesday 13 Jun 2018
9:28 am

gustafn

fix adp expressions

Options
    • -1
    • +1
    ./www/subscribers.adp
  2. … 2 more files in changeset.
Thursday 07 Jun 2018
7:09 pm

hectorr

Replace deprecated procs with 'permission::require_permission'

Options
    • -2
    • +2
    ./www/request-delete.tcl
    • -2
    • +2
    ./www/request-new-2.tcl
    • -6
    • +6
    ./www/request-new.tcl
  4. … 1 more file in changeset.
7:07 pm

hectorr

Fix variable name

Options
    • -2
    • +2
    ./tcl/notifications-security-procs.tcl
6:35 pm

hectorr

Deprecate wrappers for 'permission::permission_p' and permission::require_permission.

Options
    • -5
    • +21
    ./tcl/notifications-security-procs.tcl
5:11 pm

hectorr

Implement the Notifications Security Library procs... 16 years after their creation.

Options
    • -18
    • +31
    ./tcl/notifications-security-procs.tcl
Thursday 31 May 2018
12:54 pm

gustafn

add missing version dependencies for antonio's recent changes concering user info API

Options
    • -3
    • +3
    ./notifications.info
  2. … 5 more files in changeset.
Wednesday 30 May 2018
5:06 pm

antoniop

Use api to avoid join

Options
    • -1
    • +3
    ./www/request-notification.tcl
    • -4
    • +3
    ./www/request-notification.xql
4:55 pm

antoniop

As username variable is not used, don't rely on side effects to check for user existance. Indentation changes.

Options
    • -8
    • +12
    ./www/request-notification.tcl
    • -2
    • +2
    ./www/request-notification.xql
Monday 28 May 2018
3:06 pm

antoniop

Reuse person API instead of querying by hand

Options
    • -2
    • +2
    ./tcl/notification-email-procs.tcl
    • -8
    • +0
    ./tcl/notification-email-procs.xql
Wednesday 09 May 2018
5:33 pm

hectorr

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

Options
    • -2
    • +2
    ./tcl/delivery-method-procs.tcl
    • -4
    • +4
    ./tcl/notification-email-procs.tcl
    • -3
    • +3
    ./tcl/notification-procs.tcl
  4. … 473 more files in changeset.
Monday 07 May 2018
4:55 pm

hectorr

Replace 'linsert' with 'lappend'

Options
    • -2
    • +2
    ./tcl/sweep-procs.tcl
4:46 pm

hectorr

Fix linsert command argument expansion + Whitespace

Options
    • -31
    • +30
    ./tcl/sweep-procs.tcl
Tuesday 01 May 2018
11:06 am

gustafn

improve list operations

Options
    • -2
    • +2
    ./tcl/sweep-procs.tcl
  2. … 5 more files in changeset.
Monday 30 Apr 2018
2:45 pm

hectorr

Rework variable assignment (set -> lassign) + Whitespace changes

Options
    • -50
    • +49
    ./tcl/notification-callback-procs.tcl
  2. … 17 more files in changeset.
11:07 am

gustafn

unify spelling of URL

Options
    • -3
    • +3
    ./tcl/notification-email-procs.tcl
  2. … 3 more files in changeset.
Wednesday 25 Apr 2018
9:23 pm

hectorr

Prefer '{}' to '[list]' when creating empty lists

Options
    • -2
    • +2
    ./tcl/delivery-method-procs.tcl
    • -4
    • +4
    ./tcl/notification-email-procs.tcl
    • -3
    • +3
    ./tcl/notification-procs.tcl
  4. … 69 more files in changeset.