• last updated 15 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Remove unnecessary join, as users are always persons and unnecessary stored procedure in order_by as we compute this in the column already

Remove divergency between oracle and postgres, bring all sql inline

    • -17
    • +0
    ./www/request-change-frequency-oracle.xql
    • -17
    • +0
    ./www/request-change-frequency-postgresql.xql
fix adp expressions

  1. … 2 more files in changeset.
Replace deprecated procs with 'permission::require_permission'

  1. … 1 more file in changeset.
Fix variable name

    • -2
    • +2
    ./tcl/notifications-security-procs.tcl
Deprecate wrappers for 'permission::permission_p' and permission::require_permission.

    • -5
    • +21
    ./tcl/notifications-security-procs.tcl
Implement the Notifications Security Library procs... 16 years after their creation.

    • -18
    • +31
    ./tcl/notifications-security-procs.tcl
add missing version dependencies for antonio's recent changes concering user info API

  1. … 5 more files in changeset.
Use api to avoid join

As username variable is not used, don't rely on side effects to check for user existance. Indentation changes.

Reuse person API instead of querying by hand

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 473 more files in changeset.
Replace 'linsert' with 'lappend'

Fix linsert command argument expansion + Whitespace

improve list operations

  1. … 5 more files in changeset.
Rework variable assignment (set -> lassign) + Whitespace changes

    • -50
    • +49
    ./tcl/notification-callback-procs.tcl
  1. … 17 more files in changeset.
unify spelling of URL

  1. … 3 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 69 more files in changeset.
Rework variable assignment (set -> lassign) + Whitespace changes

    • -90
    • +89
    ./tcl/notification-email-procs.tcl
Rework variable assignment (set -> lassign)

  1. … 11 more files in changeset.
Comment state of notification::type::get_type_id due to per-thread caching

Fix caching bug detected by Hani Gadllah

revert escaped change

*** empty log message ***

Fix typos

*not_cached functions should be private

fix dirty-editor buffer error

VS: ----------------------------------------------------------------------

reduce pressure on util_memoize cache by using per-thread caching on notification::type::get_type_id

fix invalid meta-data

    • -1
    • +1
    ./www/request-unsubscribe-notification.tcl
Reduce divergencies between oracle and postgres codebase

    • -11
    • +0
    ./tcl/notification-procs-oracle.xql
    • -11
    • +0
    ./tcl/notification-procs-postgresql.xql
  1. … 6 more files in changeset.