OpenACS / openacs-4 / packages / file-storage

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 45
Last Commit: 21 Jun
Commits this week: 0
Total Lines of Code (LoC): 4,362
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 May
3:57 pm

antoniop

Document more explicitly that we do not perform filesystem operations when deleting files via the fs:: api, but we rely on the content repository and its trigger+scheduled proc mechanism

Options
    • -3
    • +18
    ./file-storage-procs.tcl
Monday 26 Feb
4:05 pm

antoniop

download-archive reform

File-Storage used to generate downloaded archives in tgz format, to then switch to zip, more user-friendly, in particular outside the Linux world (See https://openacs.org/forums/message-view?message_id=557561). To ease the transition, a couple of parameters and relative API were introduced that would allow to choose the preferred command one should use. During this reform however, default parameter values in the tcl code became inconsistent with those in the info file. Furthermore, the chosen defaults were set as absolute paths to the executable, which is not friendly to non-linux environments, or other scenarios where the "typical" Linux filesystem structure cannot be assumed (e.g. containers, MacOS...).

The only usage of this parameters/api was in fact in the download-archive vuh. In upstream codebase, no package references this file, not even the file-storage itself. Upon review, one could see that the file would also allow to specify a custom download filename via the path, which could be considered questionable. It would also execute the command in a way that once again assumes some form of Linux environment (e.g. invoking bash).

Save for the ability to customize the archive format and the anti-feature of being able to manipulate the archive filename via the path, the script largely relplicates www/download-zip, in a better shape after a few reforms hinted by e.g. penetration tools.

Given the aformentioned considerations, I have decided to make download-archive a simple redirect to download-zip. Specifying the object_id via the path will keep working, while URLs out there expecting the name to change will not fail, but the name will not be modified. The archive format will from now on be assumed to be zip.

Options
    • -1
    • +15
    ./file-storage-install-procs.tcl
    • -2
    • +2
    ./file-storage-procs.tcl
    • -47
    • +1
    ./test/file-storage-procs.tcl
  4. … 2 more files in changeset.
10:57 am

gustafn

Cleanup of external binaries: always use "util::which" to resolve binaries

Options
    • -3
    • +3
    ./test/webtest-procs.tcl
  2. … 5 more files in changeset.
Thursday 20 Apr 2023
4:47 pm

antoniop

Test external command dependency for the package

Options
    • -1
    • +25
    ./test/file-storage-procs.tcl
Friday 17 Mar 2023
4:15 pm

antoniop

Fix english

Options
    • -6
    • +6
    ./file-storage-procs.tcl
4:12 pm

antoniop

Deprecate fs::get_folder_contents

Options
    • -2
    • +10
    ./file-storage-procs.tcl
4:07 pm

antoniop

Avoid using get_folder_contents, doing a lot more stuff, and get the info from the db directly

Options
    • -4
    • +12
    ./file-storage-procs.tcl
4:02 pm

antoniop

Retrieve only the necessary information

Options
    • -5
    • +5
    ./file-storage-procs.tcl
4:00 pm

antoniop

Replace ad_tmpnam

Options
    • -2
    • +2
    ./file-storage-procs.tcl
3:43 pm

antoniop

Complete api coverage for the package

Options
    • -1
    • +21
    ./test/file-storage-procs.tcl
3:36 pm

antoniop

Cover remaining export api

Options
    • -15
    • +129
    ./test/file-storage-procs.tcl
2:36 pm

antoniop

Make fs::get_folder_contents private: this api is only used internally to the file-storage over the codebase and its documentation suggests that it should be used with caution

Options
    • -2
    • +2
    ./file-storage-procs.tcl
2:29 pm

antoniop

Deprecate trivial fs::get_archive_extension and inline its only upstream occurrence

Options
    • -2
    • +6
    ./file-storage-procs.tcl
  2. … 1 more file in changeset.
2:25 pm

antoniop

Prevent usage of fs::get_archive_command outside a file-storage connection context, as in this case the parameter value will be uspecified

Options
    • -1
    • +5
    ./file-storage-procs.tcl
    • -3
    • +17
    ./test/file-storage-procs.tcl
Thursday 16 Mar 2023
3:58 pm

antoniop

Deprecate fs::item_editable_info and fs::item_editable_p, probably unfinished work towards some kind of inline editing feature

Options
    • -3
    • +17
    ./file-storage-procs.tcl
3:49 pm

antoniop

Increase proc coverage

Options
    • -1
    • +33
    ./test/file-storage-procs.tcl
Friday 24 Feb 2023
5:29 pm

antoniop

Declare api as tested

Options
    • -1
    • +2
    ./test/file-storage-procs.tcl
5:27 pm

antoniop

Make the api creating the Service Contract implementations for RSS in the file-storage package private, as they are meant to be invoked only once at install/uninstall time

Options
    • -2
    • +2
    ./file-storage-rss-procs.tcl
5:24 pm

antoniop

Deprecate fs::torrent::get_hashsum, which can be replaced by a oneliner idiom on modern NaviServer

Options
    • -1
    • +6
    ./file-storage-torrent-procs.tcl
5:18 pm

antoniop

Increase proc coverage

Options
    • -1
    • +169
    ./test/file-storage-procs.tcl
4:04 pm

antoniop

Deprecate fs::add_created_version

This api was nowhere used in upstream code, however, allowed to create a new file object revision by text content, different from fs::add_version, which would only allow to create a revision from a file.

As the two apis were otherwise identical, I have ported the behavior of fs::add_created_version info fs::add_version.

The new fs::add_version will also take many defaults for unspecified parameters from the existing content item.

Options
    • -37
    • +110
    ./file-storage-procs.tcl
2:50 pm

antoniop

Make service contract implementation private

Options
    • -4
    • +6
    ./file-storage-procs.tcl
Monday 20 Feb 2023
10:55 am

antoniop

Don't load the DAV callbacks when oacs-dav is not installed

Options
    • -1
    • +6
    ./file-storage-dav-procs.tcl
Wednesday 15 Feb 2023
6:00 pm

antoniop

Commit remaining files

Options
    • -1
    • +57
    ./file-storage-dav-procs.tcl
    • -0
    • +2
    ./file-storage-init.tcl
    • -3
    • +2
    ./file-storage-install-procs.tcl
    • -4
    • +8
    ./file-storage-procs.tcl
Sunday 27 Nov 2022
11:52 am

gustafn

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

Options
    • -5
    • +3
    ./file-storage-procs.tcl
    • -5
    • +3
    ./test/file-storage-procs.tcl
    • -2
    • +1
    ./test/webtest-procs.tcl
  4. … 4 more files in changeset.
Tuesday 20 Sep 2022
2:16 pm

antoniop

Make service contract implementation private and replace foreign occurrences

Options
    • -10
    • +37
    ./file-storage-dav-procs.tcl
  2. … 1 more file in changeset.
2:00 pm

antoniop

Whitespace changes

Options
    • -17
    • +17
    ./file-storage-dav-procs.tcl
Monday 12 Sep 2022
5:38 pm

antoniop

Make service contract implementation private: they are not meant to be invoked directly

Options
    • -14
    • +14
    ./file-storage-dav-procs.tcl
Friday 09 Sep 2022
4:38 pm

antoniop

Make service contract implementations private

Options
    • -3
    • +3
    ./file-storage-search-procs.tcl
4:37 pm

antoniop

Whitespace cleanup

Options
    • -6
    • +6
    ./file-storage-search-procs.tcl