OpenACS / openacs-4 / packages / file-storage

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 45
Last Commit: 21 Nov
Commits this week: 0
Total Lines of Code (LoC): 5,235
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 34 mins ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 17 Mar 2023
3:43 pm

antoniop

Complete api coverage for the package

Options
    • -1
    • +21
    ./test/file-storage-procs.tcl
3:36 pm

antoniop

Cover remaining export api

Options
    • -15
    • +129
    ./test/file-storage-procs.tcl
2:36 pm

antoniop

Make fs::get_folder_contents private: this api is only used internally to the file-storage over the codebase and its documentation suggests that it should be used with caution

Options
    • -2
    • +2
    ./file-storage-procs.tcl
2:29 pm

antoniop

Deprecate trivial fs::get_archive_extension and inline its only upstream occurrence

Options
    • -2
    • +6
    ./file-storage-procs.tcl
  2. … 1 more file in changeset.
2:25 pm

antoniop

Prevent usage of fs::get_archive_command outside a file-storage connection context, as in this case the parameter value will be uspecified

Options
    • -1
    • +5
    ./file-storage-procs.tcl
    • -3
    • +17
    ./test/file-storage-procs.tcl
Thursday 16 Mar 2023
3:58 pm

antoniop

Deprecate fs::item_editable_info and fs::item_editable_p, probably unfinished work towards some kind of inline editing feature

Options
    • -3
    • +17
    ./file-storage-procs.tcl
3:49 pm

antoniop

Increase proc coverage

Options
    • -1
    • +33
    ./test/file-storage-procs.tcl
Friday 24 Feb 2023
5:29 pm

antoniop

Declare api as tested

Options
    • -1
    • +2
    ./test/file-storage-procs.tcl
5:27 pm

antoniop

Make the api creating the Service Contract implementations for RSS in the file-storage package private, as they are meant to be invoked only once at install/uninstall time

Options
    • -2
    • +2
    ./file-storage-rss-procs.tcl
5:24 pm

antoniop

Deprecate fs::torrent::get_hashsum, which can be replaced by a oneliner idiom on modern NaviServer

Options
    • -1
    • +6
    ./file-storage-torrent-procs.tcl
5:18 pm

antoniop

Increase proc coverage

Options
    • -1
    • +169
    ./test/file-storage-procs.tcl
4:04 pm

antoniop

Deprecate fs::add_created_version

This api was nowhere used in upstream code, however, allowed to create a new file object revision by text content, different from fs::add_version, which would only allow to create a revision from a file.

As the two apis were otherwise identical, I have ported the behavior of fs::add_created_version info fs::add_version.

The new fs::add_version will also take many defaults for unspecified parameters from the existing content item.

Options
    • -37
    • +110
    ./file-storage-procs.tcl
2:50 pm

antoniop

Make service contract implementation private

Options
    • -4
    • +6
    ./file-storage-procs.tcl
Monday 20 Feb 2023
10:55 am

antoniop

Don't load the DAV callbacks when oacs-dav is not installed

Options
    • -1
    • +6
    ./file-storage-dav-procs.tcl
Wednesday 15 Feb 2023
6:00 pm

antoniop

Commit remaining files

Options
    • -1
    • +57
    ./file-storage-dav-procs.tcl
    • -0
    • +2
    ./file-storage-init.tcl
    • -3
    • +2
    ./file-storage-install-procs.tcl
    • -4
    • +8
    ./file-storage-procs.tcl
Sunday 27 Nov 2022
11:52 am

gustafn

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

Options
    • -5
    • +3
    ./file-storage-procs.tcl
    • -5
    • +3
    ./test/file-storage-procs.tcl
    • -2
    • +1
    ./test/webtest-procs.tcl
  4. … 4 more files in changeset.
Tuesday 20 Sep 2022
2:16 pm

antoniop

Make service contract implementation private and replace foreign occurrences

Options
    • -10
    • +37
    ./file-storage-dav-procs.tcl
  2. … 1 more file in changeset.
2:00 pm

antoniop

Whitespace changes

Options
    • -17
    • +17
    ./file-storage-dav-procs.tcl
Monday 12 Sep 2022
5:38 pm

antoniop

Make service contract implementation private: they are not meant to be invoked directly

Options
    • -14
    • +14
    ./file-storage-dav-procs.tcl
Friday 09 Sep 2022
4:38 pm

antoniop

Make service contract implementations private

Options
    • -3
    • +3
    ./file-storage-search-procs.tcl
4:37 pm

antoniop

Whitespace cleanup

Options
    • -6
    • +6
    ./file-storage-search-procs.tcl
3:03 pm

antoniop

Deprecate twt::user::create and twt::user::delete, superseded by their acs::test::user:: counterparts

Options
    • -5
    • +5
    ./test/file-storage-procs.tcl
  2. … 11 more files in changeset.
Thursday 01 Sep 2022
12:41 am

antoniop

Fix self-inflicted bug: one should indeed be able to specify the same form var multiple time, test the behavior for the future

Options
    • -1
    • +1
    ./test/webtest-procs.tcl
  2. … 2 more files in changeset.
Wednesday 31 Aug 2022
2:55 pm

antoniop

Reimplement upload automated test using a real multipart request, as newer naviserver will reject handcrafted .tmpfile parameters

Options
    • -9
    • +19
    ./test/webtest-procs.tcl
Thursday 25 Aug 2022
1:29 pm

antoniop

Bring test closer to reality

Options
    • -6
    • +14
    ./test/webtest-procs.tcl
Wednesday 24 Aug 2022
10:58 am

antoniop

Test the behavior of the file-storage when a malicious user would try to store a pre-existing file on the server as its own

The fix for the file-storage is a simple validation to make sure that the tmpfile exists, however, for the generic case of the file widget, we cannot trust the tmpfile value when this was not generated by the server. This will probably cause regression when one wants to show a "preview" of a form, to be continued.

Options
    • -1
    • +121
    ./test/file-storage-procs.tcl
  2. … 2 more files in changeset.
9:05 am

antoniop

Whitespace cleanup

Options
    • -6
    • +6
    ./test/webtest-procs.tcl
Sunday 26 Jun 2022
9:28 pm

gustafn

acs::test::user::delete: added flag -delete_created_acs_objects and fix regression test for file-storage

Options
    • -3
    • +4
    ./test/file-storage-procs.tcl
  2. … 5 more files in changeset.
Thursday 17 Feb 2022
9:19 pm

gustafn

Fixes for Oracle 19c: more fixes of handling of Boolean values

Options
    • -5
    • +5
    ./file-storage-procs.tcl
Friday 04 Feb 2022
3:53 pm

antoniop

ad_conn provides since a long time a fallback when the package_id is queried outside of a connection context, hence no need for these concerning catches

Options
    • -19
    • +20
    ./file-storage-procs.tcl