• last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Harden page contracts

Fix date validation using new contract features

Fix version in package URL

  1. … 27 more files in changeset.
bumped version numbers to 5.10.1b1

  1. … 85 more files in changeset.
Fix botched revertion

Revert latest changes: the root cause was found to be in downstream-only code

  1. … 1 more file in changeset.
Ensure the empty string is never passed in the id list down to the templates

Also test that no missing message keys are there when rendering the portlet

    • -0
    • +16
    ./tcl/test/calendar-portlet-procs.tcl
  1. … 10 more files in changeset.
Test also the shaded portlet

    • -68
    • +86
    ./tcl/test/calendar-portlet-procs.tcl
  1. … 3 more files in changeset.
Complete coverage of the remaining api

Deprecate trivial calendar_portlet_display::get_url_stub not used anywhere

    • -2
    • +7
    ./tcl/calendar-portlet-display-procs.tcl
Extend tests of calendar portlet rendering

This will expose a limitation when multiple instances of the same portlet are rendered on the same page

    • -44
    • +114
    ./tcl/test/calendar-portlet-procs.tcl
Apply downstream fixes

Test of the calendar portlet, admin and regular, for all views

The tests exposes typos and forgottent variables in upstream code

    • -0
    • +66
    ./tcl/test/calendar-portlet-procs.tcl
Handle here as well the case, that we are just showcasing the portlet for "Portal Templates"

Handle the case of "Portal Templates", when the portlet is only showcased and should not be interacted with

Fix idiom

Streamline idiom, reduce access to the cache

Deprecate twt::user::create and twt::user::delete, superseded by their acs::test::user:: counterparts

    • -10
    • +10
    ./tcl/test/calendar-portlet-procs.tcl
  1. … 11 more files in changeset.
fix release dates in .info files

  1. … 82 more files in changeset.
release work

  1. … 204 more files in changeset.
bump version numbers of 5.9|5.10 packages to 5.10.0b1

adjust dependencies

  1. … 87 more files in changeset.
improve spelling

    • -2
    • +2
    ./tcl/calendar-admin-portlet-procs.tcl
  1. … 40 more files in changeset.
Make api public as other packages might need to retrieve the portlet name

  1. … 1 more file in changeset.
Make api public, complies with acs-api-browser.graph__bad_calls automated test

  1. … 4 more files in changeset.
Whitespace changes

Adjust naming to openacs conventions. Fixes 'naming__proc_naming' test case.

Add 'calendar_full_portlet::get_pretty_name' and 'calendar_portlet::get_pretty_name' to the 'calendar_portlet_links_names' test case

    • -0
    • +10
    ./tcl/test/calendar-portlet-procs.tcl
Add 'calendar_portlet_add_remove_from_page' test case, covering 'calendar_portlet::add_self_to_page', 'calendar_portlet::remove_self_from_page', 'calendar_list_portlet::add_self_to_page', 'calendar_list_portlet::remove_self_from_page', 'calendar_full_portlet::add_self_to_page', 'calendar_full_portlet::remove_self_from_page', 'calendar_admin_portlet::add_self_to_page', and 'calendar_admin_portlet::remove_self_from_page'

    • -0
    • +127
    ./tcl/test/calendar-portlet-procs.tcl
Add 'calendar_admin_portlet::get_pretty_name' and 'calendar_list_portlet::get_pretty_name' to 'calendar_portlet_links_names' test case

    • -6
    • +10
    ./tcl/test/calendar-portlet-procs.tcl