• last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Fix doc formatting, formatting changes

Whitespace cleanup

Add (basic) documentation to public api, formatting changes

Fix doc formatting so that it is displayed and retrieved correctly

Make package callbacks private, formatting changes

Deprecate twt::user::create and twt::user::delete, superseded by their acs::test::user:: counterparts

  1. … 11 more files in changeset.
Fix proc signature

  1. … 7 more files in changeset.
Deprecate notification::get_delivery_method_id, same as notification::delivery::get_id and looking more established

  1. … 7 more files in changeset.
Deprecate template::util::tcl_to_sql_list, completely replaced by ns_dbquotelist, a native NaviServer command

  1. … 14 more files in changeset.
Deprecate util_ns_set_to_list: ns_set array is an equivalent oneliner

  1. … 5 more files in changeset.
Reduce divergency between oracle and postgres codebase

    • -18
    • +0
    ./as-item-data-procs-postgresql.xql
  1. … 3 more files in changeset.
use util::unzip instead of plain "exec unzip" commands

  1. … 3 more files in changeset.
Make api public

Whitespace changes

    • -141
    • +135
    ./test/as-assessment-procs.tcl
Add proc names to the list of covered procs in assessment tests

use bind variables instead of tcl variable substition in xql fullqueries

  1. … 16 more files in changeset.
remove calls to deprecated proc acs_lookup_magic_object (use acs_magic_object instead)

  1. … 3 more files in changeset.
Replace limit idiom with portable idiom

    • -10
    • +0
    ./as-apm-action-procs-postgresql.xql
Deprecate content::folder::get_folder_from_package as it assumes there will be one folder per package, not true in general

Replace its only occurrence in the codebase with a local reimplementation (expecting the assessment package to comply with this restriction and not have more than 1 folder per package instance)

  1. … 1 more file in changeset.
improve spelling

  1. … 15 more files in changeset.
Whitespace changes

Comment out seemingly useless computation which has been detected running > 18s in some case on the live system

Whitespace cleanup

improve SQL quoting

  1. … 5 more files in changeset.
Check for existence before deleting attribute

Whitespace changes

Delete attribute 'survey_p', as it was replaced by 'type' in 2006 and is not created in new instances.

It is unclear if the 'survey_p' column of the 'as_assessments' table can also be dropped.

Original attribute replacement commit:

https://github.com/openacs/assessment/commit/433463faf6d50140fe26f848ab2f28662e0acc85#diff-cff15be6842f249cef812f983e064e78

https://fisheye.openacs.org/changelog/OpenACS?cs=MAIN%3Adaveb%3A20060926002244

  1. … 1 more file in changeset.
Replace deprecated idiom

apply patch from mischa to current development pranch

Use current namespace ::tdom instead of legacy ::tDOM