• last updated 2 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Whitespace changes

Comment out seemingly useless computation which has been detected running > 18s in some case on the live system

Whitespace cleanup

improve SQL quoting

  1. … 2 more files in changeset.
Check for existence before deleting attribute

Whitespace changes

Delete attribute 'survey_p', as it was replaced by 'type' in 2006 and is not created in new instances.

It is unclear if the 'survey_p' column of the 'as_assessments' table can also be dropped.

Original attribute replacement commit:

https://github.com/openacs/assessment/commit/433463faf6d50140fe26f848ab2f28662e0acc85#diff-cff15be6842f249cef812f983e064e78

https://fisheye.openacs.org/changelog/OpenACS?cs=MAIN%3Adaveb%3A20060926002244

Update es_ES message keys, and add placeholders for empty message keys

    • -6
    • +6
    ./catalog/assessment.en_US.ISO-8859-1.xml
    • -0
    • +6
    ./catalog/assessment.es_ES.ISO-8859-1.xml
Update es_ES message keys

    • -1
    • +2
    ./catalog/assessment.es_ES.ISO-8859-1.xml
  1. … 1 more file in changeset.
Deprecate with_finally and with_catch, superseded by e.g. try idioms in tcl 8.6

They would also not comply with OpenACS naming convention

  1. … 4 more files in changeset.
Whitespace cleanup

    • -156
    • +156
    ./www/asm-admin/export/index.vuh
  1. … 1 more file in changeset.
Replace deprecated idiom

Fix typo

Replace occurrences of exists_and_not_null with plain tcl idioms, as the goal is to deprecate this proc shortly

This required an upgrade script as some code is actually stored in the database

    • -1
    • +1
    ./sql/oracle/assessment-actions-package-create.sql
    • -0
    • +162
    ./sql/oracle/upgrade/upgrade-2.10.0d4-2.10.0d5.sql
file upgrade-2.10.0d4-2.10.0d5.sql was initially added on branch oacs-5-10.

    • -0
    • +0
    ./sql/oracle/upgrade/upgrade-2.10.0d4-2.10.0d5.sql
    • -0
    • +0
    ./sql/postgresql/upgrade/upgrade-2.10.0d4-2.10.0d5.sql
apply patch from mischa to current development pranch

Use current namespace ::tdom instead of legacy ::tDOM

improve spelling and comma settings

    • -2
    • +2
    ./www/doc/user_interface/item_creation.adp
  1. … 13 more files in changeset.
fix typo in file name

file data-model.adp was initially added on branch oacs-5-10.

    • -0
    • +0
    ./www/doc/data-model.adp
file data-model.html was initially added on branch oacs-5-10.

    • -0
    • +0
    ./www/doc/data-model.html
improve spelling

  1. … 16 more files in changeset.
improve spelling

    • -2
    • +2
    ./catalog/assessment.en_US.ISO-8859-1.xml
  1. … 1 more file in changeset.
Whitespace changes

Use 'lc_content_size_pretty' for content size

    • -1
    • +1
    ./catalog/assessment.ca_ES.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/assessment.en_US.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/assessment.es_ES.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/assessment.es_GT.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/assessment.gl_ES.ISO-8859-1.xml
    • -1
    • +1
    ./catalog/assessment.pt_BR.ISO-8859-1.xml
    • -3
    • +3
    ./www/asm-admin/item-add-mc-choices.tcl
    • -2
    • +2
    ./www/asm-admin/item-edit-mc-choices.tcl
fix seplling errors

    • -9
    • +9
    ./catalog/assessment.en_US.ISO-8859-1.xml
add ad_script abourt after termination command

improve spelling

improve spelling

  1. … 11 more files in changeset.
whitespace changes, including breaking overlong lines

    • -39
    • +43
    ./www/asm-admin/item-edit-display-cb.tcl
    • -32
    • +35
    ./www/asm-admin/item-edit-display-f.tcl
    • -38
    • +42
    ./www/asm-admin/item-edit-display-rb.tcl
    • -32
    • +35
    ./www/asm-admin/item-edit-display-sa.tcl
    • -42
    • +46
    ./www/asm-admin/item-edit-display-sb.tcl
    • -34
    • +37
    ./www/asm-admin/item-edit-display-ta.tcl
    • -32
    • +36
    ./www/asm-admin/item-edit-display-tb.tcl
    • -15
    • +19
    ./www/asm-admin/item-edit-fu.tcl
    • -3
    • +7
    ./www/asm-admin/item-edit-mc-choices.tcl
    • -67
    • +71
    ./www/asm-admin/item-edit-mc.tcl
    • -23
    • +25
    ./www/asm-admin/item-edit-oq.tcl
    • -22
    • +26
    ./www/asm-admin/item-edit-sa.tcl
    • -12
    • +17
    ./www/asm-admin/results-edit.tcl