OpenACS / openacs-4 / packages / acs-tcl / tcl

test

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 26
Last Commit: 27 Dec
Commits this week: 0
Total Lines of Code (LoC): 12,538
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 06 Sep 2022
2:22 pm

antoniop

file defs-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./defs-procs.tcl
9:40 am

antoniop

Deprecate util_commify_number, replace occurrences and translate automated tests

Options
    • -20
    • +20
    ./acs-tcl-test-procs.tcl
  2. … 9 more files in changeset.
Thursday 01 Sep 2022
11:50 am

antoniop

Extend regression test

Options
    • -5
    • +64
    ./http-client-procs.tcl
12:41 am

antoniop

Fix self-inflicted bug: one should indeed be able to specify the same form var multiple time, test the behavior for the future

Options
    • -0
    • +59
    ./http-client-procs.tcl
  2. … 2 more files in changeset.
Monday 29 Aug 2022
1:53 pm

gustafn

Use "ns_parsehtml" for speed and correctness when available

The new NaviServer built-in command "ns_parsehtml" is used on

several occasions in the code when available, namely in

- util_close_html_tags

- escaping disallowed HTML tags in ad_text_to_html

- util_close_html_tags

The command "util_close_html_tags" has a long history of troubles,

since it was implemented originally based on regular expressions. It

was reported in Jan 2009, that the function took on certain forums

entries 6 to 9 hours (e.g. /forums/message-view?message_id=357753) to

finish. Therefore, at this time a quick version based on tdom was

introduced, which reduced at that time the performance to 7.3

seconds. However, the tdom-based version tend to fail on invalid HTML,

so it could cover only a few cases. The new "ns_parsehtml" is more

robust and works very stable on openacs.org with the know problem

cases. Furthermore, this version is also significantly faster than the

tdom version.

Options
    • -6
    • +17
    ./html-conversion-procs.tcl
  2. … 1 more file in changeset.
12:34 pm

gustafn

improve spelling

Options
    • -1
    • +1
    ./acs-db-00-procs.tcl
    • -1
    • +1
    ./apm-install-procs.tcl
    • -10
    • +69
    ./html-conversion-procs.tcl
    • -7
    • +7
    ./object-test-case-procs.tcl
  5. … 3 more files in changeset.
11:47 am

antoniop

Fix typo

Options
    • -1
    • +1
    ./doc-check-procs.tcl
Saturday 27 Aug 2022
10:35 pm

gustafn

use icanuse "ns_parsehtml" and new interface

Options
    • -5
    • +4
    ./doc-check-procs.tcl
Friday 26 Aug 2022
3:00 pm

antoniop

Deprecate ad_parameter_all_values_as_list: it does not provide much value and was also often use improperly

Options
    • -2
    • +0
    ./html-conversion-procs.tcl
  2. … 4 more files in changeset.
2:06 pm

antoniop

tmpfile page contract filter reform:

do not allow acs-subsite TmpDir parameter to define where the tmpfolder is located anymore. This MUST be the one configured in the server-wide configuration. Tmpfiles cannot be in a subfolder of the tmpfolder, they MUST be direct children instead. A tmpfile MUST exist beforehand and be owned, be readable and writable by the user running the nsd process. This complies with the definition of a tmpfile by AolServer/NaviServer when they are created to store content coming from a file upload.

Options
    • -28
    • +0
    ./security-procs.tcl
  2. … 4 more files in changeset.
Thursday 25 Aug 2022
5:37 pm

antoniop

Reimplement ad_page_contract_filter_proc_tmpfile using security::safe_tmpfile_p

Some of the features implemented by this filter have been ported into the api, namely the possibility to fetch the valid temp folders from the subsite TmpDir parameter and the possibility to relax the check and allow also files deeper in the tmpfolder hierachy.

Notably, the hardcoded tmpfolders "/var/tmp" and "/tmp" have NOT been ported. One should configure these values via the many available options. security::safe_tmpfile_p is also more restrictive when a file exists, because it checks for ownership and read and write permissions on the file.

Options
    • -1
    • +30
    ./security-procs.tcl
  2. … 2 more files in changeset.
3:12 pm

antoniop

Declare proc coverage

Options
    • -0
    • +2
    ./http-client-procs.tcl
  2. … 1 more file in changeset.
2:37 pm

antoniop

Add must_exist flag to enforce a safe tmpfile to already exist

Options
    • -1
    • +6
    ./security-procs.tcl
  2. … 2 more files in changeset.
1:44 pm

gustafn

Fixed bug in util_convert_line_breaks_to_html

The code deleted spaces around certain tags, while - according to the

documentation, only line breaks should be removed from there.

Extended regression test.

Options
    • -5
    • +14
    ./html-conversion-procs.tcl
  2. … 1 more file in changeset.
1:25 pm

antoniop

Introduce security::safe_tmpfile_p checking whether a file belongs to the configured tmpfolder and respects other constraints

The plan is to use it to improve input validations

Options
    • -0
    • +45
    ./security-procs.tcl
  2. … 2 more files in changeset.
Wednesday 24 Aug 2022
4:30 pm

gustafn

improve test coverage of apm_* API

Options
    • -0
    • +24
    ./apm-procs.tcl
2:13 pm

gustafn

added test for checking documentation in regard of valid HTML markup

Options
    • -2
    • +53
    ./doc-check-procs.tcl
Tuesday 23 Aug 2022
1:10 pm

gustafn

Changed "db_multirow" to use "db_list_of_lists" instead of "db_list_of_ns_sets"

Thanks to the recent improvements in NaviServer for

"db_list_of_lists", it is more efficient to use this in "db_multirow"

(actually in "db_multirow_helper"). The implementation revealed a bug

in "db_list_of_lists", when both options "-columns_var" and

"-with_headers" were set.

Extended regression test to cover the former bug.

Options
    • -1
    • +17
    ./db-proc-test-procs.tcl
  2. … 1 more file in changeset.
Friday 19 Aug 2022
12:15 pm

antoniop

Test apm_get_repository_channels proc

Options
    • -0
    • +25
    ./apm-install-procs.tcl
12:15 pm

antoniop

file apm-install-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./apm-install-procs.tcl
Wednesday 17 Aug 2022
12:43 pm

antoniop

Fix typo

Options
    • -1
    • +1
    ./db-proc-test-procs.tcl
Monday 08 Aug 2022
4:48 pm

gustafn

fix several bugs in "acs_object_type::supertype" and improve code sanity

Options
    • -1
    • +10
    ./object-test-case-procs.tcl
  2. … 2 more files in changeset.
1:01 pm

antoniop

Replace not portable sql idiom with existing api, improve caching, extend regression test

Options
    • -1
    • +19
    ./object-test-case-procs.tcl
  2. … 2 more files in changeset.
Friday 29 Jul 2022
7:27 pm

gustafn

fix testcase as indicated by hector, extend regression test

Options
    • -6
    • +20
    ./db-proc-test-procs.tcl
  2. … 1 more file in changeset.
Wednesday 27 Jul 2022
3:54 pm

hectorr

Extend 'db__db_foreach' test case, exposing a regression in 'db_foreach' with an uneven number of columns

Options
    • -0
    • +14
    ./db-proc-test-procs.tcl
Wednesday 20 Jul 2022
1:46 pm

gustafn

deactivate useless warning

Options
    • -4
    • +8
    ./db-proc-test-procs.tcl
Friday 15 Jul 2022
3:58 pm

antoniop

Improve api robustness and test it

Options
    • -1
    • +52
    ./object-test-case-procs.tcl
  2. … 1 more file in changeset.
Thursday 14 Jul 2022
4:36 pm

antoniop

Improve test

Options
    • -0
    • +10
    ./tcl-documentation-procs.tcl
3:31 pm

antoniop

ad_page/include_contract argspec parsing reform: allow arbitrary characters in the argspec flag parameters

This reform allows to specify an argspec containing pipes, parenthesys and other so far forbidden characters as parameters for a flag. The purpose is to enhance the expressiveness of existing validators (e.g. the oneof validator) and enable new one, for instance, a date validator using a clock format as parameter.

Pipes and parenthesys need to be escaped via the backslash character in the new syntax.

Options
    • -0
    • +112
    ./tcl-documentation-procs.tcl
  2. … 1 more file in changeset.
3:31 pm

antoniop

file tcl-documentation-procs.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./tcl-documentation-procs.tcl