ad-return-complaint.adp

  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
quote error message per default.

This should at least be the safe default assumption.

If in some cases it is necessary to relax this, one should

provide a swith for the non-default case.

merged changes from the oacs-5-9 branch and resolved conflicts

  1. … 7834 more files in changeset.
- add return link for complaint pages

  1. … 2 more files in changeset.
Merging back to HEAD branch oacs-5-8 (using tag vg-merge-oacs-5-8-from-20141027).

  1. … 2547 more files in changeset.
- use property "doc(title)" throughout oacs-5-8 instead of "title" to get rid of warnings in error.log of the form:

Warning: /forums/message-view has no doc(title) set.

Using doc(title) is required in blank-master.tcl but was used so far only in a few packages

  1. … 337 more files in changeset.
Fix HTML and master

  1. … 1 more file in changeset.
Added support for cookie domain

  1. … 1 more file in changeset.
Merged acs-core oacs-5-2 (currently 5.2.3) -> HEAD.

TODO:

1. Bump acs-core package version numbers to 5.3.0d1

2. Would be nice to do a test install, wouldn't it?

  1. … 721 more files in changeset.
I18N of error messages

  1. … 4 more files in changeset.
Lars changed ad_page_contract to call the "complain" template rather than

spit out HTML directly. However he used a multirow, and while this is nice,

it ain't what "complain" took. I moved "complain" to "ad-return-complaint"

(to match the name of the Tcl proc that calls it) ... and created a new "complain"

that does the multirow thing. "ad_return_complaint" is begging for retirement

as it assumes you have an "<li>" in each error list element if there's more than

one of them and also forces you to pass the number of error messages.

That's why I created a new template rather than rewrite ad_return_complaint

to stuff the error list into a multirow (my "complain" template, used by

"ad_page_contract", does the <li> tags itself - something a site designer

can change, the whole point of templating this).

    • -0
    • +21
    ./ad-return-complaint.adp
  1. … 1 more file in changeset.