OpenACS / openacs-4 / packages

acs-subsite

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 79
Last Commit: 20 Dec
Commits this week: 0
Total Lines of Code (LoC): 49,839
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Tuesday 15 Feb 2022
6:21 pm

gustafn

Fixes for Oracle 19c: boolean types in query

This fixes the following bug for Oracle:

[13/Feb/2022:17:53:36][8701.7f9f62f0b700][-conn:oacs-5-10-0:default:0:0-] Error: nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00920: invalid relational operator

:

: SQL:

:

: select p.package_id,

: p.instance_name,

: n.node_id,

: n.name,

: :subsite_url || n.name as url,

: (select count(*)

: from group_approved_member_map m

: where m.rel_type = 'membership_rel'

: and m.group_id = ag.group_id) as num_members,

: (select min(r2.member_state)

: from group_member_map m2,

: membership_rels r2

: where m2.group_id = ag.group_id

: and m2.member_id = :untrusted_user_id

: and r2.rel_id = m2.rel_id) as member_state,

: g.group_id,

: g.join_policy

: from site_nodes n,

: apm_packages p,

: application_groups ag,

: groups g

: where n.parent_id = :subsite_node_id

: and p.package_id = n.object_id

: and p.package_key in ('acs-subsite')

: and ag.package_id = p.package_id

: and g.group_id = ag.group_id

: and (g.join_policy !>>>!!= 'closed' or acs_permission.permission_p(p.package_id, :untrusted_user_id, 'read'))

: order by lower(instance_name)

:

Options
    • -1
    • +2
    ./lib/subsites.xql
6:20 pm

gustafn

Fixes for Oracle 19c: boolean types in query

This fixes the following bug for Oracle:

': ORA-00920: invalid relational operator

:

: SQL:

: select p.package_id,

: p.instance_name,

: n.node_id,

: n.name

: from site_nodes n,

: apm_packages p,

: apm_package_types t

: where n.parent_id = :subsite_node_id

: and p.package_id = n.object_id

: and t.package_key = p.package_key

: and t.package_type = 'apm_application'

: and acs_permission.permission_p(p.package_id, :user_id, 'read')

: !>>>!order by upper(instance_name)

:

Options
    • -1
    • +3
    ./lib/applications.tcl
Sunday 13 Feb 2022
8:31 pm

gustafn

fix cut&paste issue

Options
    • -1
    • +1
    ./tcl/subsite-callback-procs-postgresql.xql
5:46 pm

gustafn

Fixes for Oracle 19c recursive query

Oracle has a slightly differnt syntax for CTEs require arguments, keyword "recursive" is not allowed.

This fixes the following error during initial installation:

nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00905: missing keyword

SQL:

with recursive !>>>!object_hierarchy as (

select object_type, supertype

from acs_object_types

where object_type = coalesce(:object_type, (select object_type

from acs_objects

where object_id = :object_id))

union all

select t.object_type, t.supertype

from acs_object_types t,

object_hierarchy s

where t.object_type = s.supertype

)

select distinct callback, callback_type as type

from subsite_callbacks

where event_type = :event_type

and object_type in (select object_type from object_hierarchy)

Options
    • -0
    • +30
    ./tcl/subsite-callback-procs-oracle.xql
    • -0
    • +30
    ./tcl/subsite-callback-procs-postgresql.xql
    • -21
    • +2
    ./tcl/subsite-callback-procs.tcl
Thursday 27 Jan 2022
10:23 am

antoniop

Deprecate template::util::tcl_to_sql_list, completely replaced by ns_dbquotelist, a native NaviServer command

Options
    • -1
    • +1
    ./www/permissions/perm-modify.xql
  2. … 17 more files in changeset.
Friday 14 Jan 2022
8:23 pm

antoniop

Whitespace cleanup

Options
    • -11
    • +11
    ./www/user/password-update.tcl
Tuesday 28 Dec 2021
3:54 pm

antoniop

Streamline ns_set idiom

Options
    • -5
    • +2
    ./tcl/package-procs.tcl
  2. … 2 more files in changeset.
12:15 pm

antoniop

Streamline idiom

Options
    • -6
    • +7
    ./www/pvt/set-on-vacation-until.tcl
Thursday 25 Nov 2021
1:33 pm

hectorr

Bump version number after message key spelling changes

Options
    • -2
    • +2
    ./acs-subsite.info
Friday 19 Nov 2021
10:03 am

gustafn

improve german message keys (spelling, comma, spaces, orthogonality)

Options
    • -11
    • +11
    ./catalog/acs-subsite.de_DE.ISO-8859-1.xml
  2. … 3 more files in changeset.
Tuesday 19 Oct 2021
10:32 am

gustafn

improve safety of SQL queries

Options
    • -1
    • +1
    ./lib/subsites.tcl
    • -5
    • +4
    ./tcl/attribute-procs.tcl
    • -2
    • +2
    ./tcl/package-procs.tcl
    • -2
    • +2
    ./tcl/subsite-procs.tcl
  5. … 1 more file in changeset.
Monday 04 Oct 2021
3:56 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -25
    • +0
    ./www/admin/rel-types/one-oracle.xql
    • -22
    • +0
    ./www/admin/rel-types/one-postgresql.xql
    • -2
    • +15
    ./www/admin/rel-types/one.tcl
3:49 pm

antoniop

Cleanup unreferenced SQL

Options
    • -15
    • +0
    ./www/admin/site-map/index-oracle.xql
12:30 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -27
    • +0
    ./www/admin/group-types/one-oracle.xql
    • -23
    • +0
    ./www/admin/group-types/one-postgresql.xql
    • -2
    • +15
    ./www/admin/group-types/one.tcl
Thursday 16 Sep 2021
10:27 am

gustafn

fix release dates in .info files

Options
    • -1
    • +1
    ./acs-subsite.info
  2. … 82 more files in changeset.
Wednesday 15 Sep 2021
6:11 pm

gustafn

release work

Options
    • -8
    • +8
    ./acs-subsite.info
  2. … 204 more files in changeset.
Tuesday 14 Sep 2021
8:01 pm

gustafn

whitespace changes

Options
    • -96
    • +96
    ./tcl/package-procs-postgresql.xql
    • -2
    • +2
    ./tcl/package-procs.tcl
Friday 03 Sep 2021
11:14 am

gustafn

regenerated documentation

Options
    • -3
    • +3
    ./www/doc/group-admin-pages-acceptance-test.adp
    • -1
    • +1
    ./www/doc/group-admin-pages-design.adp
    • -1
    • +1
    ./www/doc/group-admin-pages-requirements.adp
    • -1
    • +1
    ./www/doc/images.adp
    • -3
    • +3
    ./www/doc/index.adp
  6. … 464 more files in changeset.
Thursday 02 Sep 2021
7:22 pm

gustafn

bump version numbers of 5.9|5.10 packages to 5.10.0b1

adjust dependencies

Options
    • -8
    • +8
    ./acs-subsite.info
  2. … 87 more files in changeset.
Wednesday 01 Sep 2021
11:13 am

gustafn

improve validation of email address and user-id used as source for email address

Options
    • -1
    • +1
    ./www/shared/send-email.tcl
  2. … 1 more file in changeset.
Monday 02 Aug 2021
11:26 pm

gustafn

Reduce usage of ns_mktemp in OpenACS

ns_mktemp uses the deprecated old POSIX call mktemp(), which should

not be used anymore for security reasons (race between the name

creation and opening the file). This change removes several usages of

"ns_mktemp" from OpenACS and replaces it with calls to the

safe Tcl call "file tempfile ..." (introduced by Tcl 8.6).

Options
    • -3
    • +2
    ./www/shared/1pixel.tcl
  2. … 7 more files in changeset.
Monday 28 Jun 2021
10:41 am

hectorr

Make package_id explicit

Options
    • -2
    • +3
    ./tcl/test/acs-subsite-procs.tcl
Friday 25 Jun 2021
3:54 pm

hectorr

Add 'acs_subsite_rel_segment_new' test case, covering 'rel_segment::new', 'rel_segment::delete' and 'group::get_rel_segment'

Options
    • -1
    • +42
    ./tcl/test/acs-subsite-procs.tcl
1:23 pm

hectorr

Add 'acs_subsite_application_group_new' test case, covering 'application_group::new' and 'application_group::delete'

Options
    • -1
    • +31
    ./tcl/test/acs-subsite-procs.tcl
1:14 pm

hectorr

Add 'acs_subsite_rel_type_roles' test case, covering 'rel_types::create_role' and 'rel_types::create_role'

Options
    • -1
    • +37
    ./tcl/test/acs-subsite-procs.tcl
Thursday 24 Jun 2021
4:18 pm

hectorr

Add 'acs_subsite_relation_procs' test case, covering 'relation_add', 'relation_remove', 'relation::get_object_one', 'relation::get_object_two', 'relation::get_objects' and 'relation::get_id'

Options
    • -1
    • +77
    ./tcl/test/acs-subsite-procs.tcl
Thursday 11 Mar 2021
6:17 pm

hectorr

Whitespace changes

Options
    • -2
    • +1
    ./tcl/test/acs-subsite-procs.tcl
4:25 pm

hectorr

Use the new 'email' input type widget

Options
    • -2
    • +13
    ./lib/login.tcl
  2. … 1 more file in changeset.
3:56 pm

hectorr

Use the new 'email' input type widget

Options
    • -2
    • +4
    ./www/register/recover-password.tcl
3:51 pm

hectorr

Whitespace changes

Options
    • -2
    • +2
    ./www/members/member-invite.tcl
    • -5
    • +1
    ./www/register/recover-password.tcl