• last updated 3 hours ago
Constraints: committers
Constraints: files
Constraints: dates
improve validation of email address and user-id used as source for email address

  1. … 1 more file in changeset.
Reduce usage of ns_mktemp in OpenACS

ns_mktemp uses the deprecated old POSIX call mktemp(), which should

not be used anymore for security reasons (race between the name

creation and opening the file). This change removes several usages of

"ns_mktemp" from OpenACS and replaces it with calls to the

safe Tcl call "file tempfile ..." (introduced by Tcl 8.6).

  1. … 7 more files in changeset.
Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

  1. … 58 more files in changeset.
remove calls to deprecated proc acs_lookup_magic_object (use acs_magic_object instead)

  1. … 3 more files in changeset.
use "ad_file" as a means to avoid unexpected tilde substitution in file names

  1. … 12 more files in changeset.
add callback invocation into parameter::set_global_value and parameter::set_value

to achieve a more consistent behavior

  1. … 1 more file in changeset.
Rename ReturnHeaders proc to comply with OpenACS naming convention, create deprecated wrapper, replace occurrences

  1. … 10 more files in changeset.
Deprecated get_referrer and NsSettoTclString, replace them with versions that respect OpenACS naming convention

  1. … 7 more files in changeset.
prefer all caps spelling for SQL

  1. … 2 more files in changeset.
improve spelling

  1. … 6 more files in changeset.
Remove dead xqls

document optional channel closing during subscribe operations

Make sure connection channel is available (e.g. not detached) before returning content, as more recent Naviserver versions would return an error

whitespace changes

  1. … 51 more files in changeset.
improve code formatting

Added missing message key for status code 500.

Use consistently the error category in the title and the specific error message in the text

  1. … 2 more files in changeset.
Add 'message-undelete' page to make use of the new '::message::undelete' proc for undeleting messages, a couple of icons, the undelete option in 'message-list' and the undelete action in automated tests

  1. … 5 more files in changeset.
file Undelete24.gif was initially added on branch oacs-5-10.

    • binary
file Undelete16.gif was initially added on branch oacs-5-10.

    • binary
Move chat.tcl into acs-subsite:

although this would depend on xowiki, having in xowiki/www might conflict with legitimate pages named "chat"

  1. … 2 more files in changeset.
file chat.tcl was initially added on branch oacs-5-10.

Add ad_page_contract (fixes automated tests)

Whitespace changes

use consistently 'ad_script_abort' after 'ns_returnfile'

Add missing 'ad_script_abort' after 'ns_returnfile'

Better handling of errors during 'exec convert' in portrait-bits.tcl, returning the default avatar when it fails

Use a variable for the default avatar mime type

Return default avatar also when there are internal issues parsing the user provided picture

Optimize avatar image size (~30%, using Trimage)

Make the default avatar images look slightly better when rounded