• last updated 1 hour ago
Constraints: committers
Constraints: files
Constraints: dates
address issue #3456

fix typos

fix for issue #3455

Prefer 'namespace which' over 'info commands', as it is faster (on local tests, around 2x) and returns a single value. Many thanks to Nathan Coulter.

  1. … 57 more files in changeset.
prefer db_0or1row for exists-queries

support passing a dict as argument to "group::update" (not only array)

prefer db_0or1row +"where exists" over db_string + "select case"

  1. … 3 more files in changeset.
Improve sql portability

  1. … 1 more file in changeset.
Replace limit with a portable idiom

Make apm callbacks private and move them together with the others

When a new group is created, flush all the group::get_id caches with the same name so that the new group has a chance to be retrieved

Note that it is wrong to assume a group_name will be unique, although this is normally not far from the truth in our everyday practice

Cover more group api

this also exposes a potential problem with group::get_id when a group is created, deleted, and then a new one is created with the same name (e.g. executing the test multiple times). As the memoize cache is not maintained, the returned group_id will be incorrect.

Increase proc coverage

Fix typo

acs-lang reform

Provide an optional object_id which can be used to register message keys that will be bound to the lifecycle of an acs-object. When the object is deleted, so will the message key.

This is useful for groups that automatically define a message key for their pretty name. Tcl api was already aware of this and would cleanup such message keys, but other idioms e.g. stored procedures used to delete groups would leave leftovers behind. These can become relatively numerous on group-intensive systems such as LEARN.

Other future usages for this new feature might be the automatic localization of xowiki FormPage properties.

  1. … 9 more files in changeset.
New test checking that no leftover groups localizations are still there on the system

Cleanup test message key

Test covering the automagical localization of group pretty names

fix for issue #3445

a broken query (without a table alias) was

in the .xql file, where the correct query was

in the source (where it was ignored). This

can be quite confusing. It is probably

a good idea to improve code locality

and use .xql just in cases, where the

query is NOT included in the source.

I took the opportunity to fix more such cases

in this file.

Many thanks to Tony Kirkham for the bug report.

CVS: ----------------------------------------------------------------------

improve spelling

  1. … 16 more files in changeset.
use "ad_file" as a means to avoid unexpected tilde substitution in file names

  1. … 11 more files in changeset.
prefer "ns_conn isconnected" over "ad_conn isconnected", since the latter might not notice changes in the connect state

  1. … 15 more files in changeset.
mprove spelling: move closer to the linux documentation recommendations, standardize variable names

  1. … 15 more files in changeset.
acs::per_request_cache: standardize per-request caching

- added per-request cache verfsy similar to acs::per_thread_cache

- use per-request-cache on several occasions

- bump version number of acs-tcl to 5.10.0d35

  1. … 9 more files in changeset.
prefer dict over array

Do not convert into upper case the 'id_column' attribute in 'acs_object_types' for group types. This attribute was upper case, both in oracle and postgres, causing a discrepancy with the column real name, found by the 'datamodel__acs_object_type_check' test case. The package upgrade fixes the already existing attributes in postgres.

  1. … 1 more file in changeset.
Restrict upgrade logic to postgres, as mentioned in previous commit

Normalize case of 'table_name' attribute in 'acs_object_types' for group types to lower case, in postgres. This attribute was created in upper case, causing a discrepancy with the table real name. As this is now fixed by a previous commit, this package upgrade fixes the already existing attributes.

  1. … 1 more file in changeset.
Whitespace changes

Only convert table names to uppercase, during group type creation, on oracle. This was producing case mixed issues on postgres installations, where the table_name attribute on 'acs_object_types' was upppercase, while the real table name was lowercase, as detected by the 'datamodel__acs_object_type_check' test case.