OpenACS / openacs-4 / packages / acs-subsite

lib

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 0
Total Committers: 27
Last Commit: 20 Dec
Commits this week: 0
Total Lines of Code (LoC): 1,477
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 31 Aug 2022
11:44 am

antoniop

Deprecate acs-subsite/www/shared/db-error and move a copy to acs-subsite/lib/shared/db-error, replace occurrences, adjust dependencies

Options
    • -0
    • +20
    ./shared/db-error.adp
  2. … 7 more files in changeset.
11:44 am

antoniop

file db-error.adp was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    ./shared/db-error.adp
Monday 29 Aug 2022
4:17 pm

antoniop

Deprecate template::util::is_true, implemented as a simple string command oneliner since 2015 and inline occurrences

Options
    • -1
    • +1
    ./login.tcl
  2. … 33 more files in changeset.
Friday 15 Jul 2022
4:25 pm

antoniop

Localize subsites UI on the homepage

Options
    • -6
    • +6
    ./subsites.tcl
Sunday 26 Jun 2022
9:37 pm

gustafn

150px is not enough. In general, these setting should be performed via style files.

Options
    • -3
    • +3
    ./login.tcl
Tuesday 15 Feb 2022
6:21 pm

gustafn

Fixes for Oracle 19c: boolean types in query

This fixes the following bug for Oracle:

[13/Feb/2022:17:53:36][8701.7f9f62f0b700][-conn:oacs-5-10-0:default:0:0-] Error: nsoracle.c:1367:OracleSelect: error in `OCIStmtExecute ()': ORA-00920: invalid relational operator

:

: SQL:

:

: select p.package_id,

: p.instance_name,

: n.node_id,

: n.name,

: :subsite_url || n.name as url,

: (select count(*)

: from group_approved_member_map m

: where m.rel_type = 'membership_rel'

: and m.group_id = ag.group_id) as num_members,

: (select min(r2.member_state)

: from group_member_map m2,

: membership_rels r2

: where m2.group_id = ag.group_id

: and m2.member_id = :untrusted_user_id

: and r2.rel_id = m2.rel_id) as member_state,

: g.group_id,

: g.join_policy

: from site_nodes n,

: apm_packages p,

: application_groups ag,

: groups g

: where n.parent_id = :subsite_node_id

: and p.package_id = n.object_id

: and p.package_key in ('acs-subsite')

: and ag.package_id = p.package_id

: and g.group_id = ag.group_id

: and (g.join_policy !>>>!!= 'closed' or acs_permission.permission_p(p.package_id, :untrusted_user_id, 'read'))

: order by lower(instance_name)

:

Options
    • -1
    • +2
    ./subsites.xql
6:20 pm

gustafn

Fixes for Oracle 19c: boolean types in query

This fixes the following bug for Oracle:

': ORA-00920: invalid relational operator

:

: SQL:

: select p.package_id,

: p.instance_name,

: n.node_id,

: n.name

: from site_nodes n,

: apm_packages p,

: apm_package_types t

: where n.parent_id = :subsite_node_id

: and p.package_id = n.object_id

: and t.package_key = p.package_key

: and t.package_type = 'apm_application'

: and acs_permission.permission_p(p.package_id, :user_id, 'read')

: !>>>!order by upper(instance_name)

:

Options
    • -1
    • +3
    ./applications.tcl
Tuesday 19 Oct 2021
10:32 am

gustafn

improve safety of SQL queries

Options
    • -1
    • +1
    ./subsites.tcl
  2. … 4 more files in changeset.
Thursday 11 Mar 2021
4:25 pm

hectorr

Use the new 'email' input type widget

Options
    • -2
    • +13
    ./login.tcl
  2. … 1 more file in changeset.
3:40 pm

hectorr

Use the new 'url' and 'email' input type widgets

Options
    • -2
    • +2
    ./user-info.tcl
  2. … 1 more file in changeset.
Saturday 08 Aug 2020
1:19 pm

gustafn

improve spelling

Options
    • -1
    • +1
    ./user-new.tcl
  2. … 16 more files in changeset.
Saturday 06 Jun 2020
6:28 pm

gustafn

use "-varname" parameter for message_exists_p

Options
    • -2
    • +2
    ./user-info.tcl
  2. … 1 more file in changeset.
Thursday 02 Jan 2020
2:24 pm

antoniop

Fix remaining occurrence of "screen_name" variable used to actually tell HOW to display the screen_name

Options
    • -2
    • +3
    ./user-info.tcl
2:17 pm

antoniop

Use ad_include_contract

Options
    • -0
    • +7
    ./user-subsites.tcl
2:13 pm

antoniop

Add ad_include_contract

Options
    • -3
    • +5
    ./services.tcl
Friday 13 Dec 2019
1:22 pm

gustafn

bug-fix: don't use variable "screen_name" for controlling display of ScreenName,

since it used as value for the actual screen name as well.

as a consequence, user got e.g. a value of "none" set as their acutal screen name, which

lead to a conflict with the unique screen name constraint of the data model

the conflicst with CVS: ----------------------------------------------------------------------

Options
    • -11
    • +9
    ./user-info.tcl
Thursday 28 Nov 2019
1:10 pm

gustafn

provde a global variable as transitional code for controlling passing of password as query variable

Options
    • -3
    • +9
    ./user-new.tcl
  2. … 2 more files in changeset.
12:06 pm

gustafn

don't pass sensitive information (e.g. password) as query variable, but use client properties instead.

see also issue #3344

Options
    • -3
    • +10
    ./user-new.tcl
  2. … 5 more files in changeset.
Thursday 11 Jul 2019
12:57 pm

hectorr

Add a new instance parameter 'LoginPasswordAutocomplete' with the value of the 'autocomplete' attribute of the password field of the login form, to let each subsite decide.

Options
    • -1
    • +9
    ./login.tcl
  2. … 1 more file in changeset.
Wednesday 10 Jul 2019
5:44 pm

hectorr

Disable autocomplete on login password field. See: https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#The_autocomplete_attribute_and_login_fields

Options
    • -1
    • +1
    ./login.tcl
Tuesday 09 Jul 2019
11:24 am

antoniop

Rework query to use permission api instead of just removed materialized views

Options
    • -5
    • +1
    ./subsites.xql
Thursday 20 Jun 2019
2:44 pm

gustafn

Modernize logic for protecting against cached passwords from forms,

when users log out and other users use the back button (for Nora).

- switch to more modern caching prevention

- add CSRF protection to login form against forgery requests

- none of the cache-preventing mechanisms helps when the user

stores the password in the browser (no change to the past).

- For admins of existing sites: alter kernel parameter

"LoginPageExpirationTime" to 0 make use of this feature

Options
    • -19
    • +30
    ./login.tcl
  2. … 2 more files in changeset.
Wednesday 10 Apr 2019
11:38 pm

gustafn

whitespace changes

Options
    • -3
    • +3
    ./login.tcl
11:05 pm

gustafn

obtain default authority_id via "auth::authority::get"

Options
    • -2
    • +2
    ./login.tcl
  2. … 3 more files in changeset.
Friday 29 Mar 2019
2:46 pm

antoniop

Do not abort when returning a message

Options
    • -1
    • +0
    ./email-confirm.tcl
12:35 pm

antoniop

Fix regression retrieving the member state

Options
    • -1
    • +1
    ./email-confirm.adp
    • -0
    • +1
    ./email-confirm.tcl
Tuesday 19 Mar 2019
1:43 pm

antoniop

Remove dead adp code: if user is found and token is correct, email_verified_p will be always true, because it is forcefully set by the proc. In any other case, we will execute a different adp (lib/message)

Options
    • -21
    • +7
    ./email-confirm.adp
    • -0
    • +1
    ./email-confirm.tcl
Monday 18 Mar 2019
4:52 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -29
    • +0
    ./applications-oracle.xql
    • -25
    • +0
    ./applications-postgresql.xql
    • -1
    • +15
    ./applications.tcl
4:01 pm

antoniop

Reduce divergency between oracle and postgres codebase

Options
    • -43
    • +0
    ./subsites-oracle.xql
    • -40
    • +0
    ./subsites-postgresql.xql
    • -1
    • +30
    ./subsites.tcl
Thursday 14 Mar 2019
5:22 pm

antoniop

Note that this include might be obsolete

Options
    • -0
    • +4
    ./services.tcl