• last updated 13 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Rework array idioms in dict idioms where appropriate, avoid unsetting arrays via pattern matching

tcl9 changes in regression test: "2000-00-00 00:00:00" is not a valid date anymore

tcl9 changes in regression test: fix read of latin1 file with wrong encoding

merge from oacs-5-10

    • -1
    • +416
    ./acs-lang-localization-procs.tcl
  1. … 8093 more files in changeset.
sharpen test case to reduced dependencies on previously enabled locales

The test is also more parameterized, such one can choose between two locales (de_DE and es_ES)

in the test case.

improved spelling

  1. … 15 more files in changeset.
Improved regression test

- make string match with message keys more exact

- avoid substitution errors when fetching arbitrary message keys from the DB

- reduced verbosity

    • -10
    • +21
    ./acs-lang-localization-procs.tcl
New API call: aa_silence_log_entries

The new function silences expected messages in the system log. The

proc deactivates the specified severity levels during the code in the

last arguemnt is executed. After it has finished, the severity levels

are reset to their previous values.

The purpose of this function is to make test system log clean from

error messages and the like during the regression test, such it

contains only errors which have to be looked at.

  1. … 6 more files in changeset.
silence expected error messages in the log file during regression test

added after-mount callback to restrict default permissions

- Modify default permissions after mount to restrict read access to

the package from public read to read access for registered users.

- The change affects only fresh installed, existing permission settings

are not touched.

- fixed typos

- bumped version number to 5.10.1b3

  1. … 3 more files in changeset.
Always use "--" in "dom parse" when document is interpolated

This is a safety measure to make sure that the document parsed is

never confused with an option, when the document starts with a "-". In

the best case, the error message provided by "dom parse" might be

misleading. This might be a problem for user contributed documents

(passed as variables, or return values from functions).

The double dash is supported in tdom since version 0.9.0.

  1. … 18 more files in changeset.
removed the previous half finished change, the update of the timezone data helps

fix regression test to cope with time zone

Since OpenACS timezone data is now newer as in many tcl versions, some time zones

might not be available in tcl. Therefore, tcl-based conversions with these

time zones will fail.

This change skips these timezones (on my system, 2 cases). But this

is just a part of the fix. The "DB-based conversion" in "lc_time_tz_convert"

seems to be broken for these cases as well, otherwise the regression

test would not have stopped working.

Adapt test to current timezones

Extend test suite to check that also dates in the "short" time format are supported

This test will fail

Test external command line dependencies

  1. … 1 more file in changeset.
Complete coverage for the package

file lang-widget-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./lang-widget-procs.tcl
Improve test for lc_time_local_to_utc, showing that its behavior is inconsitent with respect to invalid input

Replace api outside of the package dependencies

Increase coverage

This test will currently fail because the translator mode flag is cached per thread, but the set api won't update this cache.

Increase proc coverage

Increase proc coverage

Re-load also all other enabled locales to avoid test side effects

Increase proc coverage

Wrap test in a transaction

file lang-util-procs.tcl was initially added on branch oacs-5-10.

Increase proc coverage

Improve coverage

Increase proc coverage