OpenACS / openacs-4 / packages / acs-content-repository

tcl

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 2
Total Committers: 43
Last Commit: 03 Jun
Commits this week: 2
Total Lines of Code (LoC): 10,381
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 May
3:45 pm

antoniop

Document behavior: the assumption that one can derive the filename from the api is not correct in case of copies

Options
    • -0
    • +11
    ./revision-procs.tcl
3:10 pm

antoniop

Revert https://cvs.openacs.org/changelog/OpenACS?cs=oacs-5-10%3Aantoniop%3A20240423144330

currently, file-storage will copy files by simply copying the revision entry of the new file from the original one. This means that copied files will in fact point to the same filesystem file of the original.

This "works" because the file-storage api will currently never delete a file from the filesystem, so deleting the original file will not affect the copies.

This behavior is probably not ideal, but we won't address it before the release, as to change it will most likely require some careful planning, in particular for existing installations.

Options
    • -0
    • +8
    ./revision-procs-oracle.xql
    • -0
    • +8
    ./revision-procs-postgresql.xql
    • -9
    • +14
    ./revision-procs.tcl
Tuesday 23 Apr
6:21 pm

antoniop

Prevent sneaking symlinks in the content repository

Many thanks to Thomas Rennner and Günter Ernst for analyzing the issue

Options
    • -1
    • +11
    ./content-procs.tcl
4:43 pm

antoniop

cr_write_content reform

when serving files, do not trust the content information, as the absolute path to the file can be determined programmatically in this case.

This also reduce divergency between Oracle and Postgres

Options
    • -8
    • +0
    ./revision-procs-oracle.xql
    • -8
    • +0
    ./revision-procs-postgresql.xql
    • -14
    • +9
    ./revision-procs.tcl
Monday 26 Feb
10:54 am

gustafn

deprecate unused command cr_check_orphaned_files

Options
    • -2
    • +2
    ./acs-content-repository-procs.tcl
Sunday 25 Feb
11:40 am

gustafn

Cleanup of external binaries: always use "util::which" to resolve binaries

Furthermore, this change makes the handling of "identify" consistent

with "convert". Before, the parameter "ImageMagickIdentifyBinary"

could not be modified via the parameter settings, only

"ImageMagickConvertBinary" was defined.

Bump version number to 5.10.1b3 to pick up additional parameter.

Options
    • -9
    • +9
    ./image-procs.tcl
  2. … 1 more file in changeset.
Tuesday 09 Jan
2:06 pm

antoniop

Handle differences in data-model between oracle and postgres, where oracle uses an additional filename column in the cr_revisions table when a revision points to a file

Many thanks to Josue Cardona for reporting the regression

Options
    • -3
    • +10
    ./revision-procs.tcl
Tuesday 31 Oct 2023
3:11 pm

antoniop

Increase proc coverage

Options
    • -1
    • +31
    ./test/content-revision-test-procs.tcl
1:55 pm

antoniop

Reitroduce missing query clause that should be executed when we retrieve the content of a text/* content item

Options
    • -0
    • +7
    ./content-item-procs-oracle.xql
    • -0
    • +7
    ./content-item-procs-postgresql.xql
1:55 pm

antoniop

Test that when content::item::get_content is called on a text/* mime typed content-item, an extra "text" attribute should be returned in the result array

This currently fails because of a missing query in the xql

Options
    • -1
    • +10
    ./test/content-item-test-procs.tcl
Monday 30 Oct 2023
5:57 pm

antoniop

Test content::item::get_virtual_path

This will expose a logn standing bug where the root_folder_id argument is ignored

Options
    • -1
    • +26
    ./test/content-item-test-procs.tcl
5:27 pm

antoniop

Extend test suite

Options
    • -1
    • +14
    ./test/content-item-test-procs.tcl
5:17 pm

antoniop

Test content::item::get_root_folder

Options
    • -1
    • +27
    ./test/content-item-test-procs.tcl
3:46 pm

antoniop

Remove broken line (non-existing arguments)

Options
    • -2
    • +1
    ./content-item-procs.tcl
3:45 pm

antoniop

Increase api coverage, this uncovered a bug in content::item::unpublish

Options
    • -1
    • +24
    ./test/content-item-test-procs.tcl
3:33 pm

antoniop

Test content::item::get_publish_date

Options
    • -4
    • +34
    ./test/content-item-test-procs.tcl
2:58 pm

antoniop

Extend test to include content::item::get_path

Options
    • -4
    • +27
    ./test/content-item-test-procs.tcl
2:49 pm

antoniop

Whitespace cleanup

Options
    • -3
    • +3
    ./test/content-item-test-procs.tcl
2:48 pm

antoniop

Test content::item::get_descendants

Options
    • -1
    • +115
    ./test/content-item-test-procs.tcl
Wednesday 14 Jun 2023
10:40 am

antoniop

Disable tests to check for executables on the system

Options
    • -16
    • +20
    ./test/acs-content-repository-procs.tcl
  2. … 7 more files in changeset.
Thursday 20 Apr 2023
3:34 pm

antoniop

Prefer binary from parameter as everywhere else

Options
    • -2
    • +2
    ./image-procs.tcl
3:32 pm

antoniop

Test external command line dependencies

Options
    • -1
    • +17
    ./test/acs-content-repository-procs.tcl
Monday 05 Dec 2022
12:26 pm

gustafn

fix incorrect names in .xql files

Options
    • -1
    • +1
    ./revision-procs-oracle.xql
    • -1
    • +1
    ./revision-procs-postgresql.xql
Tuesday 29 Nov 2022
5:09 pm

gustafn

Fixed missing update_content-lob.set_content

Added missing set_content SQL statement for updating revisions stored in LOBs.

This statement was already missing in the release of OpenACS 5.10.0.

LOBs are for PostgreSQL somewhat depreacted and these are just there for

legacy applications.

Options
    • -2
    • +9
    ./content-revision-procs-postgresql.xql
Sunday 27 Nov 2022
6:55 pm

gustafn

improve spelling

Options
    • -2
    • +2
    ./content-procs.tcl
  2. … 9 more files in changeset.
Thursday 24 Nov 2022
3:45 pm

gustafn

Replaced "ns_mktemp" by "ad_tmpnam" to ease code maintenance

The underlying C library API for "ns_mktemp" is deprecated

for security reasons, we will have to do something about it.

Options
    • -2
    • +2
    ./image-procs.tcl
    • -2
    • +2
    ./test/content-image-test-procs.tcl
    • -2
    • +2
    ./test/content-item-test-procs.tcl
    • -2
    • +2
    ./test/content-search-procs.tcl
  5. … 5 more files in changeset.
Monday 12 Sep 2022
5:30 pm

antoniop

Deprecate content::revision::update_attribute_index

Options
    • -3
    • +5
    ./content-revision-procs.tcl
Monday 29 Aug 2022
1:00 pm

antoniop

Deprecate template::util::array_to_vars and template::util::vars_to_array: their functionality can be easily inlined by using the array command

Options
    • -1
    • +3
    ./filter-procs.tcl
  2. … 3 more files in changeset.
Tuesday 23 Aug 2022
8:44 pm

gustafn

Properly escape "<" and ">" in api-doc documentation.

Since all documentation is rendered via HTML, the characters

"<" and ">" have to be HTML-quoted, otherwise strange things

(omission, unintended renderings) might occur.

E.g. the sentence

Define an interface between a page and an

ADP <include> similar to the page_contract.

was rendered as

Define an interface between a page and an

ADP similar to the page_contract.

which is incorrect.

Options
    • -1
    • +1
    ./publish-procs.tcl
  2. … 13 more files in changeset.
Friday 01 Apr 2022
3:57 pm

gustafn

Use security::csp::add_static_resource_header

bump version number of acs-content-repository to 5.10.1d4

Options
    • -1
    • +2
    ./revision-procs.tcl
  2. … 1 more file in changeset.