• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
merge of 4.6.3b1 to HEAD

  1. … 101 more files in changeset.
is_valid_child needs relation to determine if its a valid child. needs upgrade script

  1. … 1 more file in changeset.
Removed the vile fs_simple_objects added by OF to store URLs in file

storage despite the existence of a non-versioned URL type in the content

repository. Upgrade scripts provided. I added Tcl API to the content

repository to honor our desire to export the SQL API to Tcl client code.

1. folder contents are now counted correctly (bug fix)

2. The fs_objects view is now usable in PG (it was a UNION view before and

therefore didn't scale)

3. Code in file storage is considerably simpler now and all file storage

objects are now stored in the content repository, as they should

be.

The Oracle version may need some work I'll finish testing this afternoon.

  1. … 46 more files in changeset.
register_child_type would only register one type per parent since it

ignored relation tag when checking if the relation existed.

is_valid_type failed with more than one type since it wanted to count

max_n but did not sum.

needs an upgrade script.

  1. … 4 more files in changeset.
removed content_item.update_last_modified, use acs_object.update_last_modified instead

  1. … 3 more files in changeset.
Merged with the 4.5 branch (oacs-4-5 tag "don-merge-1")

  1. … 58 more files in changeset.
added function for updating last_modified time of a content_item with cascading

  1. … 3 more files in changeset.

Applied Michael Steigman's patches 199-201, which fixes package spec/body

mismatches allowed by Oracle 8i but not by 9i.

  1. … 4 more files in changeset.

After importing openacs.org users, forums and messages I discovered that it

took literally several minutes to load the APM's home page. This was due

to a rather stupid subselect of the form:

select count(*)

from content_revisions r

where r.revision_id = content_item.get_latest_revision(item_id)

where item_id comes from the package versions table.

It's stupid in both PG and Oracle because get_latest_revision already

joins the latest_revision_id value from cr_items with the content

revisions table thus a simple check for a null return by get_latest_revision

would be sufficient.

It's *really* stupid in Oracle because Oracle won't use the index on

revision_id when checking NULLs so we get two sequential scans of the

cr_revisions table tucked into that one itty-bitty subquery (itself called

once for each package version in ths system).

Which explains why I hadn't noticed it while working on scalability testing

in PG - PG uses the index because its btree index structure handles NULLs.

Meaning this query only fell apart at a rate of O(log2(R)) rather than O(R)

as in Oracle (R being the number of revision objects in the system).

My solution was to rewrite the subselect using "case" rather than "count(*)"

and also to speed up get_latest_revision by having it check for NULL and

return NULL immediately rather than execute the query (in PG this is

accomplished by declaring the function "isstrict", and the executor won't

even call the function if the argument's NULL, making it REALLY fast!).

  1. … 3 more files in changeset.
fixed closing of cursors after an exception

  1. … 4 more files in changeset.
fixed RI problem with oracle due to text not being an allowed storage_type

more cleanup of cms - content upload and display

  1. … 9 more files in changeset.
removed circular dependency due to workflow

  1. … 4 more files in changeset.
added support for storing content repository items in the file system

  1. … 8 more files in changeset.
restructuring directory structure for openacs porting

    • -0
    • +1682
    ./content-item.sql
  1. … 53 more files in changeset.