• last updated 17 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
have callbacks executed one level below the calling function so upvar works how you would expect in the callback

Callbacks no longer throw an error if -catch is specified with -impl and the chosen implementation that does not exist.

i am a monkey

throw error if invoking specific impl which does not exist

fix empty body contract check

some error checking for callback declaration, fix namespace eval warning, add an @see for the contract to each impl

too listy by far

Callback implmentation, see tip 79 for details

log a debug message for procs declared in a namespace eval rather than explicit namespace

change ad_verify_and_get_user_id to ad_conn user_id, change ad_maybe_redirect_for_registration to auth::require_login, make some db_ and dt_ function -public

    • -35
    • +48
    ./40-db-query-dispatcher-procs.tcl
  1. … 689 more files in changeset.
comment out db_qd_log calls as almost noone will use these anymore and some added appreciable overhead. warn when a proc does not yield a statement name with advice about why, fix the bootstrap version of acs_kernel_id to cache

    • -46
    • +46
    ./40-db-query-dispatcher-procs.tcl
  1. … 1 more file in changeset.
merge of changes between oacs-5-0-0b4 and oacs-5-0-0-final to HEAD

  1. … 285 more files in changeset.
typo -proc instead of -public, bug 1295

add -public and -private for some procs, minor bug in acs_object::get some @see notes

  1. … 11 more files in changeset.
Recognize files in lib as include_pages

when parsing a xql file fails, it seems appropriate to log this in the error log

add =t =f to boolean flags, fix docs, some cleanup on logging

fixing typo in tcl file loading printout

requiring tcl files (of type tcl_procs, tcl_init, test_procs, test_init, or tcl_util) to reside under package-key/tcl

Fixed bug #829 again, this time moved the username-defaulting logic out of ad_user_new and into auth::create_local_account

  1. … 2 more files in changeset.
bug 335 - making sure it's possible to install from .apm files again. The UI needs improvement. Robustness could also be improved. May need to handle the case when there is a later version of a package in the packages directory than in the apm_workspace dir

  1. … 6 more files in changeset.
Another bug #829-style fix

  1. … 1 more file in changeset.
Fixed bug #829: Installation fails on administrator creation.

making proc apm_bootstrap_load_libraries duplicate less of the logic in apm_load_libraries by making use of apm_get_package_files. To make this refactoring I had to move apm_backup_file_p, apm_include_file_p, and apm_ignore_file_p to 30-apm-load-procs.tcl

  1. … 1 more file in changeset.
install.xml would be loaded on install index page but no longer be in memory on package install page. Fixed by loading document again on package page. See discussion here: http://openacs.org/forums/message-view?message_id=122266

  1. … 2 more files in changeset.
Implemented much faster and simpler DB compatibility check

Decided that assuming SQL data files are CSV-formatted files is a bad idea

after running into a package that embeds comments in its data! Changed

from .csv to .dat and all that implies. Still more testing to do...

  1. … 33 more files in changeset.
Another oh-so-inevitable typo.

Oops tyop crept in.

Had to make SQL data load control files be db-specific (duh)