• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
pass authority_id to acs_user::get_by_username

auth::create_user: add parameter authority_id to enable creation of users in arbitrary authorities

Whitespace changes

Fix uncomplete test description and simplify single -procs line.

- adjust to changed results of ns_cache_stats

- add comments and warnings

    • -17
    • +32
    ./authentication-procs-naviserver.tcl
use public interface instead of private one

Harmonize parameter names in proc documentation removing unexistent ones

handle authorizations with no auth_sync_process defined without raising an error in the error.log

Remove ns_parseurl from list of tested procs, as not being a openacs proc will trigger an error at load time

Test also the portrait api (exploit the fact that we are already creating bogus users), move helper procs to the beginning so they can be found by the testing machinery

    • -28
    • +53
    ./test/acs-authentication-procs.tcl
Trim whitespace

    • -64
    • +64
    ./test/acs-authentication-procs.tcl
improve testcases by removing useless expr commands

    • -19
    • +19
    ./test/acs-authentication-procs.tcl
  1. … 16 more files in changeset.
make tested procs explicit

    • -10
    • +101
    ./test/acs-authentication-procs.tcl
  1. … 1 more file in changeset.
improve spelling

  1. … 12 more files in changeset.
Fix test on system having 0.0.0.0 as IPv4 address in the config file

Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @parameter -> @param

- @params -> @param

- Add missing @param

- @cvs -> @cvs-id

- @version -> @cvs-id

  1. … 12 more files in changeset.
Fix proc and contract doc elements, so they are properly parsed by apidoc::api_*_documentation.

- @cvs_id -> @cvs-id

- @version -> @cvs-id

- @creation_date -> @creation-date

- @date -> @creation-date

- Different variations of $Id$

- Remove wrong @param entry

- Fix typos

  1. … 367 more files in changeset.
Apply new api where appropriate

Exploit new api where appropriate

Apply new user api when appropriate

Rework of this tests

- use dict idioms instead of array, so we don't have to unset all the time

- use new user api when appropriate

- fix test when we try to reuse the username of somebody who was previously banned.

This is no longer possible and is now reflected in the test

Fix typos

  1. … 1 more file in changeset.
Fix wording

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 470 more files in changeset.
simplify weird construction

Removed extra '$'

Prefer 'lappend' to 'set ... concat' for appending elements to lists + Whitespace changes

  1. … 3 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 66 more files in changeset.
fix typos

  1. … 7 more files in changeset.
Prefer 'in' and 'ni' operators over lsearch for testing list containment