OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 9 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 09 Jun 2017
7:47 pm

antoniop

Use ad_script_abort everytime one issues ad_return_complaint, or subsequent errors will trigger without the user noticing

Options
    • -0
    • +1
    /openacs-4/packages/chat/www/chat-transcripts.tcl
    • -0
    • +1
    /openacs-4/packages/chat/www/html-chat.tcl
    • -2
    • +3
    /openacs-4/packages/chat/www/message-delete-2.tcl
    • -1
    • +2
    /openacs-4/packages/chat/www/room-delete-2.tcl
    • -0
    • +1
    /openacs-4/packages/chat/www/transcript-delete-2.tcl
    • -1
    • +2
    /openacs-4/packages/chat/www/transcript-edit.tcl
4:33 pm

antoniop

Prevent user from triggering db error by entering too big subjects

Options
    • -2
    • +14
    /openacs-4/packages/forums/lib/message/post.tcl
3:40 pm

antoniop

simplify idiom

Options
    • -2
    • +2
    /openacs-4/packages/acs-authentication/tcl/local-procs.tcl
2:07 pm

antoniop

Fix cases of this portlet being called on trees without categories.

Modernize list assign idioms

Options
    • -4
    • +7
    /openacs-4/packages/xowiki/www/prototypes/categories-portlet.page
9:11 am

gustafn

fix broken links

Options
    • -6
    • +14
    /openacs-4/packages/bookmarks/www/doc/index.html
Thursday 08 Jun 2017
8:15 pm

antoniop

Port some improvements from Learn@WU codebase:

- check whether chat room exists exploits cache

- chat room retrieval enriches with some acs_objects metadata

Fix potential errors when we try entering a chat room that has been deleted and check for its activity status

Options
    • -11
    • +43
    /openacs-4/packages/chat/tcl/chat-procs.tcl
6:42 pm

antoniop

- Introduce new proc ad_sanitize_filename implementing current best practices for ensuring a valid filename on most filesystems.

- Use it in every place where filename sanitization is performed in the code and deprecate fs::remove_special_file_system_characters.

TODO deprecate also util_text_to_html? Use case of sanitizing urls and filenames might have different requirements.

Options
    • -3
    • +5
    /openacs-4/packages/acs-content-repository/tcl/content-item-procs.tcl
    • -1
    • +115
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -1
    • +0
    /openacs-4/packages/file-storage/lib/folder-links.tcl
    • -8
    • +24
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
    • -3
    • +1
    /openacs-4/packages/file-storage/www/folder-chunk.tcl
    • -2
    • +5
    /openacs-4/packages/file-storage/www/folder-create.tcl
Wednesday 07 Jun 2017
10:44 am

gustafn

fix broken links

Options
    • -4
    • +4
    /openacs-4/packages/ajaxhelper/www/doc/index.adp
    • -4
    • +4
    /openacs-4/packages/ajaxhelper/www/doc/index.html
10:35 am

gustafn

Fix broken link

Options
    • -1
    • +1
    /openacs-4/packages/ajaxhelper/www/doc/index.adp
    • -1
    • +1
    /openacs-4/packages/ajaxhelper/www/doc/index.html
10:11 am

gustafn

Fix broken link

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/www/doc/tutorial.adp
    • -1
    • +1
    /openacs-4/packages/acs-content-repository/www/doc/tutorial.html
Tuesday 06 Jun 2017
5:01 pm

antoniop

Make sure message exists when dealing with a banned user

Options
    • -2
    • +3
    /openacs-4/packages/acs-subsite/lib/login.tcl
Saturday 03 Jun 2017
2:17 pm

gustafn

Deal with Mauricio's NaviServer modification (fixes issue #3319)

Options
    • -6
    • +1
    /openacs-4/packages/acs-bootstrap-installer/installer.tcl
Friday 02 Jun 2017
1:23 pm

gustafn

fix broken links

Options
    • -5
    • +5
    /openacs-4/packages/tsearch2-driver/www/doc/index.adp
    • -2
    • +2
    /openacs-4/packages/tsearch2-driver/www/doc/index.html
1:12 pm

gustafn

Update documentation (e.g. fix broken links)

Options
    • -3
    • +3
    /openacs-4/packages/acs-core-docs/www/aolserver.adp
    • -2
    • +2
    /openacs-4/packages/acs-core-docs/www/aolserver.html
    • -8
    • +8
    /openacs-4/packages/acs-core-docs/www/aolserver4.adp
    • -7
    • +7
    /openacs-4/packages/acs-core-docs/www/aolserver4.html
    • -0
    • +0
    /openacs-4/packages/acs-core-docs/www/automated-testing-best-practices.html
    • -3
    • +3
    /openacs-4/packages/acs-core-docs/www/backup-recovery.adp
    • -2
    • +2
    /openacs-4/packages/acs-core-docs/www/backup-recovery.html
    • -0
    • +0
    /openacs-4/packages/acs-core-docs/www/bootstrap-acs.html
    • -1
    • +1
    /openacs-4/packages/acs-core-docs/www/configuring-configuring-packages.adp
    • -1
    • +1
    /openacs-4/packages/acs-core-docs/www/configuring-configuring-packages.html
    • -1
    • +1
    /openacs-4/packages/acs-core-docs/www/configuring-configuring-permissions.adp
    • -1
    • +1
    /openacs-4/packages/acs-core-docs/www/configuring-configuring-permissions.html
    • -1
    • +1
    /openacs-4/packages/acs-core-docs/www/configuring-install-packages.adp
    • -1
    • +1
    /openacs-4/packages/acs-core-docs/www/configuring-install-packages.html
    • -1
    • +1
    /openacs-4/packages/acs-core-docs/www/configuring-mounting-packages.adp
  16. … 133 more files in changeset.
Thursday 01 Jun 2017
11:50 am

gustafn

- make policy3 more consistent and better usable with workflows

Options
    • -9
    • +16
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
11:42 am

gustafn

Ease debugging of policyies and streamline check_permissions with enforce_permissions

Options
    • -9
    • +9
    /openacs-4/packages/xotcl-core/tcl/policy-procs.tcl
Wednesday 31 May 2017
3:47 pm

michaela

Return an error if dependency is missing.

This happens if the (info file of the) required package is not present.

This solution is a bit dirty, but better than throwing the tcl error

"no such variable: spec_file"

Options
    • -1
    • +4
    /openacs-4/packages/acs-admin/www/apm/packages-install-2.tcl
2:47 pm

michaela

Add another constraint name variant as it existed in our production system

Options
    • -1
    • +3
    /openacs-4/packages/faq/sql/postgresql/upgrade/upgrade-5.9.0-5.9.1d1.sql
2:29 pm

michaela

Fix constraint name

Options
    • -1
    • +1
    /openacs-4/packages/new-portal/sql/postgresql/upgrade/upgrade-2.9.0-2.9.1d1.sql
1:48 pm

gustafn

Provide more infrastructure support for host-node-maps for more flexible domain handling

- add optional -cookie_domain parameter to the following functions

ad_user_login

ad_user_logout

sec_generate_session_id_cookie

auth::issue_login (wrapper for ad_user_login)

if not specified, the functions are full backward compatible

- add optional parameter -host_node_id to auth::authenticate

which refers to the node_id in the host-node-map

- pass host_node_id from from/to register pages

TODO:

1) probably, sec_generate_session_id_cookie picks up the wrong

session_id via [ad_conn session_id]

2) check interaction with CookieDomain (probably, we need

must not pass host_node_id wheren CookieDomain is non-empty)

Options
    • -6
    • +31
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-authentication/tcl/password-procs.tcl
    • -11
    • +12
    /openacs-4/packages/acs-subsite/lib/login.tcl
    • -1
    • +7
    /openacs-4/packages/acs-subsite/www/register/index.adp
    • -1
    • +3
    /openacs-4/packages/acs-subsite/www/register/index.tcl
    • -29
    • +48
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -1
    • +6
    /openacs-4/packages/acs-tcl/tcl/tcltrace-init.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/tcltrace-procs.tcl
11:56 am

antoniop

Update construct to reload a page, as previous one was not working properly at least on Chrome and Explorer

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/bootstrap-procs.tcl
11:48 am

gustafn

- add optional parameter host_node_id (for future use)

- Reflow overlong lines

Options
    • -11
    • +35
    /openacs-4/packages/acs-subsite/lib/login.tcl
Tuesday 30 May 2017
11:05 pm

gustafn

- fix bug for obtaining logout_url on host-node mapped subsites

- factor out security::get_register_subsite to streamline behavior of ad_get_login_url and ad_get_logout_url

Options
    • -40
    • +45
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
7:16 pm

antoniop

Improve UI for Hostnode map so it is feasible on sites with many nodes to show navigate the site structure

Options
    • -5
    • +16
    /openacs-4/packages/acs-subsite/www/admin/host-node-map/index.tcl
4:30 pm

gustafn

Modernize code (use ad_include_contract instead of manual checks)

Options
    • -35
    • +23
    /openacs-4/packages/acs-subsite/lib/login.tcl
4:29 pm

gustafn

Flush cache sntries, when host-node-map is updated

Options
    • -1
    • +4
    /openacs-4/packages/acs-subsite/www/admin/host-node-map/index.tcl
2:00 pm

antoniop

Fix typo

Options
    • -1
    • +1
    /openacs-4/packages/file-storage/www/folder-delete.adp
1:58 pm

antoniop

Check if we have already a folder with same name before inserting, or we get error in the logs.

Remove small duplication

Options
    • -8
    • +15
    /openacs-4/packages/file-storage/www/folder-create.tcl
12:36 pm

trenner

prevent bots to generate errors with old buggy urls from their indices

Options
    • -14
    • +22
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
9:55 am

gustafn

never offer items with publish-status "production"; should be probably parameterized in the future

Options
    • -1
    • +2
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl