• last updated 12 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
reduced verbosity

fixed resource leaks

dom trees were not deleted

avoided duplicated loading of procs

moved functionality to automated testing

Added automated testing for resource leaks

- new API function "aa_check_leftovers": This function is typically

called automatically at the end of every test case in

"aa_run_testcase" but it also makes sense to call it manually in

between of test cases.

- set aa_test_end to private (see no reason why this was public)

- bumped to 5.10.1b2

fixed leaked dom trees

Make localurl filter more robust to invalid URLs: fail validation in this case, intead of crashing

fixed resource leaks

dom trees were not deleted

ad_dom_sanitize_html: fixed 2 resource leaks

in case of parsing errors in the input string the following structures leaked:

- dom tree

- stuct::tree

make sure to delete tdom document

Delete nodes explicitly, otherwise it survives the end of the proc.

Removed memory leaks in the regression test

- new function ::xo::aa_check_leftovers to detect leaks a soon as possible

- made ::xo::stats better reusable by returning a dict

- extended regression test

- bumped xotcl-core to 5.10.1b5

file zz-final-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    /openacs-4/packages/xotcl-core/tcl/test/zz-final-procs.tcl
Removed warning during startup

Removed reason for protentially confusing warning during startup

Warning: nsf: method <::nx::Class> <-per-object> <init> does not exist

reduced verbosity

improved variable naming

Fixed variable names for SQL functions to allow to call these directly from Tcl

---

--- Fix SQL function that were defined with the same number of

--- arguments and the same argument names, but receiving different

--- types (integers vs. timespans). This is fine, as long the

--- functions are only called from SQL and positional arguments. When

--- calling from Tcl, this does not work.

---

--- This change uses in cases, where offsets are specified as

--- intervals the suffix "_interval" for the variable names, keeping

--- the names without this suffix for integer arguments (for Oracle

--- compatibility).

file upgrade-0.6.2d7-0.6.2d8.sql was initially added on branch oacs-5-10.

fixed icanuse-test for deleting samesite cookies

Drop view before its dependency sequence

Officially deprecate old alias

Replace deprecated api

Whitespace changes

fixed bug causing regression test to fail sometimes

The test did not perform a proper cleanup, leaving tmp-objects around

reduced verbosity

    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
reduced number of warnings during startup

Previously, we had warning of the form

Warning: Multiple definition of _xowf__i_xowf_require_test_instance ....

due to the "init_class" of the test cases.

The problem was solved by defining an explicit class for such cases.

increased test coverage to >72%

More resource-info updates:

- fixed wrong and inconsistent naming of dict members (many thanks to Sebastian Scheder for figuring this out)

- removed duplicated slashes in resource paths

- fixed incorrect paths when CDN is used

- simplified handling of cspMaps

- added test checking consistency of resource-info dicts

file resource-info-procs.tcl was initially added on branch oacs-5-10.

sort URN listing

added indirectly covered procs