OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 10
Total Committers: 145
Last Commit:
Commits this week: 10
Total Lines of Code (LoC): 6,863,555
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 11 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 24 May
11:28 am

gustafn

improve listing of properties of NX classes

Options
    • -7
    • +1
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
Tuesday 23 May
2:36 pm

gustafn

refactor login cookie handling

The old code required repeated execption handlers.

Now, these exception handlers are on one place, and

users of sec_login_read_cookie can rely that a dict

is returned

Options
    • -97
    • +81
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
2:19 pm

gustafn

minor cleanup

Options
    • -4
    • +2
    /openacs-4/packages/acs-subsite/lib/applications.tcl
Friday 19 May
8:31 pm

gustafn

use in the configuration file more consistent names

All OpenACS package con be configured via the path

ns/server/[ns_info server]/acs/PACKAGE_NAME, so use as well

this nameing convention for the OAuth parameters.

Examples are:

ns_section ns/server/$server/acs/oauth/ms {

#

# Defaults for client ID and secret for the app (administrative

# agent) "ms::app" and the external identity provider for azure,

# which might be created via

#

# ::ms::Graph create ::ms::app

# ::ms::Authorize create ::ms::azure

#

ns_param client_id "..."

ns_param client_secret "..."

ns_param tenant "..."

ns_param version "v1.0"

}

ns_section ns/server/$server/acs/oauth/github {

#

# Defaults for client ID and secret for the the external identity

# provider github, which might be created via

#

# ::xo::oauth::GitHub create ::xo::oauth::github

#

ns_param client_id "..."

ns_param client_secret "..."

}

Options
    • -10
    • +32
    /openacs-4/packages/xooauth/tcl/rest-procs.tcl
8:27 pm

gustafn

use consistently the term "return_url"

Options
    • -3
    • +3
    /openacs-4/packages/xooauth/tcl/authorize-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xooauth/tcl/ms-procs.tcl
7:46 pm

gustafn

fix for short-text-questions

for short-text-questions, correct when is empty (an empty

list) when multiple subquestions exists. The old code

did not handle this case and checked just for the existance

of the variable.

many thanks to markus moser for the fix.

Options
    • -8
    • +15
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
2:14 pm

gustafn

added exception handler for sec_login_get_external_registry

This is necessary for cases, where no login cookie exists

Options
    • -7
    • +13
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
2:13 pm

gustafn

call directly ns_getform

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
Thursday 18 May
3:42 pm

gustafn

relax date check slightly

Options
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/weblog-procs.tcl
Wednesday 17 May
11:09 am

trenner

room_id is required

Options
    • -2
    • +2
    /openacs-4/packages/chat/www/chat.tcl
Tuesday 16 May
11:23 am

trenner

fix typo

Options
    • -1
    • +1
    /openacs-4/packages/xooauth/www/azure-login-handler.tcl
Monday 15 May
12:47 pm

trenner

improve input validation

Options
    • -4
    • +4
    /openacs-4/packages/xowiki/www/admin/set-publish-state.tcl
1:14 am

gustafn

revert escaped changes

Options
    • -12
    • +10
    /openacs-4/packages/acs-tcl/tcl/acs-cache-init.tcl
    • -18
    • +0
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
    • -9
    • +7
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
1:08 am

gustafn

don't assume, the oauth package is installed

Options
    • -10
    • +12
    /openacs-4/packages/acs-tcl/tcl/acs-cache-init.tcl
    • -0
    • +18
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
    • -7
    • +9
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
    • -14
    • +16
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
12:18 am

gustafn

External identity provider reform (part 3)

- logout from external identity provider, if logged in via it

- extend default login page via ADP include, when external

identity providers are configured.

Options
    • -3
    • +3
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • -0
    • +11
    /openacs-4/packages/acs-subsite/lib/external-logins.adp
    • -0
    • +21
    /openacs-4/packages/acs-subsite/lib/external-logins.tcl
    • -0
    • +1
    /openacs-4/packages/acs-subsite/lib/login.adp
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -2
    • +53
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
12:18 am

gustafn

file external-logins.adp was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-subsite/lib/external-logins.adp
12:18 am

gustafn

file external-logins.tcl was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-subsite/lib/external-logins.tcl
12:02 am

gustafn

whitespace changes

Options
    • -4
    • +5
    /openacs-4/packages/acs-subsite/www/register/logout.tcl
12:01 am

gustafn

simplify code

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/lib/user-subsites.tcl
Sunday 14 May
1:09 pm

gustafn

External identity provider reform (part 2)

Use the external identity provider for refresh of logins. When a user

is logged in via an external identity provider, use the same identity

provider for a refresh when it expires. The expiration time is

controlled via the classical OpenACS parameters.

Note that in general, the same user might be authenticated via a

classical OpenACS authority (e.g. local authority) and/or via an

external one (e.g. Microsoft Identity Platform (Azure) or GitHub).

For single-sign-ons, when the token is still valid, the redirect to

the external identity provider does not mean necessarily that the use

is shown the external identity provider's login page.

Options
    • -2
    • +3
    /openacs-4/packages/acs-authentication/acs-authentication.info
    • -14
    • +34
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -21
    • +76
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
Friday 12 May
8:16 pm

gustafn

intensify validation of form variables

Options
    • -4
    • +4
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -7
    • +7
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
8:13 pm

gustafn

Fixed markup for Navbar for Bootstrap 3 and /5

Many thanks to Monika Andergassen for the contribution

Options
    • -53
    • +56
    /openacs-4/packages/xowiki/tcl/bootstrap-procs.tcl
7:53 pm

gustafn

minor cleanup

Options
    • -3
    • +9
    /openacs-4/packages/bootstrap-icons/tcl/resource-init.tcl
7:50 pm

gustafn

version maintenance

- the upstream version of the bootstrap fonts changed to 1.10.5

- the location of the CSS file in the distribution zip file has changed with version 1.10.4

- bump package version number to 0.2d6

Options
    • -2
    • +2
    /openacs-4/packages/bootstrap-icons/bootstrap-icons.info
    • -2
    • +7
    /openacs-4/packages/bootstrap-icons/tcl/resource-init.tcl
    • -3
    • +3
    /openacs-4/packages/bootstrap-icons/tcl/resource-procs.tcl
8:36 am

trenner

validate item_type

Options
    • -1
    • +10
    /openacs-4/packages/xowf/lib/edit-interaction.wf
8:32 am

trenner

define item_type for code_interaction

Options
    • -0
    • +1
    /openacs-4/packages/xowf-monaco-plugin/tcl/test-item-procs.tcl
Thursday 11 May
7:25 pm

gustafn

Record the fact that a certain user_id was created via an OAuth identity provider.

Options
    • -1
    • +1
    /openacs-4/packages/xooauth/xooauth.info
    • -8
    • +30
    /openacs-4/packages/xooauth/tcl/authorize-procs.tcl
6:43 pm

gustafn

use oauth state to transport a nonce and a return_url

Options
    • -8
    • +23
    /openacs-4/packages/xooauth/tcl/authorize-procs.tcl
    • -5
    • +6
    /openacs-4/packages/xooauth/tcl/ms-procs.tcl
    • -10
    • +12
    /openacs-4/packages/xooauth/www/azure-login-handler.tcl
    • -19
    • +24
    /openacs-4/packages/xooauth/www/github-login-handler.tcl
6:42 pm

gustafn

fix typo

Options
    • -1
    • +1
    /openacs-4/packages/xooauth/www/admin/lti-test.tcl
Wednesday 10 May
9:02 am

trenner

fix typo

Options
    • -2
    • +2
    /openacs-4/packages/xooauth/tcl/authorize-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xooauth/tcl/ms-procs.tcl