OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 27 Nov 2022
11:52 am

gustafn

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

Options
    • -5
    • +3
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
    • -5
    • +3
    /openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl
    • -2
    • +1
    /openacs-4/packages/file-storage/tcl/test/webtest-procs.tcl
    • -2
    • +1
    /openacs-4/packages/file-storage/www/download-zip.tcl
    • -5
    • +3
    /openacs-4/packages/file-storage/www/file-add.tcl
    • -3
    • +2
    /openacs-4/packages/file-storage/www/folder-zip-add.tcl
    • -2
    • +1
    /openacs-4/packages/oacs-dav/tcl/tDAV-procs.tcl
Saturday 26 Nov 2022
6:00 pm

gustafn

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -7
    • +10
    /openacs-4/packages/xotcl-core/www/show-class-graph.tcl
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -2
    • +4
    /openacs-4/packages/xowf/tcl/test/test-item-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -3
    • +2
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
5:53 pm

gustafn

Moved the experimental disk-cache from utilities to the other cacheing infrastructure

Options
    • -0
    • +76
    /openacs-4/packages/acs-tcl/tcl/acs-cache-procs.tcl
5:50 pm

gustafn

fix bug, when Tcl's file command uses uplevel

This change fixes a bug whem "ad_file tmpfile filename ..." is used.

The output variable "filename" was created on the wrong calling level.

Options
    • -2
    • +2
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
5:47 pm

gustafn

Make use of new API "ad_mktmpdir" and "ad_opentmpfile" instead of "ad_tmpnam"

Options
    • -3
    • +2
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/http-client-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/test/application-data-link-procs.tcl
    • -5
    • +7
    /openacs-4/packages/acs-tcl/tcl/test/community-core-test-procs.tcl
    • -15
    • +19
    /openacs-4/packages/acs-tcl/tcl/test/http-client-procs.tcl
    • -32
    • +37
    /openacs-4/packages/acs-tcl/tcl/test/security-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-templating/tcl/test/data-procs.tcl
5:46 pm

gustafn

New API "ad_mktmpdir" and "ad_opentmpfile"

Since "ns_mktemp" is deprecated (on the C level) and is prone

to vulnerabilities. This effects as well "ad_tmpnam" in OpenACS,

which uses "ns_mktemp".

Newer C-compilers complain about this more loudly:

Due to security concerns inherent in the design of mktemp(3),

it is highly recommended that you use mkstemp(3) instead.

The security concern is that when ns_mktemp() is used to generate a

(unique) file name, which is used for opening a file, an attacker can

intercept the running binary and sneak in a different file. Although

ns_mktemp() guarantees to return a unique file name, there is no

mechanism to prevent another process or an attacker from creating a

file with the same name before the application attempts to open it.

The problem with using mkstemp() instead is that it has different

semantics, since it returns the open file. So one cannot blindly

replace these calls, but it requires some refactoring. Unfortunately,

this also effects application code, since NaviServer offers

"ns_mktemp" on the Tcl level.

To make it short: one has to separate out different use_cases of

"ad_tmpnam":

(a) use it to obtain a name for creating a file, which is subsequently opened

(b) use it to obtain a name for creating a directory

(c) use it as a name, providing name as a unique name to some external programs.

Case (a) is similar to the "mkstemp(3)" recommendation above. For this

usage scenario, the call "file tmpfile..." in Tcl 8.6 can be used (but

it should also respect the configured tmp directory. This function

is also very similar to "ns_opentempdir" in NaviServer, which uses

as well "file tmpfile". Therefore, we have created a new API call

"ad_opentmpdir ..." which respects the OpenACS settings.

Case (b) can be addressed by "file tempdir" in Tcl 8.7, or by a function

in tcllib. The new API function "ad_mktmpdir" provides respects the

OpenACS settings, and works for Tcl 8.6 or newer.

Case (c) is somewhat different, since it just wants to create a unique name. This case has not received a special API so far

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -65
    • +42
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Friday 25 Nov 2022
8:17 pm

gustafn

switch from png files for dot to inlne svg

This helps to avoid writing the .png files to some directory, which has

to be accessible

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-form-field-procs.tcl
    • -24
    • +27
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
2:07 pm

gustafn

Bugfix: Get database name from postgres connection string keywords

The connection string can be provided for libpq either as the plain

dbname (old style) or as a list of keywords (new style).

In the latter case, the full keyword string was returned

instead of the dbname.

Options
    • -7
    • +25
    /openacs-4/packages/acs-tcl/tcl/01-database-procs.tcl
1:20 pm

gustafn

fixed typo (many thanks to Franz Penz for spotting this)

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
Thursday 24 Nov 2022
8:26 pm

gustafn

include request start in long-call listing

Options
    • -6
    • +10
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
    • -0
    • +1
    /openacs-4/packages/xotcl-request-monitor/www/long-calls.adp
    • -9
    • +19
    /openacs-4/packages/xotcl-request-monitor/www/long-calls.tcl
3:45 pm

gustafn

Replaced "ns_mktemp" by "ad_tmpnam" to ease code maintenance

The underlying C library API for "ns_mktemp" is deprecated

for security reasons, we will have to do something about it.

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/image-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/test/content-image-test-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/test/content-item-test-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/test/content-search-procs.tcl
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/test/application-data-link-procs.tcl
    • -5
    • +5
    /openacs-4/packages/assessment/tcl/test/as-assessment-procs.tcl
    • -2
    • +2
    /openacs-4/packages/assessment/tcl/test/as-item-procs.tcl
    • -2
    • +2
    /openacs-4/packages/assessment/tcl/test/twt-procs.tcl
    • -2
    • +2
    /openacs-4/packages/dotlrn-fs/tcl/test/dotlrn-fs-procs.tcl
3:37 pm

gustafn

bump version numbers and add version check URLs

Options
    • -3
    • +5
    /openacs-4/packages/bootstrap-icons/tcl/resource-procs.tcl
    • -5
    • +5
    /openacs-4/packages/fa-icons/tcl/resource-procs.tcl
    • -4
    • +6
    /openacs-4/packages/openacs-bootstrap5-theme/tcl/resource-procs.tcl
    • -2
    • +4
    /openacs-4/packages/richtext-ckeditor4/tcl/richtext-procs.tcl
3:11 pm

gustafn

added versionCheckURL

Options
    • -2
    • +2
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
    • -1
    • +0
    /openacs-4/packages/highcharts/www/sitewide-admin/index.adp
3:10 pm

gustafn

Added link for version check when configured

Options
    • -0
    • +2
    /openacs-4/packages/acs-tcl/lib/check-installed.adp
    • -0
    • +3
    /openacs-4/packages/acs-tcl/lib/check-installed.tcl
2:58 pm

gustafn

bump version of the highcharts upstream package to 10.3.1

Options
    • -3
    • +5
    /openacs-4/packages/highcharts/tcl/resource-procs.tcl
    • -0
    • +1
    /openacs-4/packages/highcharts/www/sitewide-admin/index.adp
2:36 pm

gustafn

minor updates

most significant changes:

- longer lines kept for long-calls

- adapted size of buffer for long-call analysis

Options
    • -4
    • +4
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xotcl-request-monitor/www/active-communities.tcl
    • -3
    • +3
    /openacs-4/packages/xotcl-request-monitor/www/long-calls.adp
1:44 pm

gustafn

document right changes on new installs for api-doc

Options
    • -1
    • +4
    /openacs-4/packages/acs-tcl/tcl/apm-install-procs.tcl
10:44 am

antoniop

This is in fact an include and not a standalone page

Options
    • -1
    • +1
    /openacs-4/packages/acs-subsite/www/admin/group-types/groups-list.tcl
Wednesday 23 Nov 2022
11:56 pm

raulr

improve Oracle compatibility

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/www/admin/message-list.xql
8:45 am

gustafn

make behavior more robust when (erronously) called without a connection

without handling no-connection, the error message is swallowed

Options
    • -2
    • +6
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
Monday 21 Nov 2022
8:46 pm

gustafn

Fix for updating the time window via configuration dialog

In cases, where no student submissions exists, updating the time

window via the configuration dialog was ignored.

Many thanks to Thomas Renner for finding the cause and providing a fix.

Options
    • -1
    • +15
    /openacs-4/packages/xowf/lib/inclass-exam.wf
8:41 pm

gustafn

made time_window_setup public for saving the values from the configuration dialog

Options
    • -1
    • +7
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
10:47 am

gustafn

Improved appearance in TRN mode

- don't set "alt" attribute in classic mode by default to the title.

The title is often be provided as a message key, using it twice

causes two edit controls

- in acs-lang, the extra setting of link_html, which provided

the title attribute can be omitted, since adp:icon renders this

by itself.

Options
    • -3
    • +1
    /openacs-4/packages/acs-lang/www/admin/index.tcl
    • -1
    • +9
    /openacs-4/packages/acs-templating/tcl/style-procs.tcl
Sunday 20 Nov 2022
11:58 am

gustafn

beautify TRN mode in developer support

in essence, this change switches from CSS icons to <adp:icon>

since in default setup (when no themes/icon sets are installed)

the CSS based rendering was bad. Using <adp:icon> offers

more flexibility and tailorability.

Options
    • -7
    • +11
    /openacs-4/packages/acs-templating/tcl/acs-integration-procs.tcl
    • -9
    • +9
    /openacs-4/packages/openacs-bootstrap3-theme/www/resources/css/main.css
    • -9
    • +11
    /openacs-4/packages/openacs-bootstrap5-theme/www/resources/css/main.css
    • -10
    • +9
    /openacs-4/packages/openacs-default-theme/www/resources/styles/default-master.css
11:54 am

gustafn

fix wrong icon in "classic" mode (using images)

Options
    • -1
    • +1
    /openacs-4/packages/acs-templating/tcl/style-procs.tcl
5:38 am

raulr

improve Oracle compatibility

Options
    • -0
    • +32
    /openacs-4/packages/acs-subsite/www/admin/group-types/one-postgresql.xql
    • -0
    • +32
    /openacs-4/packages/acs-subsite/www/admin/group-types/one-oracle.xql
    • -25
    • +3
    /openacs-4/packages/acs-subsite/www/admin/group-types/one.tcl
4:39 am

raulr

improve Oracle compatibility

Options
    • -0
    • +41
    /openacs-4/packages/acs-subsite/www/admin/group-types/index-oracle.xql
4:26 am

raulr

improve Oracle compatibility

Options
    • -5
    • +5
    /openacs-4/packages/acs-subsite/www/admin/groups/elements-by-rel-type.tcl
Thursday 17 Nov 2022
7:48 am

gustafn

fix setting of dict value in error cases

Options
    • -2
    • +1
    /openacs-4/packages/boomerang/tcl/boomerang-procs.tcl
4:48 am

raulr

improve Oracle compatibility

Options
    • -4
    • +8
    /openacs-4/packages/acs-lang/www/admin/index.xql
    • -2
    • +1
    /openacs-4/packages/acs-subsite/www/admin/themes/index.xql