OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 19
Total Committers: 146
Last Commit: 13:32
Commits this week: 19
Total Lines of Code (LoC): 7,561,347
Net change in LoC this week: 0

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 1 hour ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 23 Apr 2021
3:57 pm

antoniop

Improve fix:

in FormPage www-edit, just after the save_data operation we render the FormPage to refresh the references. We should flush the form object cache here, as otherwise any formfield spec will come from the form in the previous state

Options
    • -5
    • +7
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
11:39 am

antoniop

Reinstate oacs-dav as a dependency... there is api usage that is not so easy to replace at the moment

Options
    • -3
    • +4
    /openacs-4/packages/file-storage/file-storage.info
11:01 am

gernst

Remove non-functional "double click protection" in order to remove a potential attack vector

Options
    • -14
    • +0
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
    • -16
    • +1
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
Thursday 22 Apr 2021
8:50 pm

gustafn

added page contract filter "printable" to avoid potential DB errors on certain binary values

Options
    • -3
    • +3
    /openacs-4/packages/search/search.info
    • -4
    • +6
    /openacs-4/packages/search/www/search.tcl
8:47 pm

gustafn

added page contract filter "printable" to avoid passing of binary values to certain pages

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -1
    • +20
    /openacs-4/packages/acs-tcl/tcl/tcl-documentation-procs.tcl
    • -12
    • +26
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
2:37 pm

gustafn

avoid site-map lookups from the DB when the connections is already closed. This avoids hard DB-errors when the URL contains invalid characters

Options
    • -6
    • +12
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
10:10 am

gustafn

fixed bug introduced 8 months ago

Options
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/index.tcl
Wednesday 21 Apr 2021
1:03 pm

antoniop

Fix test category, add tested api

Options
    • -2
    • +3
    /openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl
1:01 pm

antoniop

Make sure that the form object is flushed whenever state might have changed

If code executed after the state change accesses the form object again, this could be that from a previous state and e.g. hold the wrong form definition. This happens in practice downstream, where the submitting of activities also involves accessing the form definition to e.g. compute the grade based on the questions. Downstream we also cache the formfield specs, so if a spec is dependent on the state, might be wrong in also for future requests.

Options
    • -0
    • +5
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
11:29 am

gustafn

improve robustness when called without connection

Options
    • -5
    • +7
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
Tuesday 20 Apr 2021
1:42 pm

antoniop

Fix typo, write a basic test for the involved api

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/tcl/content-revision-procs.tcl
    • -1
    • +43
    /openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl
1:36 pm

gustafn

provide a friendly error message

Options
    • -7
    • +12
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
1:22 pm

gustafn

allow at most 50K days, otherwise Tcl time scanner bails out

Options
    • -2
    • +4
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
1:18 pm

gustafn

strengthen regular expression for "days"; valid arguments are e.g. "20d" or "14days"

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
1:08 pm

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
12:01 pm

gustafn

revert incompatible change

Options
    • -5
    • +4
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
11:37 am

antoniop

Sanitize bogus URLs such as "//" or e.g. dotlrn URL lookup would fail

Not clear if this should happen already at the ns_conn level or somewhere in the site_node api

Options
    • -3
    • +7
    /openacs-4/packages/xotcl-request-monitor/tcl/throttle_mod-procs.tcl
11:35 am

gustafn

avoid subst in export_vars by using xo::update_query

Options
    • -6
    • +3
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
    • -7
    • +10
    /openacs-4/packages/xotcl-core/tcl/context-procs.tcl
11:20 am

antoniop

Accept only integers as value for the rss query parameter

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
10:56 am

gustafn

provide page-contract error instead of backtrace

Options
    • -4
    • +3
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
Monday 19 Apr 2021
7:08 pm

gustafn

removed obsolete index.vuh file

Options
    • -29
    • +0
    /openacs-4/packages/xooauth/www/index.vuh
7:07 pm

gustafn

removed automounting

Options
    • -1
    • +0
    /openacs-4/packages/xooauth/xooauth.info
7:07 pm

gustafn

added KTI 1.1 properties

Options
    • -0
    • +8
    /openacs-4/packages/xooauth/tcl/lti-procs.tcl
3:41 pm

antoniop

Cleanup leftover file

Options
    • -9
    • +0
    /openacs-4/packages/notifications/www/unsubscribe.xql
3:36 pm

antoniop

Remove attack surface

Options
    • -19
    • +0
    /openacs-4/packages/notifications/www/test-cleanup.tcl
    • -1
    • +0
    /openacs-4/packages/notifications/www/test.adp
    • -28
    • +0
    /openacs-4/packages/notifications/www/test.tcl
3:31 pm

antoniop

Check permissions when one accesses the script and also when one performs the actual unsubscribing operation

Options
    • -6
    • +10
    /openacs-4/packages/notifications/www/unsubscribe.tcl
3:19 pm

antoniop

Harden safety: require login, do not let people outside the requester fiddle with the frequency

Options
    • -4
    • +11
    /openacs-4/packages/notifications/www/request-change-frequency.tcl
3:01 pm

antoniop

Make oacs-dav only a weak dependency for file-storage, if the package is not there, just treat it as if the parameter was disabled

Options
    • -4
    • +3
    /openacs-4/packages/file-storage/file-storage.info
    • -2
    • +13
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
    • -2
    • +2
    /openacs-4/packages/file-storage/www/index.tcl
2:58 pm

antoniop

Fix typo

Options
    • -2
    • +2
    /openacs-4/packages/acs-service-contract/tcl/contract-procs.tcl
2:05 pm

antoniop

Disable vuh, add remarks

Options
    • -0
    • +5
    /openacs-4/packages/xooauth/www/index.vuh