OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 8 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 31 Jan 2019
6:07 pm

hectorr

Remove backtick from the list of characters to be replaced by 'ad_sanitize_filename', as 'util::zip' deals with them properly now

Options
    • -4
    • +4
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
6:02 pm

hectorr

util::zip reform.

+ Use '::zipfile::mkzip', introduced in tcllib 1.18, if available.

+ For unix-like systems, with older tcllib versions, bash was used for changing directories. This method was problematic when using certain characters for the filenames, such as backticks, for example. In order to avoid this and properly quote everything, we use tclsh instead, in a convoluted and funny way (thanks to Nathan Coulter for the hack).

+ TODO: test this method also on windows, and unify the legacy implementations if it works.

Options
    • -20
    • +73
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
3:33 pm

antoniop

Remove unwanted change

Options
    • -2
    • +1
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
3:32 pm

antoniop

Reflect changes in util__table_column_exists in tcl api and make xotcl-core dependant on latest acs-kernel

Options
    • -3
    • +3
    /openacs-4/packages/xotcl-core/xotcl-core.info
    • -3
    • +4
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
2:21 pm

antoniop

Drop function first, as name of parameters changed

Options
    • -0
    • +1
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.0d10-5.10.0d11.sql
12:42 pm

antoniop

Don't rely on the delete trigger being named consistently on different installations

Options
    • -1
    • +15
    /openacs-4/packages/faq/sql/postgresql/upgrade/upgrade-5.10.0d6-5.10.0d7.sql
12:28 pm

antoniop

Add again double quotes in the add constraint as well

Options
    • -1
    • +1
    /openacs-4/packages/faq/sql/postgresql/upgrade/upgrade-5.10.0d5-5.10.0d6.sql
12:21 pm

antoniop

Add double quotes in case constraints were defined using e.g. $ in the old days

Options
    • -1
    • +1
    /openacs-4/packages/faq/sql/postgresql/upgrade/upgrade-5.10.0d5-5.10.0d6.sql
11:02 am

antoniop

Use generic acs_object__delete, so also eventual relations are deleted

Options
    • -0
    • +17
    /openacs-4/packages/faq/www/admin/faq-delete-oracle.xql
    • -0
    • +15
    /openacs-4/packages/faq/www/admin/faq-delete-postgresql.xql
    • -4
    • +1
    /openacs-4/packages/faq/www/admin/faq-delete.tcl
    • -0
    • +17
    /openacs-4/packages/faq/www/admin/q_and_a-delete-oracle.xql
    • -0
    • +15
    /openacs-4/packages/faq/www/admin/q_and_a-delete-postgresql.xql
    • -4
    • +1
    /openacs-4/packages/faq/www/admin/q_and_a-delete.tcl
9:49 am

antoniop

Actually delete from the acs_object, or it will stay around

Options
    • -1
    • +4
    /openacs-4/packages/faq/www/admin/faq-delete.tcl
    • -1
    • +4
    /openacs-4/packages/faq/www/admin/q_and_a-delete.tcl
8:44 am

gustafn

ad_return_url: change default value for default_url to "."

this is not terribly important, but probably a better approximation

Options
    • -3
    • +3
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
Wednesday 30 Jan 2019
11:12 pm

gustafn

fix for issue #3379

Options
    • -9
    • +18
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
10:16 pm

gustafn

switch from security::nonce_token to ::security::csp::nonce and update comments

Options
    • -9
    • +9
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
10:05 pm

gustafn

switch from security::nonce_token to ::security::csp::nonce

The latter one is available since more then two years in OpenACS.

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-request-monitor/www/index.tcl
9:29 pm

gustafn

xo::broadcast: allow to send messages to threads seleced via pattern

Options
    • -2
    • +6
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
9:25 pm

gustafn

address global variable __csrf_token directly

Options
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/30-widget-procs.tcl
9:24 pm

gustafn

terminate message key properly

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
2:49 pm

gustafn

Allow ad_return_url to be called also, when connection is closed.

This might be the case e.g. for the search renderer. In this case, a default_url is used

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/acs-tcl.info
    • -15
    • +19
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
    • -3
    • +3
    /openacs-4/packages/xowiki/xowiki.info
    • -6
    • +1
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
1:17 pm

antoniop

Streamline faq entry deletion exploiting newly defined on delete cascade

Options
    • -12
    • +0
    /openacs-4/packages/faq/www/admin/q_and_a-delete-postgresql.xql
    • -10
    • +1
    /openacs-4/packages/faq/www/admin/q_and_a-delete.tcl
1:15 pm

antoniop

Streamline faq deletion exploiting newly defined on delete cascade

Options
    • -13
    • +0
    /openacs-4/packages/faq/www/admin/faq-delete-postgresql.xql
    • -10
    • +1
    /openacs-4/packages/faq/www/admin/faq-delete.tcl
1:13 pm

antoniop

Put on delete cascade defined in previous upgrades in creation sql as well

Options
    • -2
    • +2
    /openacs-4/packages/faq/sql/oracle/faq-create.sql
    • -2
    • +2
    /openacs-4/packages/faq/sql/postgresql/faq-create.sql
12:59 pm

antoniop

Faq vs Search trigger reform: turns out after delete trigger on faq_q_and_as is quite pointless and makes it more complicated for faq package instances to properly uninstantiated. More details in the comments.

Options
    • -3
    • +2
    /openacs-4/packages/faq/faq.info
    • -2
    • +21
    /openacs-4/packages/faq/sql/postgresql/faq-sc-create.sql
    • -0
    • +24
    /openacs-4/packages/faq/sql/postgresql/upgrade/upgrade-5.10.0d6-5.10.0d7.sql
    • -14
    • +0
    /openacs-4/packages/faq/tcl/apm-callback-procs.tcl
    • -14
    • +0
    /openacs-4/packages/faq/tcl/apm-callback-procs.xql
12:29 pm

trenner

check for connection and provide fallback for return_url

Options
    • -1
    • +5
    /openacs-4/packages/xowiki/tcl/folder-procs.tcl
Tuesday 29 Jan 2019
8:14 pm

hectorr

Fix typos

Options
    • -13
    • +13
    /openacs-4/packages/search/tcl/search-procs.tcl
8:06 pm

hectorr

Whitespace changes + editor hints

Options
    • -56
    • +62
    /openacs-4/packages/intermedia-driver/tcl/intermedia-procs.tcl
    • -61
    • +59
    /openacs-4/packages/search/tcl/search-procs.tcl
8:00 pm

hectorr

Deprecate broken proc 'search::is_guest_p', and replace its only occurrence in the whole codebase, in the 'intermedia-driver' package, with working code.

Options
    • -1
    • +1
    /openacs-4/packages/intermedia-driver/tcl/intermedia-procs.tcl
    • -2
    • +6
    /openacs-4/packages/search/tcl/search-procs.tcl
6:10 pm

antoniop

Introduce ON DELETE CASCADE on faq main datamodel tables, so generic acs_object db api can be used to e.g. delete a faq (fixes downstream errors when deleting FAQ package)

Options
    • -2
    • +2
    /openacs-4/packages/faq/faq.info
    • -2
    • +4
    /openacs-4/packages/faq/sql/oracle/faq-create.sql
    • -0
    • +64
    /openacs-4/packages/faq/sql/oracle/upgrade/upgrade-5.10.0d5-5.10.0d6.sql
    • -1
    • +3
    /openacs-4/packages/faq/sql/postgresql/faq-create.sql
    • -0
    • +62
    /openacs-4/packages/faq/sql/postgresql/upgrade/upgrade-5.10.0d5-5.10.0d6.sql
3:13 pm

hectorr

Remove extra whitespace

Options
    • -2
    • +2
    /openacs-4/packages/dotlrn/www/register.tcl
2:59 pm

hectorr

Whitespace changes

Options
    • -11
    • +10
    /openacs-4/packages/dotlrn/www/register.tcl
12:49 pm

antoniop

Make xowf tests flexible in case a locale different than en_US is in use

Options
    • -13
    • +14
    /openacs-4/packages/xowf/tcl/test/xowf-test-procs.tcl
    • -1
    • +3
    /openacs-4/packages/xowiki/tcl/test/test-procs.tcl