OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 20 Mar
11:18 am

gustafn

file jquery-3.7.1.js was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/openacs-bootstrap5-theme/www/resources/js/jquery-3.7.1.js
    • -0
    • +0
    /openacs-4/packages/openacs-bootstrap3-theme/www/resources/js/jquery-3.7.1.js
    • -0
    • +0
    /openacs-4/packages/xowiki/www/resources/jquery/jquery-3.7.1.js
Tuesday 19 Mar
11:47 am

antoniop

Untangle if logics

Options
    • -23
    • +30
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
11:46 am

antoniop

Reject URLs displaying multiple protocols

Options
    • -1
    • +27
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
11:44 am

antoniop

Test further improvement of injection attempt by penetration tests

Options
    • -0
    • +10
    /openacs-4/packages/acs-tcl/tcl/test/text-html-procs.tcl
Monday 18 Mar
2:24 pm

antoniop

Harden page contract

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/www/permissions/one.tcl
    • -3
    • +3
    /openacs-4/packages/acs-subsite/www/permissions/toggle-inherit.tcl
2:13 pm

antoniop

Strenghten validation against smarter attempts to disguise the javascript: protocol

Options
    • -10
    • +17
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
2:12 pm

antoniop

Replicate a smarter attempt by a penetration tool to disguise the javascript: protocol

Options
    • -11
    • +24
    /openacs-4/packages/acs-tcl/tcl/test/text-html-procs.tcl
Tuesday 12 Mar
10:21 am

hectorr

Add new extension mjs, for Javascript modules, to the Javascript mime type

Options
    • -2
    • +2
    /openacs-4/packages/acs-content-repository/acs-content-repository.info
    • -0
    • +1
    /openacs-4/packages/acs-content-repository/sql/common/mime-type-data.sql
    • -0
    • +32
    /openacs-4/packages/acs-content-repository/sql/oracle/upgrade/upgrade-5.10.1b3-5.10.1b4.sql
    • -0
    • +26
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.1b3-5.10.1b4.sql
10:21 am

hectorr

file upgrade-5.10.1b3-5.10.1b4.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-content-repository/sql/oracle/upgrade/upgrade-5.10.1b3-5.10.1b4.sql
    • -0
    • +0
    /openacs-4/packages/acs-content-repository/sql/postgresql/upgrade/upgrade-5.10.1b3-5.10.1b4.sql
Wednesday 06 Mar
7:03 pm

gustafn

file upgrade-0.6.2d6-0.6.2d7.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-events/sql/postgresql/upgrade/upgrade-0.6.2d6-0.6.2d7.sql
7:03 pm

gustafn

added missing function args

Options
    • -2
    • +2
    /openacs-4/packages/acs-events/acs-events.info
    • -1
    • +3
    /openacs-4/packages/acs-events/sql/postgresql/acs-events-create.sql
    • -0
    • +1
    /openacs-4/packages/acs-events/sql/postgresql/upgrade/upgrade-0.6.2d6-0.6.2d7.sql
7:02 pm

gustafn

reduce verbosity

Options
    • -4
    • +4
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
Monday 04 Mar
4:46 pm

antoniop

Harden page contracts

Options
    • -2
    • +16
    /openacs-4/packages/calendar/www/cal-item-new.tcl
    • -2
    • +2
    /openacs-4/packages/calendar/www/cal-item-view.tcl
4:14 pm

antoniop

Prefer more robust colon notation to quote database values

Options
    • -1
    • +1
    /openacs-4/packages/xowf/tcl/xowf-procs.tcl
3:10 pm

antoniop

We replace spaces with "&nbsp" for Safari, but then convert will fail in the test... clean up the entities before trying to convert

Options
    • -1
    • +15
    /openacs-4/packages/captcha/tcl/test/captcha-procs.tcl
12:44 pm

antoniop

Fix variable name

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
Friday 01 Mar
3:54 pm

antoniop

Calculate the width before quoting is applied and refine the heuristic

Options
    • -7
    • +7
    /openacs-4/packages/captcha/tcl/captcha-procs.tcl
3:42 pm

antoniop

Fix capctha rendering on iOS devices, where apparently spaces need to be translated to entities

Options
    • -3
    • +10
    /openacs-4/packages/captcha/tcl/captcha-procs.tcl
2:21 pm

antoniop

Fix captcha responsiveness

Options
    • -4
    • +4
    /openacs-4/packages/captcha/tcl/captcha-procs.tcl
Thursday 29 Feb
2:19 pm

antoniop

Update italian localization

Options
    • -2
    • +2
    /openacs-4/packages/acs-subsite/acs-subsite.info
    • -0
    • +1
    /openacs-4/packages/acs-subsite/catalog/acs-subsite.it_IT.ISO-8859-1.xml
    • -2
    • +2
    /openacs-4/packages/xowf/xowf.info
    • -0
    • +5
    /openacs-4/packages/xowf/catalog/xowf.it_IT.ISO-8859-1.xml
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -0
    • +3
    /openacs-4/packages/xowiki/catalog/xowiki.it_IT.ISO-8859-1.xml
1:58 pm

antoniop

Introduce server-side validation for HTML5 date and time formfields

A "formats" parameter can be specified on the formfields indicating one or more formats that we want to enforce. The syntax for any of such format is that of the Tcl clock command.

Default values have been set according to the expected behavior of each form field type.

Empty values are always considered valid. If a field is required, this will be enforced in its own validator.

Options
    • -2
    • +2
    /openacs-4/packages/xowiki/xowiki.info
    • -0
    • +3
    /openacs-4/packages/xowiki/catalog/xowiki.de_DE.ISO-8859-1.xml
    • -0
    • +3
    /openacs-4/packages/xowiki/catalog/xowiki.en_US.ISO-8859-1.xml
    • -11
    • +69
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
1:53 pm

antoniop

Test behavior of HTML5 date and time formfields when invalid values are submitted

Options
    • -0
    • +186
    /openacs-4/packages/xowiki/tcl/test/xowiki-test-procs.tcl
1:04 pm

gernst

Quote error message to better protect against XSS attacks

Options
    • -2
    • +2
    /openacs-4/packages/xotcl-core/tcl/context-procs.tcl
12:21 pm

gustafn

Added default dbn to database drivers (acs::dc)

Align behavior with recent change in the xo::db inteface

Options
    • -5
    • +12
    /openacs-4/packages/acs-tcl/tcl/acs-db-00-procs.tcl
12:04 pm

gustafn

Added parameter to define a default dbn to a database connection

By this change, one can now define a default dbn at the creation time

of a database connection object. Before, it was necessary to pass

the "-dbn" value to every single command. The parameter can still be

used for particular queries as before to overrule the default.

Example for defining a connection context to a pool named "legacy"

using the PostgreSQL database interface

::xo::db::DB-postgresql create ::xo::dc1 -dialect postgresql -dbn legacy

lappend _ [::xo::dc1 get_value . {select count(*) from acs_objects}]

lappend _ [::xo::dc get_value . {select count(*) from acs_objects}]

#> 660 51606

Options
    • -10
    • +15
    /openacs-4/packages/xotcl-core/tcl/05-db-procs.tcl
Wednesday 28 Feb
2:36 pm

antoniop

"An iframe which has both allow-scripts and allow-same-origin for its sandbox attribute can remove its sandboxing"

See e.g. https://cloud.google.com/blog/products/data-analytics/iframe-sandbox-tutorial

We set in xooauth/tcl/lti-procs.tcl a restrictive default (all sandboxing restrictions are applied by default). Users should relax it according to their embedded application.

xooauth/www/admin/lti-test.tcl is not really a productive file, so we set the already hardcoded value to no-sandboxing and note that this would be appropriate.

Options
    • -1
    • +1
    /openacs-4/packages/xooauth/tcl/lti-procs.tcl
    • -7
    • +8
    /openacs-4/packages/xooauth/www/admin/lti-test.tcl
Tuesday 27 Feb
5:17 pm

hectorr

Remove duplicated entry

Options
    • -5
    • +4
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl
Monday 26 Feb
4:05 pm

antoniop

download-archive reform

File-Storage used to generate downloaded archives in tgz format, to then switch to zip, more user-friendly, in particular outside the Linux world (See https://openacs.org/forums/message-view?message_id=557561). To ease the transition, a couple of parameters and relative API were introduced that would allow to choose the preferred command one should use. During this reform however, default parameter values in the tcl code became inconsistent with those in the info file. Furthermore, the chosen defaults were set as absolute paths to the executable, which is not friendly to non-linux environments, or other scenarios where the "typical" Linux filesystem structure cannot be assumed (e.g. containers, MacOS...).

The only usage of this parameters/api was in fact in the download-archive vuh. In upstream codebase, no package references this file, not even the file-storage itself. Upon review, one could see that the file would also allow to specify a custom download filename via the path, which could be considered questionable. It would also execute the command in a way that once again assumes some form of Linux environment (e.g. invoking bash).

Save for the ability to customize the archive format and the anti-feature of being able to manipulate the archive filename via the path, the script largely relplicates www/download-zip, in a better shape after a few reforms hinted by e.g. penetration tools.

Given the aformentioned considerations, I have decided to make download-archive a simple redirect to download-zip. Specifying the object_id via the path will keep working, while URLs out there expecting the name to change will not fail, but the name will not be modified. The archive format will from now on be assumed to be zip.

Options
    • -4
    • +2
    /openacs-4/packages/file-storage/file-storage.info
    • -1
    • +15
    /openacs-4/packages/file-storage/tcl/file-storage-install-procs.tcl
    • -2
    • +2
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
    • -47
    • +1
    /openacs-4/packages/file-storage/tcl/test/file-storage-procs.tcl
    • -57
    • +24
    /openacs-4/packages/file-storage/www/download-archive/index.vuh
12:54 pm

gustafn

removed legacy code from apm_transfer_file

util::http::get should be everywhere available

Options
    • -57
    • +3
    /openacs-4/packages/acs-tcl/tcl/apm-file-procs.tcl
12:09 pm

gustafn

Rework of util::which

The new version deals now correctly with absolute paths,

where just the extensions are added, and it is checked

whether the program is executable.

Extended regression test to deal with optional and required

external dependencies. Missing optional external programs

produce warnings.

Options
    • -30
    • +46
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
    • -31
    • +91
    /openacs-4/packages/acs-tcl/tcl/test/acs-tcl-test-procs.tcl