All Activity
Today
38 mins ago

antoniop

Deprecate trivial wrapper dotlrn_chat::add_portlet_helper

Options
    • -14
    • +20
    /openacs-4/packages/dotlrn-chat/tcl/dotlrn-chat-procs.tcl
    • -11
    • +0
    /openacs-4/packages/dotlrn-chat/tcl/test/dotlrn-chat-test-procs.tcl
1 hr ago

antoniop

Cus short computations when the portlet is shaded

Options
    • -2
    • +9
    /openacs-4/packages/chat-portlet/www/chat-portlet.tcl
1 hr ago

antoniop

Reduce divergency between Oracle and Postgres codebase

Options
    • -47
    • +0
    /openacs-4/packages/chat-portlet/www/chat-portlet-oracle.xql
    • -47
    • +0
    /openacs-4/packages/chat-portlet/www/chat-portlet-postgresql.xql
    • -6
    • +27
    /openacs-4/packages/chat-portlet/www/chat-portlet.tcl
1 hr ago

antoniop

Cleanup the vestigial moderated_p flag

Options
    • -3
    • +3
    /openacs-4/packages/chat/chat.info
    • -0
    • +5
    /openacs-4/packages/chat/tcl/apm-callback-procs.tcl
    • -5
    • +5
    /openacs-4/packages/chat/tcl/chat-procs.tcl
    • -2
    • +0
    /openacs-4/packages/chat/tcl/xotcl-chat-procs.tcl
    • -1
    • +0
    /openacs-4/packages/chat/tcl/test/chat-test-procs.tcl
    • -2
    • +1
    /openacs-4/packages/chat/www/index.tcl
    • -6
    • +0
    /openacs-4/packages/chat/www/room-edit.tcl
    • -4
    • +1
    /openacs-4/packages/chat/www/room.tcl
    • -2
    • +0
    /openacs-4/packages/chat-portlet/www/chat-portlet-oracle.xql
    • -2
    • +0
    /openacs-4/packages/chat-portlet/www/chat-portlet-postgresql.xql
1 hr ago

antoniop

Get rid of the intermediate "room-enter" page and enforce all of the relevant permission in place in the "chat" page, cleanup variables and update automated tests

Options
    • -1
    • +0
    /openacs-4/packages/chat/tcl/test/chat-test-procs.tcl
    • -9
    • +2
    /openacs-4/packages/chat/tcl/test/webtest-procs.tcl
    • -24
    • +9
    /openacs-4/packages/chat/www/chat.tcl
    • -2
    • +2
    /openacs-4/packages/chat/www/index.tcl
    • -36
    • +0
    /openacs-4/packages/chat/www/room-enter.tcl
    • -1
    • +1
    /openacs-4/packages/chat-portlet/www/chat-portlet.tcl
2 hrs ago

antoniop

Update api

Options
    • -7
    • +5
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
3 hrs ago

antoniop

Modernize api

Options
    • -6
    • +4
    /openacs-4/packages/richtext-ckeditor4/tcl/ckfinder-init.tcl
3 hrs ago

antoniop

Modernize idiom

Options
    • -10
    • +5
    /openacs-4/packages/calendar/www/view-list-display.tcl
3 hrs ago

antoniop

Use modern api

Options
    • -12
    • +7
    /openacs-4/packages/acs-templating/tcl/table-procs.tcl
3 hrs ago

antoniop

Update api to streamline idiom

Options
    • -15
    • +4
    /openacs-4/packages/acs-templating/tcl/form-procs.tcl
4 hrs ago

antoniop

Update api

Options
    • -3
    • +2
    /openacs-4/packages/acs-templating/tcl/list-procs.tcl
    • -5
    • +1
    /openacs-4/packages/acs-tcl/tcl/form-processing-procs.tcl
4 hrs ago

antoniop

No need to access the form directly here

Options
    • -2
    • +1
    /openacs-4/packages/acs-bootstrap-installer/installer.tcl
4 hrs ago

antoniop

ns_getform will return the empty string only when invoked outside of a connection thread, which is a non-issue at installation time

Options
    • -26
    • +17
    /openacs-4/packages/acs-bootstrap-installer/installer.tcl
Tuesday 28 Mar
4:04 pm

antoniop

Deprecate trivial wrappers to the NaviServer API

Modern ns_getform will not return the empty string for empty requests, but only when we are operating outside of a connection. In such circumstances is arguably useful to manipulate the request parameters.

Options
    • -6
    • +27
    /openacs-4/packages/acs-tcl/tcl/request-processor-procs.tcl
    • -3
    • +2
    /openacs-4/packages/acs-templating/www/doc/tagref/include.adp
    • -4
    • +4
    /openacs-4/packages/acs-templating/www/doc/tagref/include.html
4:02 pm

antoniop

Commit missing change to the users api

Options
    • -2
    • +1
    /openacs-4/packages/acs-tcl/tcl/community-core-procs.tcl
4:01 pm

antoniop

Prefer Naviserver API directly

Options
    • -2
    • +1
    /openacs-4/packages/acs-admin/www/apm/index.tcl
3:55 pm

antoniop

Prefer NaviServer API directly

Options
    • -2
    • +2
    /openacs-4/packages/acs-api-browser/www/index.tcl
3:49 pm

antoniop

Rework idiom

Options
    • -2
    • +5
    /openacs-4/packages/news-aggregator/www/opml.vuh
3:47 pm

antoniop

Rework idiom

Options
    • -5
    • +8
    /openacs-4/packages/faq/www/index.vuh
3:45 pm

antoniop

Exploit page contract, rework idioms

Options
    • -8
    • +8
    /openacs-4/packages/dotlrn/www/members.tcl
3:34 pm

antoniop

Don't run the spiel when we are not connected

Options
    • -7
    • +9
    /openacs-4/packages/xotcl-core/tcl/01-debug-procs.tcl
3:22 pm

antoniop

Streamline idiom

Options
    • -3
    • +2
    /openacs-4/packages/news-aggregator/www/index.vuh
3:12 pm

antoniop

Streamline idiom

Options
    • -4
    • +3
    /openacs-4/packages/news/www/item.vuh
2:58 pm

antoniop

Whitespace cleanup

Options
    • -5
    • +5
    /openacs-4/packages/acs-admin/www/apm/version-edit-2.tcl
2:58 pm

antoniop

Modernize api

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/apm/version-edit-2.tcl
2:46 pm

antoniop

Inline rp_getform usage

Options
    • -3
    • +5
    /openacs-4/packages/assessment/www/asm-admin/sessions.tcl
2:43 pm

antoniop

rp_getform will never return the empty string, small cleanup

Options
    • -10
    • +6
    /openacs-4/packages/assessment/tcl/as-list-procs.tcl
1:20 pm

antoniop

Remove no_alarms_until column

Rationale: the column or the related api is never used in upstream code to check whether notifications should be sent or not or not. The UI to manage the column's value was not linked anywhere. On the instances accessible by me downstream, no tuple was found where this column had a value.

Options
    • -7
    • +0
    /openacs-4/packages/acs-core-docs/www/groups-design.adp
    • -6
    • +0
    /openacs-4/packages/acs-core-docs/www/groups-design.html
    • -1
    • +0
    /openacs-4/packages/acs-core-docs/www/parties.adp
    • -2
    • +1
    /openacs-4/packages/acs-core-docs/www/parties.html
    • -2
    • +1
    /openacs-4/packages/acs-core-docs/www/xml/developers-guide/parties.xml
    • -1
    • +0
    /openacs-4/packages/acs-core-docs/www/xml/kernel/ext-auth-design.xml
    • -10
    • +0
    /openacs-4/packages/acs-core-docs/www/xml/kernel/groups-design.xml
    • -2
    • +2
    /openacs-4/packages/acs-kernel/acs-kernel.info
    • -2
    • +2
    /openacs-4/packages/acs-kernel/sql/oracle/acs-create.sql
    • -27
    • +1
    /openacs-4/packages/acs-kernel/sql/oracle/community-core-create.sql
    • -0
    • +200
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1d17-5.10.1d18.sql
    • -37
    • +1
    /openacs-4/packages/acs-kernel/sql/postgresql/community-core-create.sql
    • -0
    • +49
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d17-5.10.1d18.sql
    • -8
    • +0
    /openacs-4/packages/acs-subsite/www/pvt/set-on-vacation-to-null.adp
    • -29
    • +0
    /openacs-4/packages/acs-subsite/www/pvt/set-on-vacation-to-null.tcl
  16. … 4 more files in changeset.
1:20 pm

antoniop

file upgrade-5.10.1d17-5.10.1d18.sql was initially added on branch oacs-5-10.

Options
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/oracle/upgrade/upgrade-5.10.1d17-5.10.1d18.sql
    • -0
    • +0
    /openacs-4/packages/acs-kernel/sql/postgresql/upgrade/upgrade-5.10.1d17-5.10.1d18.sql
11:54 am

antoniop

Avoid fetching the request forum manually

Options
    • -8
    • +12
    /openacs-4/packages/acs-subsite/www/admin/rel-types/roles/edit.tcl