kenk in OpenACS

Fixing bug 1913. Disallow link checking on bookmarks you do not have (delete) rights on.

Applied patch #500 for SDM # 1912 from Ken Kennedy: Can't change bookmark parent_id

Fixed folder toggle to show/hide bookmarks under folders...

Adding my_bookmarks_select query to index-oracle.xql

Added my_bookmarks_select query to index-postgresql.xql to allow views of own bookmarks to avoid permissions_p hit

Update to return type (integer to varchar) for bookmark__name

Hmmm. Methinks an index on bm_bookmarks.tree_sortkey might help with the performance issues...*grin*

Fixed insert with quotes, and started work on tweaking the regexes for bookmarks-import. The import_list variable was not being tested properly for existence; this is fixed.

Fixing import from bookmarks.htmCVS: ----------------------------------------------------------------------

Finished global permissions setting

Porting delete-dead-links

Updated one-host.xql

    • -0
    • +22
    /openacs-4/packages/bookmarks/www/one-host.xql
Ummmm...ok. NOW Most Popular hosts/URLs working! *grin*

Most Popular hosts/URLs working.

    • -0
    • +31
    /openacs-4/packages/bookmarks/www/most-popular-oracle.xql
Search functionality working.

    • -0
    • +63
    /openacs-4/packages/bookmarks/www/search-oracle.xql
    • -0
    • +77
    /openacs-4/packages/bookmarks/www/search-postgresql.xql
Javascript version working...successful w/ Opera 5 for Linux, Mozilla 0.9.1 and Galeon 0.11 on Linux. Konq isn't working yet (?? any ideas ??), and I haven't tested on WinX yet. I didn't change the actual js though (just the PG query), so hopefully it'll be ok.

Updating js tree...

Forgot to update bookmarks.info

Adding files for Javascript view

    • -0
    • +33
    /openacs-4/packages/bookmarks/www/tree-dynamic-oracle.xql
    • -0
    • +14
    /openacs-4/packages/bookmarks/www/tree-dynamic.xql
Bookmark Import working

    • -0
    • +70
    /openacs-4/packages/bookmarks/www/bookmarks-import.xql
Syncing with server after move; adding fixes to CONNECT BY replacements. Presently, some are broken once multiple users are added to site

Fixed error in bookmarks__new; context_id was not being set in acs_objects for all bookmarks -- added dead links checking

Check Links also working for individual users

Bookmarks administration (by Admin) working...

    • -0
    • +47
    /openacs-4/packages/bookmarks/www/bookmarks-check-oracle.xql
Fixed error in actually selecting bookmarks to view. Hadn't tried that yet...you can use them now.

    • -0
    • +16
    /openacs-4/packages/bookmarks/www/bookmark-access-oracle.xql
Fixed error in sort order on index page. Added editing and viewing. Basic

functionality is working.

    • -0
    • +34
    /openacs-4/packages/bookmarks/www/bookmark-add-one-2.xql
    • -0
    • +35
    /openacs-4/packages/bookmarks/www/bookmark-edit-2-oracle.xql
    • -0
    • +20
    /openacs-4/packages/bookmarks/www/bookmark-edit-2.xql
    • -0
    • +8
    /openacs-4/packages/bookmarks/www/bookmark-edit-oracle.xql
    • -0
    • +40
    /openacs-4/packages/bookmarks/www/bookmark-edit.xql
    • -0
    • +32
    /openacs-4/packages/bookmarks/www/bookmark-view-oracle.xql
    • -0
    • +22
    /openacs-4/packages/bookmarks/www/bookmark-view.xql
Fixed error in tree_sortkey insert trigger; hopefully tree_sortkey being created/updated properly now.

Fixed error in bookmark__get_in_closed_p that was causing it to always return true...

Bookmark delete is working

Working on bookmark-delete

    • -0
    • +15
    /openacs-4/packages/bookmarks/www/bookmark-delete-oracle.xql
    • -0
    • +12
    /openacs-4/packages/bookmarks/www/bookmark-delete.xql