nsf / tests

parameters.test

Clone Tools

Stats

Commits this week: 0
Total Committers: 5
Last Commit: 05 Mar
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 4 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 28 Sep 2012
2:07 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- added functiality for "cget" to call parameter-methods (e.g. "... cget -class"). The method cget calls either "/slot/ get ..." (when slot=... is provided in the parameter spec) or it assumes that the method without argument returns the value - added "::nsf::object::property /obj/ volatile" to query whether a object is volatile or not - "/obj/ cget -volatile" returns now the volatial state of the object - factored out ParameterMethodDispatch() from OConfigureMethod() - extended regression test

Options
    • -11
    • +13
    ./parameters.test
  2. … 9 more files in changeset.
Thursday 27 Sep 2012
12:36 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- invalidation of per-object parameter cache * on mixin changes and * on deletion/adding of per-object slots - decactivate PER_OBJECT_PARAMETER_CACHING per default (flipping this parameter makes regression test more than 20 faster). - extended regression test

Options
    • -0
    • +30
    ./parameters.test
  2. … 4 more files in changeset.
11:54 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- NsfObjInfoObjectparameterMethod(): return not only the first matching parameter, but the list of all matching ones. The last optional argument was renamed from "name" to "pattern" accordingly

Options
    • -5
    • +17
    ./parameters.test
  2. … 6 more files in changeset.
10:44 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- rename invalidateobjectparameter -> parameter:invalidate::classcache - rename invalidateobjobjectparameter -> parameter:invalidate::objectcache - bring cmds into alphabetical order

Options
    • -3
    • +3
    ./parameters.test
  2. … 7 more files in changeset.
Wednesday 26 Sep 2012
11:43 am

Gustaf Neumann <neumann@wu-wien.ac.at>

nsf.c: - fix potential bad interaction between per-object mixins and per-class caching of object-parameters

Options
    • -6
    • +61
    ./parameters.test
  2. … 2 more files in changeset.
Tuesday 25 Sep 2012
1:00 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

Property Reform Part 2: better handling of per-object properties nsf.c: - changed "/class/ __objectconfigure" to "/obj/ __objectconfigure" to be able to handle per-object properties on classes properly. - renamed "info method parametersyntax" -> "info method syntax" - renamed "/obj|cls/ info method parametersyntax" into "/obj|cls/ info method syntax" - replaced "::nsf::methods::class::info::objectparameter" by "::nsf::methods::object::info::objectparameter" - new command "::nsf::parameter::specs ?-configure? ?-noposargs? slotobjs": convert provided slotobjs into a list of parameter specs - new command "::nsf::parameter::get list|name|syntax parameterspec": convert parameter spec into syntax form, or retrieve pieces of information from it (can be extended in the future) - added more or less generic list handling functions TclObjListFreeList(), TclObjListNewElement() and TclObjListAdd() used by "::nsf::parameter::specs" - replaced "::nsf::method::property /obj/ -per-object /name/ slotcontainer ?value?" by "::nsf::object::property /obj/ slotcontainer ?value?" - added "::nsf::object::property /obj/ hasperobjectslots ?value?"

nx.tcl:

- new info methods

* "/obj/ info lookup parameter definitions"

* "/obj/ info lookup parameter names"

* "/obj/ info lookup parameter list"

* "/obj/ info lookup parameter syntax"

- changed "/cls/ info parameter definition ?name?"

into "/cls/ info parameter definitions ?name?"

since ir returns a list. Still, "list" or "syntax" won't

be plural

Options
    • -33
    • +29
    ./parameters.test
  2. … 18 more files in changeset.
Friday 21 Sep 2012
1:45 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- generalize handling for per-object-properties

Options
    • -3
    • +3
    ./parameters.test
  2. … 3 more files in changeset.
Wednesday 19 Sep 2012
10:57 am

Gustaf Neumann <neumann@wu-wien.ac.at>

Property reform part 1:

- disallow protection modifiers for "properties" and

add new flag "-accessor" to "property" and "variable"

This changes definitions like

Class create C {

:property {a a1}

:public property {b b1}

:protected property {c c1}

:private property {d d1}

}

to

Class create C {

:property {a a1}

:property -accessor public {b b1}

:property -accessor protected {c c1}

:property -accessor private {d d1}

}

since "properties" are always public accessible

over the "configure" and "cget" interface, but the

accessors methods might not be public. The value of

the accessor might be also "none" (specifying explicitely

that no accessor is wanted) or "", which means: use the default.

Same holds for "variable"

- disallow parameter option "incremental" and change it to a flag

of the property or variable. The motivation for this is due to

the fact, that "incremental" is a property of the accessor, and

not of the value.

old:

Class create C {

:property foo:int,incremental

:variable bar:int,incremental

}

new:

Class create C {

:property -incremental foo:int

:variable -incremental bar:int

}

- disallow "public class property" and friends since these are not needed

- removed parameter property "noaccessor"

- removed "nx::configure defaultPropertyCallProtection" and

method hook "__default_property_call_protection"

- introduced "nx::configure defaultAccessor" and

method hook "__default_accessor"

- for the time being, "defaultAccessor" is "public" for NX and XOTcl,

will be changed to "none" in NX

- extended regression test (new file properties.test)

Options
    • -29
    • +37
    ./parameters.test
  2. … 16 more files in changeset.
Saturday 15 Sep 2012
8:57 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

nsf.c: - fixed parmeter syntax for required nonpos args - deactivate deletion of methods via nsf::object::delete during shutdown to avoid missing slot forwarders called from destructors

Options
    • -2
    • +2
    ./parameters.test
  2. … 5 more files in changeset.
Thursday 13 Sep 2012
12:11 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

nx.tcl: - rename the following internally called methods (not for XOTcl). alloc -> __alloc dealloc -> __dealloc objectparameter -> __objectparameter recrate -> __recreate - from these methods, only __objectparameter is defined per default, the others are defined on demand

Options
    • -13
    • +13
    ./parameters.test
  2. … 6 more files in changeset.
8:22 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- rename nx::Object.configure to nx::Object.__configure to free method name "configure" for an e.g. tk-like configure

Options
    • -6
    • +6
    ./parameters.test
  2. … 5 more files in changeset.
Tuesday 31 Jul 2012
8:04 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

nx.tcl: - set multiplicty for mixins and filters by default from 1..n to 0..n to avoid error messages, when e.g. empty mixin lists are configured. Setting emtpy mixin-lists is strictly speaking not necessary, but this eases the code in cases the lists are sometimes empty.

Options
    • -9
    • +9
    ./parameters.test
  2. … 3 more files in changeset.
2:49 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

Adding a test case and a preliminary fix for the parameter option interactions

Options
    • -0
    • +17
    ./parameters.test
  2. … 1 more file in changeset.
Wednesday 18 Jul 2012
1:55 am

Stefan Sobernig <stefan.sobernig@wu-wien.ac.at>

- library/nx/nx.tcl: Following the code review, implemented a first scheme for handling traces in setCheckedInstVar. This gives us consistent behavior for defaults and traces (valuechangedcmd) across classes and objects. - tests/parameters.test: Adjusted the relevant tests - Pending: setCheckedInstVar currently uses ::nsf::is to validate the value (e.g., default value) to be set. However, it might get passed parameter options which do not fit the NSF_DISALLOWED_ARG_VALUECHECKED filter.

Options
    • -9
    • +2
    ./parameters.test
  2. … 1 more file in changeset.
Tuesday 17 Jul 2012
12:24 am

ssoberni <stefan.sobernig@wu-wien.ac.at>

- Addressed a number of issues in the NX slot infrastructure (which revealed themselves when running Mark's BusinessActivities implementation in XOTcl2 mode): - generic/nsf.c: Initcmd blocks (as set for registering per-class slot traces) were subjected to argument checks causing unexpected behavior (e.g., attempts of unboxing initcmds as Tcl lists or of checking initcmds against value types). This was fixed by exempting NSF_ARG_INITCMD params from argument checking in ArgumentCheck() explicitly. - library/nx/nx.tcl: For per-class parameters, the use of valuechangedcmd effectively overruled the default value specified (simply because the generated initcmd holding the trace statements took the place of the default value). While for defaultcmd and for valuecmd the parallel use of default is forbidden, the valuechangedcmd semantics allow for specifying a default, in principle. This was fixed by providing a default-setting statement in the initcmd. - tests/parameters.test: Added tests to cover the above (and beyond). - library/xotcl/library/xotcl2.tcl: Extended the backwards compatibility of the hybrid XOTcl2/NX slots infrastructure to the XOTcl 1 interface: This includes support for inline -proc statements and instvar. This compat level corresponds to the slot interface as documented (by examples) in the XOTcl language ref and the manual. - library/xotcl/tests/slottest.xotcl: Added tests for the above compat enhancements.

Options
    • -0
    • +135
    ./parameters.test
  2. … 4 more files in changeset.
12:22 am

ssoberni <stefan.sobernig@wu-wien.ac.at>

The BA examples are operative

Options
    • -3
    • +21
    ./parameters.test
  2. … 1 more file in changeset.
Monday 16 Jul 2012
2:56 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

Most issues resolved, however, the ordering of default vs. traces is pending

Options
    • -0
    • +117
    ./parameters.test
  2. … 4 more files in changeset.
Monday 25 Jun 2012
11:48 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- added a SlotContainerCmdResolver() to avoid interaction of slot names with names of callable tcl commands. Without the SlotContainerCmdResolver() the call to "list" in a property named "list" leads to a call to the container object ::Test2::slot::list instead to the intended ::list. The implementation is not perfect, since it ignores the namespace path inside the slot container. - added regression test.

Options
    • -0
    • +23
    ./parameters.test
  2. … 2 more files in changeset.
Sunday 13 May 2012
10:19 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- start error messages with a lower case word for consistency and to follow closer to Tcl's conventions

Options
    • -4
    • +4
    ./parameters.test
  2. … 6 more files in changeset.
Friday 11 May 2012
11:48 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- implement escaping for comma in value of parameter options: escaping in values can be achived via duplicating the comma. - extend regression test

Options
    • -6
    • +54
    ./parameters.test
  2. … 2 more files in changeset.
Monday 27 Feb 2012
12:25 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- pass property name to slot "initialize" method to conform with the interface to "assign", "get" ... (all these receive the property name as well) - allow slot "initialize" method to be protected (handled similarly to "init")

Options
    • -1
    • +1
    ./parameters.test
  2. … 3 more files in changeset.
Friday 24 Feb 2012
7:56 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

nsf.c: - added object parameter option "slotinitialize" - renamed object parameter option "invokesetter" -> "slotassign" - call slot.assign instead of setter of object - removed restriction on nosetter/invokesetter: nosetter can be used in connection with slotassign - added regression test for slot.initialize

Options
    • -5
    • +35
    ./parameters.test
  2. … 4 more files in changeset.
Thursday 16 Feb 2012
10:49 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- treating incompatible forwarding to slot vs. slot option noaccessor - extended regression test

Options
    • -0
    • +34
    ./parameters.test
  2. … 2 more files in changeset.
Sunday 29 Jan 2012
4:12 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- Forward setting of object parameters to the slot object, when assign method is user-defined on the slot object - Cleanup and extend regression test

Options
    • -10
    • +53
    ./parameters.test
  2. … 3 more files in changeset.
Friday 20 Jan 2012
11:14 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- nsf.c: start all error messages with a lower case word for consistency and to follow closer to Tcl's conventions

Options
    • -16
    • +16
    ./parameters.test
  2. … 14 more files in changeset.
Friday 04 Nov 2011
1:26 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- generic/nsf.c: DispatchUnknownMethod() In the re-entrant case, the unknown dispatcher was too greedy by skipping the first element in the objv at basically all times. For CallConfigureMethod() case in XOTcl2, the actual method name was so skipped. Generally speaking, the "skipping rules" in DispatchUnknownMethod() feel a touch too particular to me: For instance, the dispatch flag "-local", "-system" etc. must be handled. Also, unknowns in method ensembles have the unknown method listed first in objv. Alternatively, we might review how objc/objv make it into DispatchUnknownMethod() (there are just two call sites). But this would merely shift/spread the skipping. Changing the arg vectors, to begin with, (e.g. removing "-local", "-system", etc. from the objv) would requiring rebuilding the arg vector. - tests/parameters.test: Added a simplistic test case to catch the error reporting for XOTcl 2's residualargs handling.

Options
    • -1
    • +14
    ./parameters.test
  2. … 1 more file in changeset.
Monday 24 Oct 2011
11:34 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- make sure to use "XOTcl 2.0" instead of just XOTcl in "package req" to avoid confusions due to beta state - remove more obsolete and untested files

Options
    • -1
    • +1
    ./parameters.test
  2. … 56 more files in changeset.
Tuesday 18 Oct 2011
11:11 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- rename "info method handle /methodName/" into "info method registrationhandle /methodName/" - rename "info method origin /methodName/" into "info method definitionhandle /methodName/" - added "info method origin" to return the target of an alias (or empty)

Options
    • -2
    • +2
    ./parameters.test
  2. … 19 more files in changeset.
Friday 30 Sep 2011
2:26 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- altered default handling to honor side effects of aliased object parameters. This slows down evaluation a little. Side-effects from aliased parameters are discouraged, since the order of the evaluation should not matter of an declarative evaluation of the argument vector. - extended regression test

Options
    • -0
    • +33
    ./parameters.test
  2. … 2 more files in changeset.
Monday 26 Sep 2011
12:51 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

nonleadingdash handling: - doc: added "nonleadingdash" to UML class diagramm - nsf.c: added error message, when "noleadingdash" is used on non-positional parameters - nsf.c: use same logic for "nonleadingdash" to "value in argument" - nsf.c: deactivated rudimentary unknown handler for the time being - nx.tcl: added handling of parameter option "noleadingdash" in objectParameterSlots

Options
    • -13
    • +11
    ./parameters.test
  2. … 6 more files in changeset.