Activity nsf/

9:56 am

Gustaf Neumann <neumann@wu-wien.ac.at>

More
4563271
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

Merge branch 'master' of ssh://alice.wu-wien.ac.at/usr/local/src/git-repo/nsf

- -3
- +5
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

9:56 am

Gustaf Neumann <neumann@wu-wien.ac.at>

More
0ad07ea
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

mprove alignment of prototypes and function definitions

- -4
- +9
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

5:15 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
9131bba
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (ObjectCmdMethodDispatch, FindNextMethod): Balance book-keeping in memcounts for Tcl_Objs (technically, an unmatched decrement would suffice).

- -0
- +2
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

5:13 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
bbeae25
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (NsfProcDeleteProc): Fix freeing of colonLocalVarCache and balance book-kepping on memcounts for colonLocalVarCache.

- -1
- +1
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

1:17 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
47f0460
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

Merge branch 'master' of ssh://alice.wu.ac.at/usr/local/src/git-repo/nsf

- -4
- +5
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

1:15 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
4db189d
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (ObjectCmdMethodDispatch): Silence static check of GCC 8.1 (-Wmaybe-uninitialized). [skip ci]

- -2
- +2
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

12:00 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

More
c9fc52e
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

Merge branch 'master' of ssh://alice.wu-wien.ac.at/usr/local/src/git-repo/nsf

- -11
- +18
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

11:49 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
27e5aa8
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (NsfCurrentCmd): Avoid (possible, but unlikely) null dereferencing, if CSC was missing [CID 294166].

- -4
- +10
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

11:37 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
53a9c01
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (NsfDebugGetDict): Compute the remaining size to snprintf for each iteration [CID 294169]. [skip ci]

- -1
- +1
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

11:26 am

Gustaf Neumann <neumann@wu-wien.ac.at>

More
72a0a42
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

address CID 294171 and change construct for strpbrk

- -4
- +5
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

10:33 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
8ea1d85
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

Merge branch 'master' of ssh://alice.wu.ac.at/usr/local/src/git-repo/nsf

- -93
- +97
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

10:32 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
22cdc00
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

nsf.c (NsfDebugGetDict): Parametrize length computation; remove unneeded nul-termination. [skip ci]

- -6
- +7
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

10:28 am

Gustaf Neumann <neumann@wu-wien.ac.at>

More
369069e
changed 2 files
2.2, 2.2.0-repro-patch and 19 more

minor cleanup

- -93
- +97
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c
- -1
- +1
/generic/nsfStubLib.c
- History
- Source
- Diff
/generic/nsfStubLib.c

10:28 am

Gustaf Neumann <neumann@wu-wien.ac.at>

More
c2157fa
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

reduce variable scope and minor cleanup

- -7
- +8
/library/mongodb/nsfmongo.c
- History
- Source
- Diff
/library/mongodb/nsfmongo.c

11:56 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
ea63ea3
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (NsfDebugGetDict): Make use of strncat more robust by setting the destingation length to the remainder of the output buffer.

- -3
- +5
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

10:35 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
500a581
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (ForwardArg): Provide a const'ed pointer to strpbrk, as required [CID 294162].

- -5
- +6
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

10:15 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
b3e820b
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (ParamDefsFormat): Fix overrun in memcpy by correcting the destination-length argument [CID 294165].

- -1
- +1
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

12:39 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
bec5f06
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c: Fix all "-pedantic -ansi" errors.

- -47
- +55
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

5:49 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
1a486b9
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (ParamDefsStore, NsfProcDeleteProc): Provide for counting a reference to the execNsPtr from the NsfProcContext structure. While I could not devise a script-level path to pull out the rug (execNsPtr) out from under NsfProcContext clients, I can only also not exclude the latter (from future C-level paths?). Better act defensively.

- -2
- +11
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

12:53 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
d96dedf
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsfInt.h (STRING_NEW): Silence GCC 8.1 warnings on truncation risk using strncpy; made me wonder whether STRING_NEW would not be more robust against mis-computations of the destination-buffer length by using snprintf (mainly because snprintf does not nul-pad the destination buffer and always nul-terminates the destination buffer)?

- -1
- +1
/generic/nsfInt.h
- History
- Source
- Diff
/generic/nsfInt.h

1:49 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
bf61b8a
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* parameters.test: Adding two test cases to cover previously missed code branches leading to leaking NsfMethodNamePath uses.

- -0
- +15
/tests/parameters.test
- History
- Source
- Diff
/tests/parameters.test

10:35 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
6042ab0
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (ArgumentParse): Handle NsfMethodNamePath result correctly.

- -8
- +11
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

10:34 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
76da430
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (NsfSetterMethod): Handle NsfMethodNamePath result correctly.

- -2
- +6
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

4:05 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
424b6e1
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (ObjectCmdMethodDispatch): Close another Tcl_Obj leak incurred by not handling the result from NsfMethodNamePath.

- -1
- +13
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

2:42 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
87bc503
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (FindNextMethod): Plumb another memleak (valgrind). The Tcl_Obj computed by NsfMethodNamePath must be refcount corrected.

- -2
- +5
/generic/nsf.c
- History
- Source
- Diff
/generic/nsf.c

2:39 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
31c114e
changed 1 file
2.2, 2.2.0-repro-patch and 19 more

* nsf.c (AliasGet): Plumbing a memleak found by valgrind. The computed Tcl_Obj from AliasIndex must be refcount-managed explicitly, otherwise the path via AliasGet leaks it.