• last updated 3 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- use $::acs::rootdir rather than [acs_root_dir] or [get_server_root]

- use $::acs::rootdir rather than [acs_root_dir] or [get_server_root]

- use expand operator instead of eval

- simplify logic

- use ::acs::rootdir variable instead of call

- use $::acs::rootdir rather than [acs_root_dir] or [get_server_root]

- mark deprected functions as such in browser

- flatten nested "lindex" structures

- use $::acs::rootdir rather than [acs_root_dir] or [get_server_root]

    • -11
    • +11
    /openacs-4/packages/acs-tcl/tcl/apm-procs.tcl
- use lock-free ::acs::rootdir variable instead of nsv variable

- use global variable ::acs::rootdir similar to ::acs::libdir or ::acs::pageroot

- revert escaped change for the time being

- use "... eq {} " instead of "template::util::is_nil" where it is clear that the variable exists

- use "![info exists]" instead of "template::util::is_nil" on scalars

- get rid of "template::util::is_nil" by initializing variable

- use "... eq {} " instead of "template::util::is_nil" where it is clear that the variable exists

- use "![info exists]" instead of "template::util::is_nil" on scalars

- use "![info exists]" instead of "template::util::is_nil" on scalars

- use "![info exists]" instead of "template::util::is_nil" on scalars

remove obsolete file

- make it easier to track invalid provided ranges

- use "lassign" instead of multiple "lindex" instructions

- improve robustness against invalid input

    • -1
    • +3
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
- brace expressions

- flatten nested "lindex" structures

- use tcl 8.5 extended index format for "lrange"

- normalize string expressions

  1. … 7 more files in changeset.
- use "in" operator instead of "lsearch"

- use numeric comparison operator for truth value comparisons

- modernize tcl

- brace expressions

- use numeric comparison operator for truth value comparisons

- use tcl 8.5 extended index format for "lindex"

  1. … 6 more files in changeset.
- make variable reference absolute

- normalize string expressions

    • -4
    • +4
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
    • -4
    • +4
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
    • -1
    • +1
    /openacs-4/packages/xowiki/tcl/repeat-procs.tcl
- improve performance of by using precomputed :folder_id instead of

etp__get_folder_id() in SQL query

- use ad_proc's argument parser instead of local implmentation in get_content_items

- use numeric comparison operator for truth value comparisons

- use "in" operator instead of "lsearch"

- use numeric comparison operator for truth value comparisons

- use "" for empty

- remove braces

- revert to the previous version, although the code is conceptually broken. however, ad_form relies on the current version.

- reduce number of remaining "string equal" operations

- reduce number of remaining "string equal" operations

- normalize string expressions

- use tcl 8.5 extended index format for "string range"