• last updated 6 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Prefer ad_mktmpdir to ad_tmpnam

merge with missing files

  1. … 1459 more files in changeset.
merge from oacs-5-10

    • -151
    • +0
    ./file-storage-procs-postgresql.xql
    • -33
    • +1
    ./file-storage-rss-procs-oracle.xql
    • -34
    • +2
    ./file-storage-rss-procs-postgresql.xql
    • -1
    • +1
    ./file-storage-search-procs-postgresql.xql
    • -102
    • +757
    ./test/file-storage-procs.tcl
  1. … 8085 more files in changeset.
file webtest-procs.tcl was initially added on branch oacs-5-10.

    • -0
    • +0
    ./test/webtest-procs.tcl
File storage max upload limit reform:

the max upload limit will now default to empty. Rationale: this value is

one that ages quickly with respect to new storage requirements, and is

currently set to something incompatible with the vanilla Naviserver configuration

(500MB fs vs 20MB ns).

The upgrade script will make so that instances setting this parameter

higher than the server upload limit configuration will be

set empty as well (this would never have an effect, as server

will prevent the upload altogheter anyway).

Max upload limit in bytes is now retrieved from a proc implementing

this fallback to server configuration logics. Other than centralizing,

its purpose is to be used in client-side code checks in the future

so we could prevent a doomed upload in advance.

  1. … 5 more files in changeset.
Fix typos

  1. … 8 more files in changeset.
Whitespace changes

    • -39
    • +39
    ./file-storage-callback-procs.tcl
    • -101
    • +98
    ./test/file-storage-procs.tcl
  1. … 2 more files in changeset.
Fix typos and wording.

  1. … 1 more file in changeset.
Removed obsolete @arch-tag

  1. … 58 more files in changeset.
- removed extra colons

- streamline layout of test cases

Whitespace changes

  1. … 2 more files in changeset.
Fix parameter name in proc doc and add brief descriptions

  1. … 3 more files in changeset.
Move callback hooks definitions together with their siblings, add documentation to public procs (fixes automated tests)

    • -94
    • +135
    ./file-storage-callback-procs.tcl
Add documentation for public procs (fixes automated tests)

Add documentation to public callback hook (fixes automated tests)

Set package_id explicitly as the main subsite package, as ad_conn package_id could not be properly initialized when a system was freshly restarted

Prefer 'person::name' to 'acs_user::get_element ... -name'

  1. … 1 more file in changeset.
Fiy typo

Deprecated leftover parameter from year 2002

While working on reducing divergencies between oracle and postgres codebase and testing changes I have found the following issues:

- fs::add_created_version.new_text_revision query was defined in postgres only

- version-delete and folder-delete were broken in case notification was enabled,

because this was issued after object was deleted and therefore all references

needed to build notification message were missing (and query failed looking up the object)

    • -43
    • +0
    ./file-storage-procs-postgresql.xql
  1. … 2 more files in changeset.
Whitespace changes

whitespace cleanup

mark required parameters as required. Fixes issue #3347

always use @see when procs are deprecated to show, what to use instead

improve spelling

  1. … 8 more files in changeset.
Remove legacy file

Revert massive replacement of empty list creation sentences. The use of '[list]' instead of '{}' adds semantics that could be used for performance improvements in the future, such as using a different internal representation. There is already work in this direction, avoiding the generation of the string representation during comparison of empty strings (huge thanks to Stefan Sobernig for the pointer: https://core.tcl.tk/tcl/info/44527c632ed609c2).

  1. … 474 more files in changeset.
Prefer '{}' to '[list]' when creating empty lists

  1. … 203 more files in changeset.
Fix typos

  1. … 7 more files in changeset.
Bugfix: content variable was not define before access (thanks to Giulia Nencini)

I am also not reading file content anymore, as this is potentially unsafe when file is very big and also could need special encoding translation etc.

Better retrieve the path and let the user decide what to do afterwards.