nsf

tests

Clone Tools

Stats

Commits this week: 0
Total Committers: 10
Last Commit: 14 Oct
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 5 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 19 Sep 2012
10:57 am

Gustaf Neumann <neumann@wu-wien.ac.at>

Property reform part 1:

- disallow protection modifiers for "properties" and

add new flag "-accessor" to "property" and "variable"

This changes definitions like

Class create C {

:property {a a1}

:public property {b b1}

:protected property {c c1}

:private property {d d1}

}

to

Class create C {

:property {a a1}

:property -accessor public {b b1}

:property -accessor protected {c c1}

:property -accessor private {d d1}

}

since "properties" are always public accessible

over the "configure" and "cget" interface, but the

accessors methods might not be public. The value of

the accessor might be also "none" (specifying explicitely

that no accessor is wanted) or "", which means: use the default.

Same holds for "variable"

- disallow parameter option "incremental" and change it to a flag

of the property or variable. The motivation for this is due to

the fact, that "incremental" is a property of the accessor, and

not of the value.

old:

Class create C {

:property foo:int,incremental

:variable bar:int,incremental

}

new:

Class create C {

:property -incremental foo:int

:variable -incremental bar:int

}

- disallow "public class property" and friends since these are not needed

- removed parameter property "noaccessor"

- removed "nx::configure defaultPropertyCallProtection" and

method hook "__default_property_call_protection"

- introduced "nx::configure defaultAccessor" and

method hook "__default_accessor"

- for the time being, "defaultAccessor" is "public" for NX and XOTcl,

will be changed to "none" in NX

- extended regression test (new file properties.test)

Options
    • -3
    • +3
    ./cget.test
    • -2
    • +2
    ./destroy.test
    • -6
    • +10
    ./info-method.test
    • -32
    • +44
    ./methods.test
    • -3
    • +3
    ./object-system.test
    • -29
    • +37
    ./parameters.test
    • -17
    • +22
    ./protected.test
    • -6
    • +1
    ./submethods.test
  9. … 9 more files in changeset.
Saturday 15 Sep 2012
8:57 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

nsf.c: - fixed parmeter syntax for required nonpos args - deactivate deletion of methods via nsf::object::delete during shutdown to avoid missing slot forwarders called from destructors

Options
    • -3
    • +2
    ./cget.test
    • -1
    • +1
    ./disposition.test
    • -2
    • +2
    ./parameters.test
  4. … 3 more files in changeset.
7:55 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

nsf.c: - made argument of cget required

nx.tcl:

- added Tk-style methods "configure" and "cget"

- added additional regression test set for cget and configure

Options
    • -0
    • +167
    ./cget.test
    • -2
    • +2
    ./info-method.test
  3. … 6 more files in changeset.
5:31 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- fixed regression test to run all test again correctly

Options
    • -13
    • +13
    ./methods.test
Friday 14 Sep 2012
12:49 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

nsf.c: - extended nsf::method::delete to handle ensemble names

nx.tcl:

- added tk/incr-tcl style cget methods on class/object levels.

- improve copy handling with other child-types of the slot container working

- make sure to ignore non-slot-type objects in slot introspection

- worked on regression test until "methods.test". others are missing,

but maybe reconsideration

Options
    • -21
    • +21
    ./methods.test
  2. … 7 more files in changeset.
Thursday 13 Sep 2012
12:11 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

nx.tcl: - rename the following internally called methods (not for XOTcl). alloc -> __alloc dealloc -> __dealloc objectparameter -> __objectparameter recrate -> __recreate - from these methods, only __objectparameter is defined per default, the others are defined on demand

Options
    • -12
    • +12
    ./disposition.test
    • -2
    • +2
    ./method-require.test
    • -1
    • +1
    ./object-system.test
    • -13
    • +13
    ./parameters.test
  5. … 3 more files in changeset.
8:22 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- rename nx::Object.configure to nx::Object.__configure to free method name "configure" for an e.g. tk-like configure

Options
    • -2
    • +2
    ./info-method.test
    • -1
    • +1
    ./object-system.test
    • -6
    • +6
    ./parameters.test
  4. … 3 more files in changeset.
Wednesday 01 Aug 2012
1:24 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

nx::test: - added summary at the end of "make test" via log file - updated .gitignore

Options
    • -0
    • +25
    ./summary.tcl
  2. … 4 more files in changeset.
Tuesday 31 Jul 2012
8:04 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

nx.tcl: - set multiplicty for mixins and filters by default from 1..n to 0..n to avoid error messages, when e.g. empty mixin lists are configured. Setting emtpy mixin-lists is strictly speaking not necessary, but this eases the code in cases the lists are sometimes empty.

Options
    • -1
    • +1
    ./info-method.test
    • -9
    • +9
    ./parameters.test
  3. … 2 more files in changeset.
7:57 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- handle cyclical superclassclass dependencies during object system finalize - extend regression test

Options
    • -0
    • +17
    ./destroy.test
  2. … 2 more files in changeset.
2:49 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

Adding a test case and a preliminary fix for the parameter option interactions

Options
    • -0
    • +17
    ./parameters.test
  2. … 1 more file in changeset.
Wednesday 18 Jul 2012
10:54 am

Gustaf Neumann <neumann@wu-wien.ac.at>

nsf.c: - ignore in internall calls to "dealloc" protection settings - handle cyclical class dependencies during object system finalize - extend regression test

Options
    • -1
    • +21
    ./destroy.test
  2. … 2 more files in changeset.
1:55 am

Stefan Sobernig <stefan.sobernig@wu-wien.ac.at>

- library/nx/nx.tcl: Following the code review, implemented a first scheme for handling traces in setCheckedInstVar. This gives us consistent behavior for defaults and traces (valuechangedcmd) across classes and objects. - tests/parameters.test: Adjusted the relevant tests - Pending: setCheckedInstVar currently uses ::nsf::is to validate the value (e.g., default value) to be set. However, it might get passed parameter options which do not fit the NSF_DISALLOWED_ARG_VALUECHECKED filter.

Options
    • -9
    • +2
    ./parameters.test
  2. … 1 more file in changeset.
Tuesday 17 Jul 2012
12:24 am

ssoberni <stefan.sobernig@wu-wien.ac.at>

- Addressed a number of issues in the NX slot infrastructure (which revealed themselves when running Mark's BusinessActivities implementation in XOTcl2 mode): - generic/nsf.c: Initcmd blocks (as set for registering per-class slot traces) were subjected to argument checks causing unexpected behavior (e.g., attempts of unboxing initcmds as Tcl lists or of checking initcmds against value types). This was fixed by exempting NSF_ARG_INITCMD params from argument checking in ArgumentCheck() explicitly. - library/nx/nx.tcl: For per-class parameters, the use of valuechangedcmd effectively overruled the default value specified (simply because the generated initcmd holding the trace statements took the place of the default value). While for defaultcmd and for valuecmd the parallel use of default is forbidden, the valuechangedcmd semantics allow for specifying a default, in principle. This was fixed by providing a default-setting statement in the initcmd. - tests/parameters.test: Added tests to cover the above (and beyond). - library/xotcl/library/xotcl2.tcl: Extended the backwards compatibility of the hybrid XOTcl2/NX slots infrastructure to the XOTcl 1 interface: This includes support for inline -proc statements and instvar. This compat level corresponds to the slot interface as documented (by examples) in the XOTcl language ref and the manual. - library/xotcl/tests/slottest.xotcl: Added tests for the above compat enhancements.

Options
    • -0
    • +135
    ./parameters.test
  2. … 4 more files in changeset.
12:22 am

ssoberni <stefan.sobernig@wu-wien.ac.at>

The BA examples are operative

Options
    • -3
    • +21
    ./parameters.test
  2. … 1 more file in changeset.
Monday 16 Jul 2012
2:56 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

Most issues resolved, however, the ordering of default vs. traces is pending

Options
    • -0
    • +117
    ./parameters.test
  2. … 4 more files in changeset.
Wednesday 27 Jun 2012
1:21 am

ssoberni <stefan.sobernig@wu-wien.ac.at>

- Replaced errorneous check using the object-specific rather than the class-specific options in the query mode of ::nsf::relation with class-filter. This prevented [::nsf::relation /cls/ class-filter] from returning any filter info. As a consequence, the incremental interface of the filter slot failed (e.g., [/cls/ filter add aFilterProc] effectively reset the class-filter cmd list instead of adding to it). Thx are due to Markus Moldaschl for reporting the issue. - Aligning class-filter and object-filter behaviour on errors during filter additions to the state-preserving behaviour of object-mixin and class-mixin. - Adding basic tests on object-filter/class-filter (::nsf::relation, filter slot interface) and specific ones to cover the above issues.

Options
    • -1
    • +1
    ./info-method.test
    • -0
    • +56
    ./interceptor-slot.test
  3. … 1 more file in changeset.
1:18 am

ssoberni <stefan.sobernig@wu-wien.ac.at>

Adding basic tests on object-filter/class-filter; and specific ones to cover the class-filter issue

Options
    • -1
    • +1
    ./info-method.test
    • -0
    • +56
    ./interceptor-slot.test
Monday 25 Jun 2012
11:48 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- added a SlotContainerCmdResolver() to avoid interaction of slot names with names of callable tcl commands. Without the SlotContainerCmdResolver() the call to "list" in a property named "list" leads to a call to the container object ::Test2::slot::list instead to the intended ::list. The implementation is not perfect, since it ignores the namespace path inside the slot container. - added regression test.

Options
    • -0
    • +23
    ./parameters.test
  2. … 2 more files in changeset.
Friday 01 Jun 2012
12:01 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

nsfShadow.c - bump MethodEpoch when a tcl ::rename command happens on a nsf method (which might be cached in a Tcl_Obj) This fixes a crash reported by Arthur Schreiber nsf.c: - make NsfInstanceMethodEpochIncr() and NsfObjectMethodEpochIncr() accessible from all files using nsfInt.h - remove experimental code (backslash escaping for "," in parameter option parse

Options
    • -0
    • +52
    ./destroy.test
  2. … 4 more files in changeset.
Tuesday 22 May 2012
10:33 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- document private properties in tutorial and migration guide - improve wording in documenting - extend regression test

Options
    • -1
    • +63
    ./protected.test
  2. … 5 more files in changeset.
Monday 21 May 2012
11:22 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- minor polishing

Options
    • -1
    • +8
    ./protected.test
Monday 14 May 2012
12:41 pm

ssoberni <stefan.sobernig@wu-wien.ac.at>

- generic/nsf.c, ObjectDispatch(): Re-arranged the handling of fully-qualified method dispatches with the selectors resolving to existing objects and, in particular, nested (namespace-qualified) objects. Prior to that, dispatches such as "::C ::parent::child" were not covered appropriately: ::parent was reported as valid regObj and so the dispatcher continued to dispatch to the cmd "::parent::child" in the self-context ::parent::child ... with unwanted side-effects (e.g., XOTcl's unknown handling was bypassed). - tests/methods.test: Added basic tests on the (current) handling for such ::* dispatches and a specific test set on the intended XOTcl behaviour.

Options
    • -0
    • +114
    ./methods.test
  2. … 1 more file in changeset.
Sunday 13 May 2012
10:19 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- start error messages with a lower case word for consistency and to follow closer to Tcl's conventions

Options
    • -3
    • +3
    ./methods.test
    • -4
    • +4
    ./parameters.test
    • -0
    • +110
    ./protected.test
    • -15
    • +15
    ./submethods.test
    • -2
    • +2
    ./tcloo.test
  6. … 2 more files in changeset.
Friday 11 May 2012
11:48 am

Gustaf Neumann <neumann@wu-wien.ac.at>

- implement escaping for comma in value of parameter options: escaping in values can be achived via duplicating the comma. - extend regression test

Options
    • -6
    • +54
    ./parameters.test
  2. … 2 more files in changeset.
Friday 20 Apr 2012
12:05 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- explorative implementation of object method dispatches with KEEP_CALLER_SELF and no NSF_PER_OBJECT_DISPATCH - extend regression test

Options
    • -7
    • +14
    ./submethods.test
  2. … 2 more files in changeset.
Monday 16 Apr 2012
12:45 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- remove debug line

Options
    • -1
    • +0
    ./submethods.test
Wednesday 11 Apr 2012
12:11 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- add regression test for keepcallerself with and without perobjectdispatch

Options
    • -0
    • +65
    ./submethods.test
Tuesday 10 Apr 2012
6:58 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- serializer: * pertain perobjectdispatch and keepcallerself in serializer * extend regression test

Options
    • -0
    • +38
    ./serialize.test
  2. … 2 more files in changeset.
3:13 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

- serializer: * make [::Serializer deepSerialize -ignoreVarsRE "" $o] behave like [::Serializer deepSerialize $o], since learn@wu depends on that, and a value for ignoreVarsRE of empty looks more like an omitted value than a regular expression, that should match everything. * extended regression test

Options
    • -4
    • +6
    ./serialize.test
  2. … 2 more files in changeset.