Activity nsf/tests

12:20 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
8b19916
changed 2 files
2.2, 2.2.0-repro-patch and 33 more

* nsf.c (NsfMethodForwardCmd): Provide correct scoping condition when requesting a method handle for a submethod forwarder. Added basic tests.

- -0
- +42
./submethods.test
- History
- Source
- Diff
./submethods.test
… 1 more file in changeset.

12:50 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
4e48f10
changed 3 files
2.2, 2.2.0-repro-patch and 33 more

* nsf.c (ObjectCmdMethodDispatch), protected.test: For ensemble (submethod) dispatches, since ever, call protection had not been enforced at all. This commit enables call protection (protected) for ensembles and adds basic tests. * nsfStack.c (GetSelfObj): To allow one to resolve the self reference at arbitrary callstack levels, separate GetSelfObj into GetSelfObj (macro) for the topmost self and GetSelfObj2.

- -0
- +129
./protected.test
- History
- Source
- Diff
./protected.test
… 2 more files in changeset.

7:35 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

More
9c0e457
changed 2 files
2.2, 2.2.0-repro-patch and 33 more

Various Performance Improvements: - Add cache for compiled locals starting with a colon to avoid repeated linear searches - Reduce number of string comparisons in ParamOptionParse() - Factor out ProcContextRequire() - Extend regression test

- -132
- +179
./varresolution.test
- History
- Source
- Diff
./varresolution.test
… 1 more file in changeset.

12:53 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
adedd71
changed 3 files
2.2, 2.2.0-repro-patch and 33 more

* nsf.c (NsfCurrentCmd), nsfStack.c (CallStackNextFrameOfType): Render [current isnextcall] aware of ensembles. Extended submethods.test to cover [current isnextcall] within ensembles.

- -3
- +6
./submethods.test
- History
- Source
- Diff
./submethods.test
… 2 more files in changeset.

10:39 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
2c33882
changed 2 files
2.2, 2.2.0-repro-patch and 33 more

nsf.c (FindSelfNext): Render [current nextmethod] aware of ensembles. Added basic tests.

- -1
- +27
./submethods.test
- History
- Source
- Diff
./submethods.test
… 1 more file in changeset.

10:56 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
2a10ca1
changed 1 file
2.2, 2.2.0-repro-patch and 33 more

submethods.test: Clean up ensembles on top-level objects.

- -0
- +3
./submethods.test
- History
- Source
- Diff
./submethods.test

1:02 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
404b559
changed 2 files
2.2, 2.2.0-repro-patch and 34 more

* nsf.c (GetNextArguments): Ensemble method names via the colon resolver were not cleansed for the colon, leading to a broken method lookup chain. Fix for SF Ticket #1. Added basic tests.

- -0
- +21
./submethods.test
- History
- Source
- Diff
./submethods.test
… 1 more file in changeset.

1:03 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
bc7f267
changed 2 files
2.2, 2.2.0-repro-patch and 34 more

* nsf.c, forward.test (ForwardArg): Extend to recognize alternative element separators in list string reps (NsfHasTclSpace).

- -0
- +4
./forward.test
- History
- Source
- Diff
./forward.test
… 1 more file in changeset.

12:45 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
462bf8f
changed 2 files
2.2, 2.2.0-repro-patch and 34 more

* nsf.c, nsf-cmd.test (ObjectFindMethod): Extend to recognize all element separator chars (NsfHasTclSpace).

- -0
- +5
./nsf-cmd.test
- History
- Source
- Diff
./nsf-cmd.test
… 1 more file in changeset.

12:28 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
33d063a
changed 2 files
2.2, 2.2.0-repro-patch and 34 more

* nsf.c, parameters.test (NsfMethodSetterCmd): Make list detection aware of all list separator chars (NsfHasTclSpace).

- -0
- +1
./parameters.test
- History
- Source
- Diff
./parameters.test
… 1 more file in changeset.

12:17 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
5425e02
changed 2 files
2.2, 2.2.0-repro-patch and 34 more

* nsf.c, parameters.test (NsfOResidualargsMethod): Extend XOTcl's list-notation support to recognize all Tcl list separators (NsfHasTclSpace).

- -1
- +9
./parameters.test
- History
- Source
- Diff
./parameters.test
… 1 more file in changeset.

10:26 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
7e090d5
changed 3 files
2.2, 2.2.0-repro-patch and 34 more

* nsf.c, nsfInt.h: Start housekeeping work on Tcl command/proc names vs. NSF method names to avoid conflicts between ensemle methods and e.g. whitespace-containing command names. Added helper macro NsfHasTclSpace and some first tests. To be continued.

- -0
- +65
./methods.test
- History
- Source
- Diff
./methods.test
… 2 more files in changeset.

12:27 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
67401de
changed 2 files
2.2, 2.2.0-repro-patch and 34 more

* nsf.c (NsfMethodPropertyCmd,NsfForwardPropertyCmd): Remove extra whitespace from error message.

- -0
- +20
./nsf-cmd.test
- History
- Source
- Diff
./nsf-cmd.test
… 1 more file in changeset.

11:35 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
224bb58
changed 1 file
2.2, 2.2.0-repro-patch and 34 more

* methods.test: Add basic tests on composite names under the default unknown handler.

- -0
- +9
./methods.test
- History
- Source
- Diff
./methods.test

6:45 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

More
6af35a8
changed 19 files
2.2, 2.2.0-repro-patch and 34 more

- Use uniform spelling of "Tcl" - Fix more spelling errors

- -1
- +1
./summary.tcl
- History
- Source
- Diff
./summary.tcl
… 18 more files in changeset.

6:40 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

More
0fd6850
changed 12 files
2.2, 2.2.0-repro-patch and 34 more

Use uniform spelling of "Tcl"

- -1
- +1
./summary.tcl
- History
- Source
- Diff
./summary.tcl
… 11 more files in changeset.

12:15 pm

Gustaf Neumann <neumann@wu-wien.ac.at>

More
f934951
changed 44 files
2.2, 2.2.0-repro-patch and 34 more

Improve spelling

- -1
- +1
./disposition.test
- History
- Source
- Diff
./disposition.test
- -8
- +8
./doc.test
- History
- Source
- Diff
./doc.test
- -2
- +2
./info-method.test
- History
- Source
- Diff
./info-method.test
- -1
- +1
./parameters.test
- History
- Source
- Diff
./parameters.test
- -1
- +1
./returns.test
- History
- Source
- Diff
./returns.test
- -2
- +2
./tcl86.test
- History
- Source
- Diff
./tcl86.test
- -1
- +1
./tcloo.test
- History
- Source
- Diff
./tcloo.test
… 37 more files in changeset.

3:16 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
8f64a46
changed 7 files
2.2, 2.2.0-repro-patch and 34 more

* nx.tcl (VariableSlot): Fix value=delete to actually accept and implement "-nocomplain". Added tests (missing so far entirely) and updated the man pages accordingly.

- -0
- +4
./parameters.test
- History
- Source
- Diff
./parameters.test
- -1
- +16
./properties.test
- History
- Source
- Diff
./properties.test
… 5 more files in changeset.

1:41 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
470bd5f
changed 2 files
2.2, 2.2.0-repro-patch and 34 more

* nx.tcl, parameters.test (defineIncrementalOperations): Make sure value=add and value=delete actually run value checkers and, in case of "convert", pick up the conversion result. Added basic test.

- -12
- +25
./parameters.test
- History
- Source
- Diff
./parameters.test
… 1 more file in changeset.

1:01 pm

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
b2ab13e
changed 3 files
slotset-fix

Prepare value=* reform in tests

- -2
- +2
./methods.test
- History
- Source
- Diff
./methods.test
- -7
- +8
./parameters.test
- History
- Source
- Diff
./parameters.test
- -2
- +2
./properties.test
- History
- Source
- Diff
./properties.test

11:44 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
daa771f
changed 2 files
2.2, 2.2.0-repro-patch and 34 more

* nsf.c (ArgumentCheck): Avoid double dispatching to value checkers (built-in and type=*) for "slotset" parameters. Previously, configure and then the value=set (value=add) method triggered one dispatch each. Now, the configure pass skips the check and shifts sole responsibility on the value=set/ value=add methods. Added basic test cases to parameters.test to capture the intended call semantics.

- -0
- +41
./parameters.test
- History
- Source
- Diff
./parameters.test
… 1 more file in changeset.

11:44 am

Stefan Sobernig <stefan.sobernig@wu.ac.at>

More
31c3da1
changed 2 files
slotset-fix

* nsf.c (ArgumentCheck): Avoid double dispatching to value checkers (built-in and type=*) for "slotset" parameters. Previously, configure and then the value=set (value=add) method triggered one dispatch each. Now, the configure pass skips the check and shifts sole responsibility on the value=set/ value=add methods. Added basic test cases to parameters.test to capture the intended call semantics.