generic

Clone Tools
  • last updated 22 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
TopoSort(): cleanup (pt. 2): renamed TopoSort() TopoSortSub() (to match TopoSortSuper)

TopoSort(): cleanup (pt. 1)

Leave a TODO

Provide draft TopoSort2 and helpers

GetNextArguments(): Address CID 102646

Removed two unused functions: NsfObjInfoObjectparameterMethod() and NsfParamDefsFilter(). Makes CID 88775 obsolete

  1. … 1 more file in changeset.
Merge branch 'master' of ssh://alice.wu-wien.ac.at/usr/local/src/git-repo/nsf

Address CID 88770

- Remove occurrences of deprecated Tcl Call Tcl_AppendResult() in overall code

  1. … 1 more file in changeset.
- improve variable for logging from "debugLevel" to "logSeverity" (print logging messages which have a severity larger equal the then given value; so; "nsf::configure debugLevel 0" will print everything, and "nsf::configure debugLevel 3" will print just error messages and omit warnings etc.) - this is not a change in sematics, but removes some confusion in the code. therefore the configure name was not changed - Remove 2 occurrences of deprecated Tcl Call Tcl_AppendResult() in nsfStubLib

  1. … 1 more file in changeset.
- don't compute string length twice

Address potential double freeing problem of runtime states: - the ExitHander() should never be called twice on the same interp. Therefore delete in the ExitProc the ExitHandler AND the ThreadExitHandler and in the ThreadExitProc also both.

Merge branch 'master' of ssh://alice.wu-wien.ac.at/usr/local/src/git-repo/nsf

code generator changes: - create enum types instead of enum values for nsf API - use enum types in code

  1. … 3 more files in changeset.
Improve comment wording and cleanup

FreeFunPtrEntry is not needed actually

Fix refcounting

FreeFunPtrEntry(): Add deletion handler for cmddef and enumeration-type hash entries

nsfCmdDefinitions.c: Fix typos

Merge branch 'master' of ssh://alice.wu-wien.ac.at/usr/local/src/git-repo/nsf

Provide for releasing/deleting the hash tables for cmd definitions and enumeration-type converters in ExitHandler

remove various code smells: - add const declarations - prefer boolean tests - don't write "for" loops without a block - don't pass non-initialized value in an array on index [0] - reduce variable scope - prefer single returns statements in functions - dont't use CONST unless defined by Tcl-API

  1. … 1 more file in changeset.
- make effects of namespace-imported classes more local

  1. … 1 more file in changeset.
FilterSearchAgain(): Avoid running into an invalid pointer access, when the physical deletion of "del" conflicts with following the next link in the cmdList in the loop's increment statement (only iff del == cmdList). Re-organized for into a while loop, to avoid redundant code.

GetClassFromObj(): Fix invalid memory access (valgrind)

- make intentions about clientData clear to static checker

- remove commented code from the previous implementation

- move declarations to the begin of a code block - remove debug code

- use consistent comment styles

- NsfProcStubDeleteProc(): Protect against potentially dangling namespace references from within ::nsf::procs::*. The wrapper cmd's namespace of an nsf::proc might already have been deleted when ::nsf::procs::* shuts down finally. This showed up during a Tcl_Exit (NSF's ExitHandler) as an invalid memory access via (dangling) namespace pointers (valgrind).