OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 6
Total Committers: 146
Last Commit: 21 Nov
Commits this week: 6
Total Lines of Code (LoC): 7,560,943
Net change in LoC this week: 122

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 14 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 01 Jun 2017
11:50 am

gustafn

- make policy3 more consistent and better usable with workflows

Options
    • -9
    • +16
    /openacs-4/packages/xowiki/tcl/package-procs.tcl
11:42 am

gustafn

Ease debugging of policyies and streamline check_permissions with enforce_permissions

Options
    • -9
    • +9
    /openacs-4/packages/xotcl-core/tcl/policy-procs.tcl
Wednesday 31 May 2017
3:47 pm

michaela

Return an error if dependency is missing.

This happens if the (info file of the) required package is not present.

This solution is a bit dirty, but better than throwing the tcl error

"no such variable: spec_file"

Options
    • -1
    • +4
    /openacs-4/packages/acs-admin/www/apm/packages-install-2.tcl
2:47 pm

michaela

Add another constraint name variant as it existed in our production system

Options
    • -1
    • +3
    /openacs-4/packages/faq/sql/postgresql/upgrade/upgrade-5.9.0-5.9.1d1.sql
2:29 pm

michaela

Fix constraint name

Options
    • -1
    • +1
    /openacs-4/packages/new-portal/sql/postgresql/upgrade/upgrade-2.9.0-2.9.1d1.sql
1:48 pm

gustafn

Provide more infrastructure support for host-node-maps for more flexible domain handling

- add optional -cookie_domain parameter to the following functions

ad_user_login

ad_user_logout

sec_generate_session_id_cookie

auth::issue_login (wrapper for ad_user_login)

if not specified, the functions are full backward compatible

- add optional parameter -host_node_id to auth::authenticate

which refers to the node_id in the host-node-map

- pass host_node_id from from/to register pages

TODO:

1) probably, sec_generate_session_id_cookie picks up the wrong

session_id via [ad_conn session_id]

2) check interaction with CookieDomain (probably, we need

must not pass host_node_id wheren CookieDomain is non-empty)

Options
    • -6
    • +31
    /openacs-4/packages/acs-authentication/tcl/authentication-procs.tcl
    • -2
    • +2
    /openacs-4/packages/acs-authentication/tcl/password-procs.tcl
    • -11
    • +12
    /openacs-4/packages/acs-subsite/lib/login.tcl
    • -1
    • +7
    /openacs-4/packages/acs-subsite/www/register/index.adp
    • -1
    • +3
    /openacs-4/packages/acs-subsite/www/register/index.tcl
    • -29
    • +48
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -1
    • +6
    /openacs-4/packages/acs-tcl/tcl/tcltrace-init.tcl
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/tcltrace-procs.tcl
11:56 am

antoniop

Update construct to reload a page, as previous one was not working properly at least on Chrome and Explorer

Options
    • -3
    • +3
    /openacs-4/packages/xowiki/tcl/bootstrap-procs.tcl
11:48 am

gustafn

- add optional parameter host_node_id (for future use)

- Reflow overlong lines

Options
    • -11
    • +35
    /openacs-4/packages/acs-subsite/lib/login.tcl
Tuesday 30 May 2017
11:05 pm

gustafn

- fix bug for obtaining logout_url on host-node mapped subsites

- factor out security::get_register_subsite to streamline behavior of ad_get_login_url and ad_get_logout_url

Options
    • -40
    • +45
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
7:16 pm

antoniop

Improve UI for Hostnode map so it is feasible on sites with many nodes to show navigate the site structure

Options
    • -5
    • +16
    /openacs-4/packages/acs-subsite/www/admin/host-node-map/index.tcl
4:30 pm

gustafn

Modernize code (use ad_include_contract instead of manual checks)

Options
    • -35
    • +23
    /openacs-4/packages/acs-subsite/lib/login.tcl
4:29 pm

gustafn

Flush cache sntries, when host-node-map is updated

Options
    • -1
    • +4
    /openacs-4/packages/acs-subsite/www/admin/host-node-map/index.tcl
2:00 pm

antoniop

Fix typo

Options
    • -1
    • +1
    /openacs-4/packages/file-storage/www/folder-delete.adp
1:58 pm

antoniop

Check if we have already a folder with same name before inserting, or we get error in the logs.

Remove small duplication

Options
    • -8
    • +15
    /openacs-4/packages/file-storage/www/folder-create.tcl
12:36 pm

trenner

prevent bots to generate errors with old buggy urls from their indices

Options
    • -14
    • +22
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
9:55 am

gustafn

never offer items with publish-status "production"; should be probably parameterized in the future

Options
    • -1
    • +2
    /openacs-4/packages/xowiki/tcl/includelet-procs.tcl
Friday 26 May 2017
8:05 pm

gustafn

Fix typos

Options
    • -2
    • +2
    /openacs-4/packages/photo-album/sql/oracle/permissions.sql
    • -2
    • +2
    /openacs-4/packages/photo-album/sql/postgresql/permissions.sql
    • -5
    • +6
    /openacs-4/packages/photo-album/tcl/photo-album-procs.tcl
    • -2
    • +2
    /openacs-4/packages/photo-album/www/album-move.tcl
    • -2
    • +2
    /openacs-4/packages/photo-album/www/base-photo.tcl
    • -2
    • +2
    /openacs-4/packages/photo-album/www/folder-move.tcl
    • -4
    • +4
    /openacs-4/packages/photo-album/www/doc/design.adp
    • -4
    • +4
    /openacs-4/packages/photo-album/www/doc/design.html
    • -3
    • +3
    /openacs-4/packages/photo-album/www/doc/dev-guide.adp
    • -3
    • +3
    /openacs-4/packages/photo-album/www/doc/dev-guide.html
    • -3
    • +3
    /openacs-4/packages/photo-album/www/doc/release-notes.adp
    • -3
    • +3
    /openacs-4/packages/photo-album/www/doc/release-notes.html
    • -4
    • +4
    /openacs-4/packages/photo-album/www/doc/xml/design.xml
    • -3
    • +3
    /openacs-4/packages/photo-album/www/doc/xml/index.xml
    • -4
    • +4
    /openacs-4/packages/photo-album/www/doc/xml/requirements.xml
7:53 pm

gustafn

Fix typos

Options
    • -2
    • +2
    /openacs-4/packages/edit-this-page/sql/oracle/edit-this-page-create.sql
    • -1
    • +1
    /openacs-4/packages/edit-this-page/sql/oracle/upgrade/upgrade-1.6-1.7.sql
    • -1
    • +1
    /openacs-4/packages/edit-this-page/sql/postgresql/edit-this-page-create.sql
7:41 pm

gustafn

Fix typos

Options
    • -4
    • +4
    /openacs-4/packages/workflow/tcl/action-procs.tcl
    • -3
    • +3
    /openacs-4/packages/workflow/tcl/case-procs.tcl
    • -4
    • +4
    /openacs-4/packages/workflow/tcl/state-procs.tcl
    • -1
    • +1
    /openacs-4/packages/workflow/www/admin/action-ae.adp
    • -2
    • +2
    /openacs-4/packages/workflow/www/admin/action-ae.tcl
    • -2
    • +2
    /openacs-4/packages/workflow/www/admin/layer-procs.js
    • -2
    • +2
    /openacs-4/packages/workflow/www/admin/role-ae.tcl
    • -2
    • +2
    /openacs-4/packages/workflow/www/admin/workflow-ae.tcl
    • -2
    • +2
    /openacs-4/packages/workflow/www/admin/workflow-meta-edit.tcl
    • -2
    • +2
    /openacs-4/packages/workflow/www/doc/developer-guide.adp
    • -2
    • +2
    /openacs-4/packages/workflow/www/doc/developer-guide.html
    • -2
    • +2
    /openacs-4/packages/workflow/www/doc/fall-2003-extensions.adp
    • -2
    • +2
    /openacs-4/packages/workflow/www/doc/fall-2003-extensions.html
    • -1
    • +1
    /openacs-4/packages/workflow/www/doc/mockup-sim-ft-5.tcl
    • -2
    • +2
    /openacs-4/packages/workflow/www/doc/specification.adp
  16. … 8 more files in changeset.
7:25 pm

gustafn

Fix typos

Options
    • -1
    • +1
    /openacs-4/packages/bookmarks/sql/oracle/bookmarks-create.sql
    • -1
    • +1
    /openacs-4/packages/bookmarks/sql/oracle/upgrade/upgrade-4.6.2-5.0d1.sql
    • -2
    • +2
    /openacs-4/packages/bookmarks/www/delete-dead-links.tcl
    • -2
    • +2
    /openacs-4/packages/bookmarks/www/doc/index.html
    • -1
    • +1
    /openacs-4/packages/bug-tracker/tcl/bug-tracker-procs.tcl
    • -2
    • +2
    /openacs-4/packages/bug-tracker/www/doc/bug-tracker-spec.adp
    • -2
    • +2
    /openacs-4/packages/bug-tracker/www/doc/bug-tracker-spec.html
7:02 pm

gustafn

security::driver: consider additionally nsssl_v4 nsssl_v6 as possible names

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
5:20 pm

antoniop

Don't report pretty link in export comments for items without a package_id, or export will come out corrupted.

(This is the case for global template objects as en:folder.form)

Options
    • -2
    • +3
    /openacs-4/packages/xowiki/tcl/import-procs.tcl
10:20 am

gustafn

Make sure that driver dict d is set in host-node-mapped cases (many thanks to stefan sobernig for pointin that out)

Options
    • -3
    • +5
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
Wednesday 24 May 2017
8:49 pm

antoniop

Remove sql duplication, converge oracle and postgres codebase

Options
    • -14
    • +0
    /openacs-4/packages/file-storage/tcl/file-storage-procs-oracle.xql
    • -17
    • +0
    /openacs-4/packages/file-storage/tcl/file-storage-procs-postgresql.xql
    • -1
    • +2
    /openacs-4/packages/file-storage/tcl/file-storage-procs.tcl
    • -0
    • +8
    /openacs-4/packages/file-storage/tcl/file-storage-procs.xql
6:09 pm

antoniop

Prevent user from selecting source folder as destination folder when moving files. Localize feedback messages (thanks to Markus Moser for the germen translation)

Options
    • -0
    • +2
    /openacs-4/packages/file-storage/catalog/file-storage.de_DE.ISO-8859-1.xml
    • -2
    • +4
    /openacs-4/packages/file-storage/catalog/file-storage.en_US.ISO-8859-1.xml
    • -0
    • +2
    /openacs-4/packages/file-storage/catalog/file-storage.it_IT.ISO-8859-1.xml
    • -33
    • +34
    /openacs-4/packages/file-storage/www/move.tcl
Tuesday 23 May 2017
10:51 pm

gustafn

- Refactor ad_get_login_url reduce replicated code and to make semantics clearer

- ad_get_login_url handles now as well cases, where a subsite is mapped to an application package on a subsite

- fix a bug in util_current_location in connection with hostnode map

Options
    • -10
    • +5
    /openacs-4/packages/acs-tcl/tcl/defs-procs.tcl
    • -127
    • +144
    /openacs-4/packages/acs-tcl/tcl/security-procs.tcl
    • -5
    • +16
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
10:35 pm

gustafn

Fix typo in comment

Options
    • -2
    • +2
    /openacs-4/packages/acs-tcl/tcl/00-database-procs.tcl
Monday 22 May 2017
8:38 am

gustafn

provide default for email_verified_p

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/member-state-change.tcl
8:31 am

gustafn

- Don't name valdation black and formal argument the same

Options
    • -2
    • +2
    /openacs-4/packages/acs-admin/www/users/member-state-change.tcl
Sunday 21 May 2017
2:46 pm

gustafn

make sure, the message key in the comment is shown correctly in API browser

Options
    • -2
    • +2
    /openacs-4/packages/acs-lang/tcl/lang-util-procs.tcl