OpenACS

Tools

Line History

Line Count Graph
Line Count Graph

Stats

Commits this week: 7
Total Committers: 146
Last Commit: 01 Nov
Commits this week: 7
Total Lines of Code (LoC): 7,561,878
Net change in LoC this week: -2

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated 21 hours ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 05 Oct 2022
4:04 pm

gustafn

Support for handler for double-click prevention via CSS class

This change makes it possible to provide a double click prevention for

HTML elements via the CSS class "prevent-double-click". The double

click prevention deactivates a button or an anchor element after

clicking for a short time (per default for 1s) and ignores in this

time window further clicks. The time window can be specified via the

data element oacs-timeout. When a double click occurs, the duplicate

click is determined at the client side (in the browser) such that the

first request will continue to run and will render its result when

finished. Without double-click prevention (or with the

double-click-prevention on the server side), the results of the first

request are lost for the client, although these are still computed at

the server side.

Usage Example:

<p>text with a <a class="prevent-double-click" data-oacs-timeout="2000" href="/slow.tcl?t=10s">link</a>

<p>

<form action="/slow.tcl">

<input class="btn prevent-double-click" data-oacs-timeout="2000" type="submit" value="Submit">

...

</form>

By reactivating the button automatically after the timeout, this

approach works also reasonable well when opening additional tabs or

browser windows.

The handler and implementation are designed to work with streaming

HTML, provided that "template::collect_body_scripts" is called (like

the reset of the template::* styling interface).

When HTML elements are deactivated, the DOM property "disabled" is set

as well as a CSS class "disabled". Since disabled anchors are

visually not different from non-disabled anchors, this CSS class can

be used for styling disabled anchors differently.

Options
    • -0
    • +43
    /openacs-4/packages/acs-templating/tcl/head-procs.tcl
3:44 pm

antoniop

Improve performances of the applications list

Options
    • -16
    • +19
    /openacs-4/packages/acs-subsite/www/admin/applications/index-postgresql.xql
    • -2
    • +4
    /openacs-4/packages/acs-subsite/www/admin/applications/index.tcl
3:42 pm

antoniop

Whitespace cleanup

Options
    • -5
    • +5
    /openacs-4/packages/acs-subsite/www/admin/applications/index-postgresql.xql
11:51 am

gustafn

Styling improvements for exam answering workflows (many thanks to Monika Andergassen)

- provide explicit text to "next" and "previous" buttons in pagination menu

- align appearance of "next" and "previous" buttons in pagination menu with GitHub

- removed class "input-group" for compound fields to improve appearance

- bumped version number of xowf to 5.10.1d48

Options
    • -3
    • +3
    /openacs-4/packages/xowf/xowf.info
    • -1
    • +1
    /openacs-4/packages/xowf/lib/inclass-exam-answer.wf
    • -2
    • +2
    /openacs-4/packages/xowf/tcl/test-item-procs.tcl
    • -0
    • +1
    /openacs-4/packages/xowf/www/resources/test-item.css
    • -2
    • +2
    /openacs-4/packages/xowiki/tcl/form-field-procs.tcl
11:41 am

gustafn

adp:icon: extended list of generic names and support reloading

- adp:icon: added "next" and "previous" to generic names

- moved variable ::template::icon::map from *init.tcl to style-procs.tcl

to support changes via dynamic reloading via package manager

- bumped version number to 5.10.1d17

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/acs-templating.info
    • -0
    • +105
    /openacs-4/packages/acs-templating/tcl/style-procs.tcl
    • -95
    • +1
    /openacs-4/packages/acs-templating/tcl/tag-init.tcl
9:58 am

gustafn

fix markup of documentation block

Options
    • -2
    • +2
    /openacs-4/contrib/packages/irc-logger/tcl/irc-logger-procs.tcl
Tuesday 04 Oct 2022
6:00 pm

antoniop

Port of downstream changes: grand admin permissions also on the admins of the parent community

Options
    • -1
    • +19
    /openacs-4/packages/dotlrn-calendar/tcl/dotlrn-calendar-procs.tcl
5:43 pm

antoniop

Improve idiom (port from downstream)

Options
    • -5
    • +2
    /openacs-4/packages/dotlrn-calendar/tcl/dotlrn-calendar-procs.tcl
5:35 pm

antoniop

Port of downstream changes: revoke the automatically assigned calendar_admin permissions to the creation user when a new calendar is added to a community via the applet, as they are not actually needed

Options
    • -10
    • +21
    /openacs-4/packages/dotlrn-calendar/tcl/dotlrn-calendar-procs.tcl
5:07 pm

gernst

Allow only one format for the 'date' query parameter, bringing the page contract in line with the "Go to date"-form on this page from which this value is supplied.

Options
    • -2
    • +2
    /openacs-4/packages/calendar/www/view.tcl
5:00 pm

antoniop

Validate field names when these might come directly from the POST request and therefore contain arbitrary text

Options
    • -3
    • +20
    /openacs-4/packages/xowiki/tcl/xowiki-www-procs.tcl
Monday 03 Oct 2022
2:20 pm

antoniop

Now that oneof filter can handle a wider range of formattings, prefer this filter to manual validation

Options
    • -9
    • +2
    /openacs-4/packages/general-comments/www/comment-add-2.tcl
    • -9
    • +2
    /openacs-4/packages/general-comments/www/comment-edit-2.tcl
    • -9
    • +2
    /openacs-4/packages/general-comments/www/comment-edit-3.tcl
1:34 pm

antoniop

Prefer literal to noquote in template properties

Options
    • -2
    • +2
    /openacs-4/packages/contacts-lite/www/add-edit.adp
    • -2
    • +2
    /openacs-4/packages/contacts-lite/www/delete.adp
    • -2
    • +2
    /openacs-4/packages/contacts-lite/www/export.adp
    • -2
    • +2
    /openacs-4/packages/contacts-lite/www/index.adp
    • -2
    • +2
    /openacs-4/packages/contacts-lite/www/master.adp
    • -2
    • +2
    /openacs-4/packages/contacts-lite/www/one.adp
    • -1
    • +1
    /openacs-4/packages/contacts-lite/www/addresses/add-edit.adp
    • -2
    • +2
    /openacs-4/packages/contacts-lite/www/addresses/address-delete.adp
    • -2
    • +2
    /openacs-4/packages/contacts-lite/www/addresses/delete.adp
    • -2
    • +2
    /openacs-4/packages/contacts-lite/www/addresses/index.adp
    • -2
    • +2
    /openacs-4/packages/contacts-lite/www/addresses/one.adp
    • -2
    • +2
    /openacs-4/packages/contacts-lite/www/admin/index.adp
    • -2
    • +2
    /openacs-4/packages/contacts-lite/www/admin/address-type/add-edit.adp
    • -2
    • +2
    /openacs-4/packages/contacts-lite/www/admin/address-type/delete.adp
    • -2
    • +2
    /openacs-4/packages/contacts-lite/www/admin/address-type/index.adp
  16. … 12 more files in changeset.
1:33 pm

antoniop

Prefer literal to noquote in template properties

Options
    • -2
    • +2
    /openacs-4/packages/scorm-simple-lms/www/admin/confirm-delete.adp
    • -2
    • +2
    /openacs-4/packages/scorm-simple-lms/www/admin/delete-course.adp
    • -2
    • +2
    /openacs-4/packages/scorm-simple-lms/www/admin/edit-properties.adp
Friday 30 Sep 2022
6:51 pm

antoniop

Handle acs-mail-lite conf regarding the recipient in the test

Options
    • -2
    • +11
    /openacs-4/packages/acs-authentication/tcl/test/local-procs.tcl
3:31 pm

antoniop

Make sure test email is fine even when usernames are emails

Options
    • -3
    • +5
    /openacs-4/packages/acs-authentication/tcl/test/sync-test-procs.tcl
3:19 pm

antoniop

Use lowercase letter to append to the fake username, so that if it should be an email, it will still be valid

Options
    • -2
    • +2
    /openacs-4/packages/acs-authentication/tcl/test/sync-test-procs.tcl
11:27 am

gustafn

Replace calls to deprecated call "util_commify_number"

Use lc_numeric instead

Options
    • -2
    • +2
    /openacs-4/packages/schema-browser/tcl/schema-browser-procs-postgresql.tcl
Thursday 29 Sep 2022
6:10 pm

gustafn

revert escaped version

Options
    • -14
    • +12
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
6:04 pm

gustafn

reduce verbosity

Options
    • -3
    • +7
    /openacs-4/packages/acs-tcl/tcl/acs-db-00-procs.tcl
    • -12
    • +14
    /openacs-4/packages/acs-tcl/tcl/parameter-procs.tcl
    • -6
    • +6
    /openacs-4/packages/acs-tcl/tcl/text-html-procs.tcl
Wednesday 28 Sep 2022
11:16 am

gustafn

reduce verbosity

Options
    • -2
    • +2
    /openacs-4/packages/acs-templating/tcl/element-procs.tcl
11:16 am

gustafn

improve comments

Options
    • -5
    • +3
    /openacs-4/packages/acs-templating/tcl/util-procs.tcl
11:12 am

gustafn

avoid deprecated proc template::util::is_true

Options
    • -4
    • +4
    /openacs-4/packages/workflow/tcl/action-procs.tcl
    • -3
    • +3
    /openacs-4/packages/workflow/tcl/state-procs.tcl
10:48 am

gustafn

remove constant from deprecated message

Options
    • -2
    • +5
    /openacs-4/packages/acs-bootstrap-installer/tcl/00-proc-procs.tcl
10:20 am

gustafn

Give people the chance to use OpenACS with WithDeprecatedCode set to 0

When OpenACS is configured to omit loading of long deprecated code

(WithDeprecatedCode set to 0) files like deprecated-procs.tcl are not

loaded. Therefore, these files should only contain code, which was

deprecated at LEAST ONE RELEASE EARLIER, such that site admins have

one release time to fix calls to deprecated code. This is especially

important for public procs.

Options
    • -102
    • +2
    /openacs-4/packages/acs-tcl/tcl/deprecated-procs.tcl
    • -2
    • +107
    /openacs-4/packages/acs-tcl/tcl/utilities-procs.tcl
Sunday 25 Sep 2022
10:54 pm

antoniop

Follow the litmus test suite and address issues reported in the "props" section:

* allow properties expressed in "high unicode" by using the database, rather than the filesystem to store them. (TODO: provide an own data-model, right now I am using persistent client properties)

* return all requested properties, reporting 404 when these properties do not exist

Options
    • -123
    • +127
    /openacs-4/packages/oacs-dav/tcl/tDAV-procs.tcl
Saturday 24 Sep 2022
9:27 pm

antoniop

Cleanup debug

Options
    • -2
    • +1
    /openacs-4/packages/oacs-dav/tcl/oacs-dav-procs.tcl
9:06 pm

antoniop

Follow the litmus test suite and improve standard compliance for the "copymove" test section:

- return 204 when trying to copy on an existing resource (by trimming traling slash in the destination path before checking)

- return 409 when one tries to copy/move to a non-existant resource

This makes the "copymove" section pass without warnings

Options
    • -5
    • +11
    /openacs-4/packages/oacs-dav/tcl/oacs-dav-procs.tcl
Wednesday 21 Sep 2022
2:22 pm

antoniop

Fix boolean expression, as the permission api will return a generic boolean, not necessarily 1 or 0

Options
    • -2
    • +2
    /openacs-4/packages/oacs-dav/tcl/oacs-dav-procs.tcl
2:17 pm

antoniop

Fix query in oacs_dav::children_have_permission_p

Options
    • -1
    • +1
    /openacs-4/packages/oacs-dav/tcl/oacs-dav-procs-postgresql.xql